Repository navigation
libdatadog update to 7f3b16fe - #4244
Conversation
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 00b7177 | Docs | View more details | Give us feedback! |
36f6a11 to
15f22e1
Compare
ec66510 to
eca8d1d
Compare
Benchmarks [ tracer ]Benchmark execution time: 2026-10-02 03:52:16 Comparing candidate commit 541edf5 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 194 metrics, 0 unstable metrics.
|
79b5e4e to
06ce042
Compare
3d67f85 to
628a1b5
Compare
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/142269044 Full CI result: ❌ 1 job(s) failed
8b0b853 to
a468b7a
Compare
Automated update by CI pipeline https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/142270926 Full CI result: ❌ 143 job(s) failed
Summary
Automated update of the libdatadog submodule to the latest HEAD.
$LIBDATADOG_PINNED_SHA7f3b16fe1b4bfc2a016ef869459e915ee02d6d6aFull CI result: ❌ 143 job(s) failed
CI pipeline: https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-php/-/pipelines/142270926
libdatadog Integration Report
libdatadog SHA: 7f3b16fe1b4bfc2a016ef869459e915ee02d6d6a
Analysis date: 2026-10-04
Overall status
The change is a build-manifest change, not a Rust API change. No compiler was
available here, so the fix has not been checked with a build. Cargo stopped
before compiling any code, so the CI logs could not show compile errors behind
the manifest error. I reviewed the new libdatadog commits by hand and found
none that need source changes on our side (see below).
Build & test summary
143 jobs failed in pipeline 142270926, across the shared, profiler and appsec
sub-pipelines:
and variants)
and alpine)
(including SSI)
All 48 captured traces fail at the same point. The first Cargo invocation
fails to load the workspace:
The other 95 failed jobs have no trace. All of them run Cargo inside the
dd-trace-php workspace (they build
datadog-php, the sidecar or the helper),so they almost certainly fail on the same error. That is an inference: I had
no logs for those jobs to confirm it.
Root cause. libdatadog crates are built as members of the dd-trace-php
root workspace. Their
foo.workspace = truedependencies therefore resolveagainst
[workspace.dependencies]in ourCargo.toml, which mirrorslibdatadog's table. libdatadog commit
804093337("fix(data-pipeline)!:revert changes that made /info un-parsable", #2586) added a new
serde_ignoreddependency tolibdd-data-pipeline, used as adev-dependency. It was added to libdatadog's workspace table but not to ours.
Cargo resolves every manifest in the workspace, dev-dependencies included,
before it builds anything, so every Cargo invocation fails.
Non-trivial changes made
Cargo.toml([workspace.dependencies]):serde_ignored = { version = "0.1.14", default-features = false },copied from
libdatadog/Cargo.toml. This fixes the error above.async-traitfrom"0.1"to"0.1.85"to match libdatadog'stable (libdatadog commits
e35a4f9ba/cbe1b7292). This keeps themirror in sync; it is not strictly needed to build.
I did not hand-edit
Cargo.lock. CI does not run Cargo with--locked/--frozen, so Cargo will addserde_ignored 0.1.14to the lockfile itself. If you want the lock file committed in sync, run
cargo update -p serde_ignored(or any build) once locally.Review of the other new libdatadog commits
The last adapted pin was in #4259, which covered
e8c680a7e(the ratelimiter change). These are the commits since then:
804093337/infoschema revert, newserde_ignoreddependencyAgentInfoStructfields read incomponents-rs/agent_info.rsare unchanged. OnlyAgentObfuscationConfigchanged, and we don't use it.ab1c67af6_dd.sdk.otlp_export,datadog.sdk.semantics)b1d377615build.rs(path build-dependencycc_utils) and an opt-in featuretrampoline-host-loader. No change needed in our manifests.e35a4f9ba4c1e1ef16,7f3b16fe1e8cdc8587,38d53e4f6,e5c044566,188a1f3b0Identified libdatadog issues
None identified. The failure comes from how dd-trace-php is set up: we
mirror libdatadog's
[workspace.dependencies]by hand. It is not a libdatadogbug.
A possible follow-up: CI could check that every key in libdatadog's
[workspace.dependencies]also exists in the rootCargo.toml. That wouldcatch this kind of drift with a clearer error.
Flaky / ignored failures
None. All 143 failures are explained by the single manifest error above.
/cc @bwoebi