Fix tiny misconfiguration of phpcs, and add defaults in .phpcs.xml file #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
reviewed
Jul 23, 2018
|
|
||
| <rule ref="Generic.Commenting.Todo"/> | ||
| <rule ref="Generic.Commenting.Fixme"/> | ||
| <rule ref="Generic.Commenting.DocComment.MissingShort"> |
Contributor
There was a problem hiding this comment.
Maybe fix the indentation here?
Contributor
Author
There was a problem hiding this comment.
Yeah having consistent indentation sounds like a good idea 👍 😄
.phpcs.xml
Outdated
| </rule> | ||
|
|
||
| <exclude-pattern>*/vendor/*</exclude-pattern> | ||
| </ruleset> No newline at end of file |
Contributor
There was a problem hiding this comment.
How about adding a final newline?
Also see #40.
pawelchcki
deleted the
phpcs_use_local_configuraiton_file_remove_unused_zend_sniffs_use_psr12
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
phpcswas used with bothZendandPSR2however only PSR2 was effectively used.This PR instead uses PSR12 (a newer PSR2 with changes that are still compatible with our codebase).
In addition it adds my personal Favorites of disallowing
TodoandFixmecomments.With
.phpcs.xmllinting now also correctly works with VS Code extension PHP linter.