Skip to content

Fix: Apply further fixes to examples #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chuck merged 1 commit into from
Jul 12, 2018
Merged

Fix: Apply further fixes to examples #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ To start using the DataDog Tracer with the OpenTracing API, you should first ini
use DDTrace\Tracer;
use OpenTracing\GlobalTracer;

...

// Creates a tracer with default transport and default propagators
$tracer = new Tracer();

Expand All @@ -45,7 +43,6 @@ $application->run();
register_shutdown_function(function() {
GlobalTracer::get()->flush();
});

```

PHP as a request scoped language has no simple means to pass the collected spans data to a background process without blocking the main request thread/process. It is mandatory to execute the `Tracer::flush()` after the response is served to the client by using [`register_shutdown_function`](http://php.net/manual/en/function.register-shutdown-function.php).
Expand All @@ -55,6 +52,9 @@ PHP as a request scoped language has no simple means to pass the collected spans
Transport can be customized by the config parameters:

```php
use DDTrace\Encoders\Json;
use DDTrace\Transport\Http;

$transport = new Http(
new Json(),
$logger,
Expand All @@ -67,6 +67,9 @@ $transport = new Http(
Tracer can be customized by the config settings:

```php
use DDTrace\Tracer;
use OpenTracing\Formats;

// Config for tracer
$config = [
'service_name' => 'my_service', // The name of the service.
Expand Down