-
Notifications
You must be signed in to change notification settings - Fork 167
Use native rust spans instead of manually serializing to msgpack #3194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f4bc20f
to
c62e164
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3194 +/- ##
=======================================
Coverage 61.92% 61.92%
=======================================
Files 140 140
Lines 12356 12356
Branches 1616 1616
=======================================
Hits 7651 7651
Misses 3995 3995
Partials 710 710 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Benchmarks [ tracer ]Benchmark execution time: 2025-07-28 21:40:06 Comparing candidate commit 52b50d3 in PR branch Found 3 performance improvements and 16 performance regressions! Performance is the same for 158 metrics, 1 unstable metrics. scenario:PDOBench/benchPDOBaseline
scenario:PDOBench/benchPDOBaseline-opcache
scenario:PDOBench/benchPDOOverhead
scenario:PDOBench/benchPDOOverhead-opcache
scenario:PDOBench/benchPDOOverheadWithDBM
scenario:PDOBench/benchPDOOverheadWithDBM-opcache
scenario:PHPRedisBench/benchRedisOverhead
scenario:PHPRedisBench/benchRedisOverhead-opcache
scenario:SpanBench/benchDatadogAPI
scenario:SpanBench/benchDatadogAPI-opcache
scenario:SpanBench/benchOpenTelemetryAPI
scenario:SpanBench/benchOpenTelemetryAPI-opcache
scenario:SpanBench/benchOpenTelemetryInteroperability
scenario:SpanBench/benchOpenTelemetryInteroperability-opcache
scenario:TraceFlushBench/benchFlushTrace
scenario:TraceFlushBench/benchFlushTrace-opcache
scenario:TraceSerializationBench/benchSerializeTrace
|
2c37585
to
22111fc
Compare
0b2c6a2
to
674b060
Compare
a143161
to
4f3f47a
Compare
7fedf9e
to
587ec86
Compare
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
…Slice Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com>
4f62615
to
2b76f8f
Compare
a41a132
to
87b4804
Compare
Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
…use-rust-span-in-tracer
87b4804
to
c3c9b98
Compare
…use-rust-span-in-tracer
d329dcf
to
52b50d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally this gets merged :-)
* feat(component-rs): add data-pipeline header Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * Fix missing use Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Update libdatadog Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * feat(tracer): use rust span API Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * chore: bump libdatadog Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * feat(tracer: serializer): complete replacement of rust span API in serialization method Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * feat(ext: tracer): add local API to use zendString instead of CharSlice Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * feat(ext: tracer): apply PR feedbacks Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * feat(tracer): modify communication code between the tracer and sidecar Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * feat(tracer): add function to convert a rust span to a zval Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * chore: fix tests Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * chore: fix tests Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * Switch to new way to pass zend_strings Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * chore: fix tests Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * chore: remove useless free statements Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * chore: fix remaining failing tests Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * test: fix windows compiling tests Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * feat: move rust span code to sidecar-ffi Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * feat: improve serializer performance by using literal instead of CharSlice Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> * chore: rebase with master Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> --------- Signed-off-by: Alexandre Rulleau <alexandre.rulleau@datadoghq.com> Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>
Description
Reviewer checklist