Skip to content

Revert unintended change in extension_no_static_tls.phpt#2879

Merged
bwoebi merged 2 commits intomasterfrom
glopes/rev-static-tls-test
Oct 8, 2024
Merged

Revert unintended change in extension_no_static_tls.phpt#2879
bwoebi merged 2 commits intomasterfrom
glopes/rev-static-tls-test

Conversation

@cataphract
Copy link
Contributor

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (e1405d2) to head (6b1cc8f).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2879   +/-   ##
=========================================
  Coverage     80.91%   80.91%           
  Complexity     2526     2526           
=========================================
  Files           146      146           
  Lines         14711    14711           
=========================================
  Hits          11903    11903           
  Misses         2808     2808           
Flag Coverage Δ
tracer-extension 78.10% <ø> (ø)
tracer-php 82.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1405d2...6b1cc8f. Read the comment docs.

Copy link
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@cataphract cataphract marked this pull request as ready for review October 8, 2024 14:23
@cataphract cataphract requested a review from a team as a code owner October 8, 2024 14:23
@bwoebi bwoebi merged commit dcc880f into master Oct 8, 2024
@bwoebi bwoebi deleted the glopes/rev-static-tls-test branch October 8, 2024 14:24
@github-actions github-actions bot added this to the 1.5.0 milestone Oct 8, 2024
@bwoebi bwoebi modified the milestones: 1.5.0, 1.4.0 Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments