Add support for memcached on PHP 8 #1558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1535. Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
labbati
reviewed
Apr 5, 2022
Member
labbati
left a comment
labbati
left a comment
There was a problem hiding this comment.
Changes look good to me, but we should just run again the failing tests once 8.0 and 8.1 buster images get pushed.
labbati
previously approved these changes
Apr 5, 2022
bwoebi
force-pushed
the
bob/add-memcached-php8
branch
from
009eff1 to
4fcb076
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1535.
Readiness checklist
Reviewer checklist