[Bug]: Standalone null Return Type for update_span_duration Causes Phan Parsing to Fail for PHP <8.2 #2585

Activity

1. ghost added

   🐛 bugSomething isn't workingSomething isn't working

   on Mar 20, 2024
2. morrisonlevi commented on Mar 20, 2024

   

   morrisonlevi

   on Mar 20, 2024

   Collaborator

   More actions

   Indeed, it looks like it should be false|null, returning false on invalid parameters:

   dd-trace-php/ext/ddtrace.c

   Lines 2324 to 2329 in 5d2c3cb

   	PHP_FUNCTION(DDTrace_update_span_duration) {
   	double finish_time_seconds = 0;
   	zval *spanzv = NULL;
   	if (zend_parse_parameters(ZEND_NUM_ARGS(), "O|d", &spanzv, ddtrace_ce_span_data, &finish_time_seconds) != SUCCESS) {
   	RETURN_FALSE;
   	}

   @bwoebi Should we update false here or take an alternative action?
3. PROFeNoM

   closed this as completedin #2586on Mar 21, 2024