Repository navigation
test(dns): remove live resolver dependency - #9950
Conversation
Overall package sizeSelf size: 8.63 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9950 +/- ##
==========================================
- Coverage 98.62% 98.62% -0.01%
==========================================
Files 996 996
Lines 152006 152006
Branches 13112 13265 +153
==========================================
- Hits 149920 149919 -1
- Misses 2086 2087 +1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-08-31 17:50:40 Comparing candidate commit 6e849c2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2299 metrics, 11 unstable metrics.
|
4117ee3 to
e8c2668
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 07a8e0af62
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
DNS plugin tests queried public DNS while the mock-agent timeout measured both lookup and trace delivery, so a slow resolver reported a missing trace and left the request running into teardown. The trace-delivery window now starts after the owned DNS operation settles.
Reverse lookups require a valid IP, so test-local resolvers cancel requests against a loopback endpoint without waiting for external DNS.
5917a05 to
6f5433d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f5433d689
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Calling dns.setServers() replaces the top-level resolver functions, so setup must run before instrumentation wraps them.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 890d8fd936
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
dns.setServers() replaces the module top-level functions, so repeated setup can discard instrumentation before later tests run.
DNS plugin tests queried lvh.me, so resolver latency could exhaust the mock-agent timeout and leave c-ares work active during teardown. Forward-lookup tests now use parser-rejected hostnames. Reverse tests use a closed loopback endpoint and await both the rejection and trace. Setup configures the default resolver before instrumentation because dns.setServers() replaces the top-level resolver functions. Refs: DataDog/dd-trace-js/actions/runs/32678296794/job/97290335175?pr=9933
DNS plugin tests queried lvh.me, so resolver latency could exhaust the mock-agent timeout and leave c-ares work active during teardown. Forward-lookup tests now use parser-rejected hostnames. Reverse tests use a closed loopback endpoint and await both the rejection and trace. Setup configures the default resolver before instrumentation because dns.setServers() replaces the top-level resolver functions. Refs: DataDog/dd-trace-js/actions/runs/32678296794/job/97290335175?pr=9933
DNS plugin tests queried lvh.me, so resolver latency could exhaust the mock-agent timeout and leave c-ares work active during teardown. Forward-lookup tests now use parser-rejected hostnames. Reverse tests use a closed loopback endpoint and await both the rejection and trace. Setup configures the default resolver before instrumentation because dns.setServers() replaces the top-level resolver functions. Refs: DataDog/dd-trace-js/actions/runs/32678296794/job/97290335175?pr=9933
DNS plugin tests queried lvh.me, so resolver latency could exhaust the mock-agent timeout and leave c-ares work active during teardown. Forward-lookup tests now use parser-rejected hostnames. Reverse tests use a closed loopback endpoint and await both the rejection and trace. Setup configures the default resolver before instrumentation because dns.setServers() replaces the top-level resolver functions. Refs: DataDog/dd-trace-js/actions/runs/32678296794/job/97290335175?pr=9933
2 participants
DNS plugin tests queried
lvh.me, so resolver latency could exhaust the mock-agent timeout and leave c-ares work active during teardown.Forward-lookup tests now use parser-rejected hostnames. Reverse tests use a closed loopback endpoint and await both the rejection and trace. Setup configures the default resolver before instrumentation because
dns.setServers()replaces the top-level resolver functions.Refs: https://github.com/DataDog/dd-trace-js/actions/runs/32678296794/job/97290335175?pr=9933