Repository navigation
feat(llmobs): add BaseEvaluator support for Experiments - #9848
Conversation
f42f91b to
8649c8f
Compare
Overall package sizeSelf size: 9.34 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.5.1 | 127.66 kB | 513.61 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
✅ All CI checks and tests passed. Datadog automation helped this PR pass. 🎉 All green!🧪 All tests passed 🔄 Datadog retried 2 tests - 2 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: 5b50359 | Docs | View more details | Give us feedback! |
BenchmarksBenchmark execution time: 2026-10-01 19:26:37 Comparing candidate commit 5b50359 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2300 metrics, 13 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9848 +/- ##
==========================================
+ Coverage 98.78% 98.85% +0.06%
==========================================
Files 1042 1048 +6
Lines 167109 169089 +1980
Branches 74 74
==========================================
+ Hits 165081 167146 +2065
+ Misses 2028 1943 -85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ments-parity # Conflicts: # index.d.ts # index.d.v5.ts # packages/dd-trace/src/config/generated-config-types.d.ts # packages/dd-trace/src/config/index.js # packages/dd-trace/src/config/supported-configurations.json # packages/dd-trace/src/llmobs/experiments/experiment.js # packages/dd-trace/src/llmobs/experiments/index.js # packages/dd-trace/src/llmobs/noop.js # packages/dd-trace/src/llmobs/sdk.js # packages/dd-trace/test/config/index.spec.js # packages/dd-trace/test/llmobs/experiments/example.js # packages/dd-trace/test/llmobs/experiments/index.spec.js # packages/dd-trace/test/llmobs/sdk/index.spec.js
…ments-parity # Conflicts: # index.d.ts # index.d.v5.ts
87f7e44 to
da49206
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da49206da1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9bfdf6c977
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sabrenner
left a comment
There was a problem hiding this comment.
just one small nit, and i think some of the codex comments probs need addressing, but otherwise lgtm! approving to unblock once codex comments are addressed
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6faeb6f120
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Stack
1 of 2 — base:
master. The RemoteEvaluator follow-up is #10487.What does this PR do?
Adds dd-trace-js LLM Experiments parity features for project configuration and the core class-based evaluator API:
llmobs.projectNameandDD_LLMOBS_PROJECT_NAMEconfiguration.BaseEvaluatorandBaseSummaryEvaluatorclasses with evaluator contexts; theirevaluate()methods may be synchronous or asynchronous.EvaluatorResultandMultiEvaluatorResultvalues.mlApp/servicefallback behavior.Evaluator scope
This PR intentionally provides the evaluator primitives and result model, not a catalog of evaluator implementations:
LLMJudge, and structured-output evaluator helpers.CSV upload remains out of scope.
Motivation
Bring the JavaScript Experiments API closer to the dd-trace-py LLM Experiments setup while keeping the initial evaluator surface focused on reusable primitives. Applications can implement their own evaluator logic and attach rich metadata to emitted metrics without committing the JavaScript SDK to a built-in evaluator catalog.
Additional Notes
master.127.0.0.1:9126and were excluded from the local run.