Repository navigation
fix(undici): prevent context retention after requests - #9406
Merged
Merged
Conversation
Contributor
Overall package sizeSelf size: 8.74 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: e92c153 | Docs | View more details | Give us feedback! |
BenchmarksBenchmark execution time: 2026-09-03 19:36:49 Comparing candidate commit e92c153 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2316 metrics, 12 unstable metrics.
|
BridgeAR
force-pushed
the
BridgeAR/2026-07-16-fix-undici-context-retention
branch
2 times, most recently
from
August 5, 2026 23:54
0f9df13 to
70c86a7
Compare
BridgeAR
force-pushed
the
BridgeAR/2026-07-16-fix-undici-context-retention
branch
from
August 8, 2026 18:26
70c86a7 to
b83ebdc
Compare
BridgeAR
marked this pull request as ready for review
August 12, 2026 13:01
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6ffd458e4e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
BridgeAR
force-pushed
the
BridgeAR/2026-07-16-fix-undici-context-retention
branch
from
September 3, 2026 14:33
6ffd458 to
6067da7
Compare
BridgeAR
force-pushed
the
BridgeAR/2026-07-16-fix-undici-context-retention
branch
from
September 3, 2026 15:52
6067da7 to
5da6c72
Compare
bengl
approved these changes
Sep 3, 2026
BridgeAR
force-pushed
the
BridgeAR/2026-07-16-fix-undici-context-retention
branch
from
September 3, 2026 16:09
5da6c72 to
9acf1d8
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9acf1d87a3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Native diagnostic callbacks entered request spans into the caller's async context. The context outlived finished requests, retained downstream resources, and made later work inherit the wrong span. Keep native diagnostics for normal request lifecycles and instrument only Undici's accepted-upgrade callback, which has no terminal diagnostic event. Activate the request span only while a configured request hook runs. The request-create hot path no longer copies the async store or switches context twice. In two fresh one-million-iteration runs it improved from 43.1-43.5 ns to 10.1-10.2 ns per operation. Refs: nodejs/undici#5761
Released Undici versions omit terminal diagnostics for accepted upgrades, but patched and backported implementations can share those versions. Inspecting the loaded Request method avoids wrapping implementations that already publish terminal trailers.
BridgeAR
force-pushed
the
BridgeAR/2026-07-16-fix-undici-context-retention
branch
from
September 3, 2026 18:09
9acf1d8 to
6b46468
Compare
Accepted upgrade handlers can throw after Undici removes the request from its queue. Affected versions then destroy the socket without a terminal diagnostic event, which retains the span. Publish one fallback error event and rethrow the original error. Scope the hook-context assertion to native diagnostics versions so Node 26 does not format unrelated cyclic span graphs.
bengl
approved these changes
Sep 3, 2026
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
* fix(undici): prevent context retention after requests Native diagnostic callbacks entered request spans into the caller's async context. The context outlived finished requests, retained downstream resources, and made later work inherit the wrong span. Keep native diagnostics for normal request lifecycles and instrument only Undici's accepted-upgrade callback, which has no terminal diagnostic event. Activate the request span only while a configured request hook runs. The request-create hot path no longer copies the async store or switches context twice. In two fresh one-million-iteration runs it improved from 43.1-43.5 ns to 10.1-10.2 ns per operation. Refs: nodejs/undici#5761 * fix(undici): gate upgrade fallback by source Released Undici versions omit terminal diagnostics for accepted upgrades, but patched and backported implementations can share those versions. Inspecting the loaded Request method avoids wrapping implementations that already publish terminal trailers. * fix(undici): finish spans after upgrade handler errors Accepted upgrade handlers can throw after Undici removes the request from its queue. Affected versions then destroy the socket without a terminal diagnostic event, which retains the span. Publish one fallback error event and rethrow the original error. Scope the hook-context assertion to native diagnostics versions so Node 26 does not format unrelated cyclic span graphs.
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
* fix(undici): prevent context retention after requests Native diagnostic callbacks entered request spans into the caller's async context. The context outlived finished requests, retained downstream resources, and made later work inherit the wrong span. Keep native diagnostics for normal request lifecycles and instrument only Undici's accepted-upgrade callback, which has no terminal diagnostic event. Activate the request span only while a configured request hook runs. The request-create hot path no longer copies the async store or switches context twice. In two fresh one-million-iteration runs it improved from 43.1-43.5 ns to 10.1-10.2 ns per operation. Refs: nodejs/undici#5761 * fix(undici): gate upgrade fallback by source Released Undici versions omit terminal diagnostics for accepted upgrades, but patched and backported implementations can share those versions. Inspecting the loaded Request method avoids wrapping implementations that already publish terminal trailers. * fix(undici): finish spans after upgrade handler errors Accepted upgrade handlers can throw after Undici removes the request from its queue. Affected versions then destroy the socket without a terminal diagnostic event, which retains the span. Publish one fallback error event and rethrow the original error. Scope the hook-context assertion to native diagnostics versions so Node 26 does not format unrelated cyclic span graphs.
BridgeAR
added a commit
that referenced
this pull request
Sep 4, 2026
* fix(undici): prevent context retention after requests Native diagnostic callbacks entered request spans into the caller's async context. The context outlived finished requests, retained downstream resources, and made later work inherit the wrong span. Keep native diagnostics for normal request lifecycles and instrument only Undici's accepted-upgrade callback, which has no terminal diagnostic event. Activate the request span only while a configured request hook runs. The request-create hot path no longer copies the async store or switches context twice. In two fresh one-million-iteration runs it improved from 43.1-43.5 ns to 10.1-10.2 ns per operation. Refs: nodejs/undici#5761 * fix(undici): gate upgrade fallback by source Released Undici versions omit terminal diagnostics for accepted upgrades, but patched and backported implementations can share those versions. Inspecting the loaded Request method avoids wrapping implementations that already publish terminal trailers. * fix(undici): finish spans after upgrade handler errors Accepted upgrade handlers can throw after Undici removes the request from its queue. Affected versions then destroy the socket without a terminal diagnostic event, which retains the span. Publish one fallback error event and rethrow the original error. Scope the hook-context assertion to native diagnostics versions so Node 26 does not format unrelated cyclic span graphs.
BridgeAR
added a commit
that referenced
this pull request
Sep 4, 2026
* fix(undici): prevent context retention after requests Native diagnostic callbacks entered request spans into the caller's async context. The context outlived finished requests, retained downstream resources, and made later work inherit the wrong span. Keep native diagnostics for normal request lifecycles and instrument only Undici's accepted-upgrade callback, which has no terminal diagnostic event. Activate the request span only while a configured request hook runs. The request-create hot path no longer copies the async store or switches context twice. In two fresh one-million-iteration runs it improved from 43.1-43.5 ns to 10.1-10.2 ns per operation. Refs: nodejs/undici#5761 * fix(undici): gate upgrade fallback by source Released Undici versions omit terminal diagnostics for accepted upgrades, but patched and backported implementations can share those versions. Inspecting the loaded Request method avoids wrapping implementations that already publish terminal trailers. * fix(undici): finish spans after upgrade handler errors Accepted upgrade handlers can throw after Undici removes the request from its queue. Affected versions then destroy the socket without a terminal diagnostic event, which retains the span. Publish one fallback error event and rethrow the original error. Scope the hook-context assertion to native diagnostics versions so Node 26 does not format unrelated cyclic span graphs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Native Undici diagnostic callbacks entered request spans into the caller's async context. The context outlived finished requests, retained downstream resources, and made later work inherit the wrong span.
Keep native diagnostics for normal request lifecycles. For accepted upgrades, inspect the loaded Request method and install the fallback only when that method does not publish terminal diagnostics. Patched and backported Undici implementations remain untouched.
Activate the request span only while a configured request hook runs.
The request-create hot path no longer copies the async store or switches context twice. Two fresh one-million-iteration runs improved from 43.1-43.5 ns to 10.1-10.2 ns per operation.
The native Undici fix is tracked in nodejs/undici#5761.