Skip to content

Conversation

@pabloerhard
Copy link
Contributor

What does this PR do?

Fix cookie-parser breaking during ESM instrumentation and added ESM tests.

Motivation

Plugin Checklist

Additional Notes

@pabloerhard pabloerhard requested review from a team as code owners October 20, 2025 20:33
@github-actions
Copy link

github-actions bot commented Oct 20, 2025

Overall package size

Self size: 12.85 MB
Deduped: 115.56 MB
No deduping: 117.77 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.11.1 | 9.96 MB | 10.34 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.73 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.206.0 | 201.39 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.12 | 95.11 kB | 401.68 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.13%. Comparing base (191e908) to head (72c07c2).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6708   +/-   ##
=======================================
  Coverage   84.13%   84.13%           
=======================================
  Files         505      505           
  Lines       21038    21039    +1     
=======================================
+ Hits        17701    17702    +1     
  Misses       3337     3337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pabloerhard pabloerhard marked this pull request as draft October 20, 2025 20:38
@datadog-datadog-prod-us1

This comment has been minimized.

@pr-commenter
Copy link

pr-commenter bot commented Oct 20, 2025

Benchmarks

Benchmark execution time: 2025-10-21 14:41:32

Comparing candidate commit 72c07c2 in PR branch pabloerhard/cookie-parser-fix with baseline commit 191e908 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1606 metrics, 64 unstable metrics.

@pabloerhard pabloerhard marked this pull request as ready for review October 20, 2025 21:30
BridgeAR
BridgeAR previously approved these changes Oct 21, 2025
Copy link
Collaborator

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Adding a comment is likely a good idea to make sure the intent of the test is clear (or change the describe block accordingly)

@pabloerhard pabloerhard force-pushed the pabloerhard/cookie-parser-fix branch from a16bf98 to 72c07c2 Compare October 21, 2025 14:30
@BridgeAR BridgeAR enabled auto-merge (squash) October 21, 2025 14:57
@BridgeAR BridgeAR merged commit 9e3c182 into master Oct 21, 2025
759 of 760 checks passed
@BridgeAR BridgeAR deleted the pabloerhard/cookie-parser-fix branch October 21, 2025 15:17
dd-octo-sts bot pushed a commit that referenced this pull request Oct 21, 2025
* Fix to cookie-parser failing to instrument

* Added cookie-parser test and excluded it from plugin tests
@dd-octo-sts dd-octo-sts bot mentioned this pull request Oct 21, 2025
juan-fernandez pushed a commit that referenced this pull request Oct 22, 2025
* Fix to cookie-parser failing to instrument

* Added cookie-parser test and excluded it from plugin tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants