-
Notifications
You must be signed in to change notification settings - Fork 355
chore (ci): report test result to datadog #6649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 12.82 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.2.1 | 20.64 MB | 20.65 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.11.1 | 9.96 MB | 10.34 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.73 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.205.0 | 201.51 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.10 | 95.11 kB | 401.46 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6649 +/- ##
=======================================
Coverage 84.11% 84.12%
=======================================
Files 503 505 +2
Lines 21006 21027 +21
=======================================
+ Hits 17670 17689 +19
- Misses 3336 3338 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aa03584 to
0915d20
Compare
This comment has been minimized.
This comment has been minimized.
0915d20 to
df5e6d9
Compare
64a91e8 to
0b01ca7
Compare
0b01ca7 to
3df2ecc
Compare
0a5a842 to
f4a294d
Compare
f8a5057 to
7761623
Compare
7761623 to
784cf3e
Compare
rochdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would be nice to be able to make it so that codecov+junit can be defined in only one place as a reusable action, but unless there is a way to pass secrets more easily I guess there wouldn't be much to gain.
* Add junit job for mocha * mocha multi reporter * Licences * yarn dependencies:dedupe * Activate push to test optimization on system-tests * Introduce and deploy push-junit * Use good env var names * Add --service dd-trace-js-tests * fix lint * Use good secret * Remove push-junit * Use DataDog/junit-upload-github-action * push platform tests to test optim * Set api key for system-tests * mocha configuration * Deploy on all jobs * Fix typo * Lint * fix esbuild cwd * Removes a leftover in gitignore
* Add junit job for mocha * mocha multi reporter * Licences * yarn dependencies:dedupe * Activate push to test optimization on system-tests * Introduce and deploy push-junit * Use good env var names * Add --service dd-trace-js-tests * fix lint * Use good secret * Remove push-junit * Use DataDog/junit-upload-github-action * push platform tests to test optim * Set api key for system-tests * mocha configuration * Deploy on all jobs * Fix typo * Lint * fix esbuild cwd * Removes a leftover in gitignore
* Add junit job for mocha * mocha multi reporter * Licences * yarn dependencies:dedupe * Activate push to test optimization on system-tests * Introduce and deploy push-junit * Use good env var names * Add --service dd-trace-js-tests * fix lint * Use good secret * Remove push-junit * Use DataDog/junit-upload-github-action * push platform tests to test optim * Set api key for system-tests * mocha configuration * Deploy on all jobs * Fix typo * Lint * fix esbuild cwd * Removes a leftover in gitignore
What does this PR do?
Changes
.mocharc.ymlto.mocharc.jsspec+junitexport, with node version in filename (note, the config of mocha is not trivial, I failed to add all conf in.mocharc.jsand I had to add an extra conf file 😢 )Extra : adds
.tap/*in gitignore (not related to this PR, I can remove it if needed)Good to know : #1367
Not in this PR
v18in favor ofc8) and junit (introduced inv18). The used version is quite old, so it may be a good idea to update it. Though, using two different coverage tool is not an option, so this part must be addressed in a different PR. This current Pr will focus onmochaandsystem-tests. Side note, do we want this?mochaseems to be the target.test:eslint-rules-> only lint, will see later if neededMotivation
Additional Notes