Skip to content

Conversation

@rochdev
Copy link
Member

@rochdev rochdev commented May 19, 2025

What does this PR do?

Add support for passing tags as arrays for custom metrics.

Motivation

Using an object doesn't allow multiple values for a tag. Since the underlying protocol and implementation both use arrays of strings, I think it makes sense that custom metrics support that as well.

Closes #5591

@github-actions
Copy link

github-actions bot commented May 19, 2025

Overall package size

Self size: 9.39 MB
Deduped: 103.41 MB
No deduping: 103.93 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (22d38aa) to head (08b0481).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5748      +/-   ##
==========================================
- Coverage   79.10%   79.05%   -0.06%     
==========================================
  Files         516      515       -1     
  Lines       23658    23591      -67     
==========================================
- Hits        18715    18649      -66     
+ Misses       4943     4942       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 19, 2025

Datadog Report

Branch report: custom-metrics-array-tags
Commit report: 80fc356
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 986 Passed, 0 Skipped, 14m 59.32s Total Time

@rochdev rochdev force-pushed the custom-metrics-array-tags branch from d59fe32 to 08b0481 Compare May 19, 2025 17:29
@pr-commenter
Copy link

pr-commenter bot commented May 19, 2025

Benchmarks

Benchmark execution time: 2025-05-19 17:41:49

Comparing candidate commit 08b0481 in PR branch custom-metrics-array-tags with baseline commit 22d38aa in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1170 metrics, 43 unstable metrics.

@rochdev rochdev marked this pull request as ready for review May 20, 2025 08:56
@rochdev rochdev requested a review from a team as a code owner May 20, 2025 08:56
@BridgeAR BridgeAR merged commit 9fd6173 into master May 20, 2025
487 checks passed
@BridgeAR BridgeAR deleted the custom-metrics-array-tags branch May 20, 2025 09:25
@ghost ghost mentioned this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants