Skip to content

Conversation

@watson
Copy link
Collaborator

@watson watson commented May 14, 2025

What does this PR do?

If for whatever reason the probe state snapshot cannot be captured or included in the payload, an error message should be included instead. The backend doesn’t support a root notCapturedReason, so instead a new debugger.snapshot.captureError should be introduced to hold a string error message.

Depends on the UI supporting and displaying this new property, which as of this writing, it doesn't. I'll mark this PR as ready for review once it does.

Motivation

The backend doesn't actually support a root notCapturedReason. When we include it, it doesn't render as one could expect and the actual error message is not even visible.

Plugin Checklist

Additional Notes

@watson watson self-assigned this May 14, 2025
Copy link
Collaborator Author

watson commented May 14, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels May 14, 2025
@github-actions
Copy link

github-actions bot commented May 14, 2025

Overall package size

Self size: 9.37 MB
Deduped: 103.39 MB
No deduping: 103.91 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 14, 2025

Datadog Report

Branch report: watson/DEBUG-3876/add-capture-error-prop
Commit report: 5863af0
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 512 Passed, 0 Skipped, 18m 24.93s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • cypress@6.7.0 commonJS logs a warning if using a deprecated version of cypress - integration-tests/cypress/cypress.spec.js - Last Failure

    Expand for error
     Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/integration-tests/cypress/cypress.spec.js)
    

@pr-commenter
Copy link

pr-commenter bot commented May 14, 2025

Benchmarks

Benchmark execution time: 2025-05-14 16:33:42

Comparing candidate commit 9dbaedc in PR branch watson/DEBUG-3876/add-capture-error-prop with baseline commit d6382c1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1270 metrics, 53 unstable metrics.

@watson watson force-pushed the watson/DEBUG-3876/add-capture-error-prop branch from f95e0c3 to 85bbe04 Compare May 14, 2025 10:02
shatzi
shatzi previously approved these changes May 14, 2025
@watson watson marked this pull request as ready for review May 14, 2025 16:15
@watson watson requested review from a team as code owners May 14, 2025 16:15
@watson watson force-pushed the watson/DEBUG-3876/add-capture-error-prop branch from 85bbe04 to bbaebcc Compare May 14, 2025 16:23
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.01%. Comparing base (d6382c1) to head (9dbaedc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5731      +/-   ##
==========================================
- Coverage   79.08%   79.01%   -0.07%     
==========================================
  Files         515      514       -1     
  Lines       23578    23506      -72     
==========================================
- Hits        18646    18574      -72     
  Misses       4932     4932              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

If for whatever reason the probe state snapshot cannot be captured or
included in the payload, an error message should be included instead.
The backend doesn’t support a root `notCapturedReason`, so instead a new
`debugger.snapshot.captureError` should be introduced to hold a string
error message.
@watson watson force-pushed the watson/DEBUG-3876/add-capture-error-prop branch from bbaebcc to 9dbaedc Compare May 14, 2025 16:25
@watson watson enabled auto-merge (squash) May 14, 2025 16:29
@watson watson merged commit 34f2e55 into master May 14, 2025
537 of 660 checks passed
@watson watson deleted the watson/DEBUG-3876/add-capture-error-prop branch May 14, 2025 17:32
ghost pushed a commit that referenced this pull request May 15, 2025
…5731)

If for whatever reason the probe state snapshot cannot be captured or
included in the payload, an error message should be included instead.
The backend doesn’t support a root `notCapturedReason`, so instead a new
`debugger.snapshot.captureError` should be introduced to hold a string
error message.
@ghost ghost mentioned this pull request May 15, 2025
ghost pushed a commit that referenced this pull request May 16, 2025
…5731)

If for whatever reason the probe state snapshot cannot be captured or
included in the payload, an error message should be included instead.
The backend doesn’t support a root `notCapturedReason`, so instead a new
`debugger.snapshot.captureError` should be introduced to hold a string
error message.
@ghost ghost mentioned this pull request May 16, 2025
ghost pushed a commit that referenced this pull request May 17, 2025
…5731)

If for whatever reason the probe state snapshot cannot be captured or
included in the payload, an error message should be included instead.
The backend doesn’t support a root `notCapturedReason`, so instead a new
`debugger.snapshot.captureError` should be introduced to hold a string
error message.
This was referenced May 17, 2025
BridgeAR pushed a commit that referenced this pull request May 23, 2025
…5731)

If for whatever reason the probe state snapshot cannot be captured or
included in the payload, an error message should be included instead.
The backend doesn’t support a root `notCapturedReason`, so instead a new
`debugger.snapshot.captureError` should be introduced to hold a string
error message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants