Skip to content

Conversation

@watson
Copy link
Collaborator

@watson watson commented May 13, 2025

What does this PR do?

This fixes a bug where if two probes were attached to the same line and both had a condition, if only one of the conditions match, we would wrongly assume both had matched and send both probe results to the backend.

This changes that behavior to always re-evaluate the conditions no matter what.

This fixes a bug where if two probes were attached to the same line and
both had a condition, if only one of the conditions match, we would
wrongly assume both had matched and send both probe results to the
backend.

This changes that behavior to always re-evaluate the conditions no
matter what.
@watson watson requested review from a team as code owners May 13, 2025 11:39
Copy link
Collaborator Author

watson commented May 13, 2025

@watson watson self-assigned this May 13, 2025
@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels May 13, 2025
@github-actions
Copy link

Overall package size

Self size: 9.36 MB
Deduped: 103.39 MB
No deduping: 103.91 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (af5717e) to head (e48a997).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5714   +/-   ##
=======================================
  Coverage   78.99%   78.99%           
=======================================
  Files         513      513           
  Lines       23476    23476           
=======================================
  Hits        18545    18545           
  Misses       4931     4931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Benchmark execution time: 2025-05-13 11:47:20

Comparing candidate commit e48a997 in PR branch watson/DEBUG-3862/fix-logic-bug with baseline commit af5717e in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1272 metrics, 51 unstable metrics.

@watson watson added the bug Something isn't working label May 13, 2025
@watson watson changed the title [DI] Only send trigger on probes whos condition is actually met [DI] Only send probes whos condition is actually met May 14, 2025
@watson watson merged commit d6382c1 into master May 14, 2025
488 of 489 checks passed
@watson watson deleted the watson/DEBUG-3862/fix-logic-bug branch May 14, 2025 16:12
ghost pushed a commit that referenced this pull request May 15, 2025
This fixes a bug where if two probes were attached to the same line and
both had a condition, if only one of the conditions match, we would
wrongly assume both had matched and send both probe results to the
backend.

This changes that behavior to always re-evaluate the conditions no
matter what.
@ghost ghost mentioned this pull request May 15, 2025
ghost pushed a commit that referenced this pull request May 16, 2025
This fixes a bug where if two probes were attached to the same line and
both had a condition, if only one of the conditions match, we would
wrongly assume both had matched and send both probe results to the
backend.

This changes that behavior to always re-evaluate the conditions no
matter what.
@ghost ghost mentioned this pull request May 16, 2025
ghost pushed a commit that referenced this pull request May 17, 2025
This fixes a bug where if two probes were attached to the same line and
both had a condition, if only one of the conditions match, we would
wrongly assume both had matched and send both probe results to the
backend.

This changes that behavior to always re-evaluate the conditions no
matter what.
This was referenced May 17, 2025
BridgeAR pushed a commit that referenced this pull request May 23, 2025
This fixes a bug where if two probes were attached to the same line and
both had a condition, if only one of the conditions match, we would
wrongly assume both had matched and send both probe results to the
backend.

This changes that behavior to always re-evaluate the conditions no
matter what.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants