-
Notifications
You must be signed in to change notification settings - Fork 358
[DI] Only send probes whos condition is actually met #5714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This fixes a bug where if two probes were attached to the same line and both had a condition, if only one of the conditions match, we would wrongly assume both had matched and send both probe results to the backend. This changes that behavior to always re-evaluate the conditions no matter what.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Overall package sizeSelf size: 9.36 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5714 +/- ##
=======================================
Coverage 78.99% 78.99%
=======================================
Files 513 513
Lines 23476 23476
=======================================
Hits 18545 18545
Misses 4931 4931 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-05-13 11:47:20 Comparing candidate commit e48a997 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1272 metrics, 51 unstable metrics. |
This fixes a bug where if two probes were attached to the same line and both had a condition, if only one of the conditions match, we would wrongly assume both had matched and send both probe results to the backend. This changes that behavior to always re-evaluate the conditions no matter what.
This fixes a bug where if two probes were attached to the same line and both had a condition, if only one of the conditions match, we would wrongly assume both had matched and send both probe results to the backend. This changes that behavior to always re-evaluate the conditions no matter what.
This fixes a bug where if two probes were attached to the same line and both had a condition, if only one of the conditions match, we would wrongly assume both had matched and send both probe results to the backend. This changes that behavior to always re-evaluate the conditions no matter what.
This fixes a bug where if two probes were attached to the same line and both had a condition, if only one of the conditions match, we would wrongly assume both had matched and send both probe results to the backend. This changes that behavior to always re-evaluate the conditions no matter what.

What does this PR do?
This fixes a bug where if two probes were attached to the same line and both had a condition, if only one of the conditions match, we would wrongly assume both had matched and send both probe results to the backend.
This changes that behavior to always re-evaluate the conditions no matter what.