Skip to content

Conversation

@Mariovido
Copy link
Contributor

@Mariovido Mariovido commented May 13, 2025

What does this PR do?

Replace AsyncResource usage for runStores in the following frameworks:

  • Jest
  • Mocha
  • Cucumber
  • Vitest
  • Playwright

Motivation

There is a bug in Node 24 when using AsyncResource that isn't triggered when using runStores instead.

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented May 13, 2025

Overall package size

Self size: 9.37 MB
Deduped: 103.39 MB
No deduping: 103.91 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented May 13, 2025

Benchmarks

Benchmark execution time: 2025-05-14 09:35:19

Comparing candidate commit 1d51d33 in PR branch mario.vidal/support_node_24_test_optimization with baseline commit 57da289 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1264 metrics, 59 unstable metrics.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 13, 2025

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Test Optimization Report

Branch report: mario.vidal/support_node_24_test_optimization
Commit report: 3337fba
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 935 Passed, 0 Skipped, 15m 41.05s Total Time


Was this helpful? Give us feedback!

@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 158 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (d6df5c1) to head (00208f5).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
...ckages/datadog-instrumentations/src/mocha/utils.js 0.00% 47 Missing ⚠️
packages/datadog-plugin-mocha/src/index.js 0.00% 39 Missing ⚠️
...ackages/datadog-instrumentations/src/mocha/main.js 0.00% 27 Missing ⚠️
packages/datadog-instrumentations/src/cucumber.js 0.00% 24 Missing ⚠️
packages/datadog-plugin-cucumber/src/index.js 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5711      +/-   ##
==========================================
- Coverage   79.02%   78.98%   -0.05%     
==========================================
  Files         512      514       +2     
  Lines       23455    23517      +62     
==========================================
+ Hits        18536    18574      +38     
- Misses       4919     4943      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mariovido Mariovido force-pushed the mario.vidal/support_node_24_test_optimization branch from 14dc288 to ad71a9b Compare May 13, 2025 11:26
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 14, 2025

Datadog Report

Branch report: mario.vidal/support_node_24_test_optimization
Commit report: a193b5c
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 983 Passed, 0 Skipped, 18m 20.59s Total Time

@Mariovido Mariovido marked this pull request as ready for review May 14, 2025 09:46
@Mariovido Mariovido requested review from a team as code owners May 14, 2025 09:46
@bengl bengl merged commit 63db106 into master May 14, 2025
487 checks passed
@bengl bengl deleted the mario.vidal/support_node_24_test_optimization branch May 14, 2025 17:54
ghost pushed a commit that referenced this pull request May 15, 2025
…nstrumentations with Node 24 (#5711)

* Add node24

* Make it work for Jest but custom tags

* Fix Jest

* Fix Mocha

* Update subscription channel Mocha

* Fix propagation error in Mocha

* Fix active span in Mocha

* Fix Cucumber

* Partial fix Vitest

* Add OPTION_OVERRIDE

* Update CLI Vitest

* Fix Playwright
@ghost ghost mentioned this pull request May 15, 2025
ghost pushed a commit that referenced this pull request May 16, 2025
…nstrumentations with Node 24 (#5711)

* Add node24

* Make it work for Jest but custom tags

* Fix Jest

* Fix Mocha

* Update subscription channel Mocha

* Fix propagation error in Mocha

* Fix active span in Mocha

* Fix Cucumber

* Partial fix Vitest

* Add OPTION_OVERRIDE

* Update CLI Vitest

* Fix Playwright
@ghost ghost mentioned this pull request May 16, 2025
ghost pushed a commit that referenced this pull request May 17, 2025
…nstrumentations with Node 24 (#5711)

* Add node24

* Make it work for Jest but custom tags

* Fix Jest

* Fix Mocha

* Update subscription channel Mocha

* Fix propagation error in Mocha

* Fix active span in Mocha

* Fix Cucumber

* Partial fix Vitest

* Add OPTION_OVERRIDE

* Update CLI Vitest

* Fix Playwright
This was referenced May 17, 2025
BridgeAR pushed a commit that referenced this pull request May 23, 2025
…nstrumentations with Node 24 (#5711)

* Add node24

* Make it work for Jest but custom tags

* Fix Jest

* Fix Mocha

* Update subscription channel Mocha

* Fix propagation error in Mocha

* Fix active span in Mocha

* Fix Cucumber

* Partial fix Vitest

* Add OPTION_OVERRIDE

* Update CLI Vitest

* Fix Playwright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants