-
Notifications
You must be signed in to change notification settings - Fork 358
[test-optimization] [SDTEST-1990] Make compatible Test Optimization instrumentations with Node 24 #5711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 9.37 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2025-05-14 09:35:19 Comparing candidate commit 1d51d33 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1264 metrics, 59 unstable metrics. |
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Test Optimization ReportBranch report: ✅ 0 Failed, 935 Passed, 0 Skipped, 15m 41.05s Total Time Was this helpful? Give us feedback! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5711 +/- ##
==========================================
- Coverage 79.02% 78.98% -0.05%
==========================================
Files 512 514 +2
Lines 23455 23517 +62
==========================================
+ Hits 18536 18574 +38
- Misses 4919 4943 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
14dc288 to
ad71a9b
Compare
Datadog ReportBranch report: ✅ 0 Failed, 983 Passed, 0 Skipped, 18m 20.59s Total Time |
…nstrumentations with Node 24 (#5711) * Add node24 * Make it work for Jest but custom tags * Fix Jest * Fix Mocha * Update subscription channel Mocha * Fix propagation error in Mocha * Fix active span in Mocha * Fix Cucumber * Partial fix Vitest * Add OPTION_OVERRIDE * Update CLI Vitest * Fix Playwright
…nstrumentations with Node 24 (#5711) * Add node24 * Make it work for Jest but custom tags * Fix Jest * Fix Mocha * Update subscription channel Mocha * Fix propagation error in Mocha * Fix active span in Mocha * Fix Cucumber * Partial fix Vitest * Add OPTION_OVERRIDE * Update CLI Vitest * Fix Playwright
…nstrumentations with Node 24 (#5711) * Add node24 * Make it work for Jest but custom tags * Fix Jest * Fix Mocha * Update subscription channel Mocha * Fix propagation error in Mocha * Fix active span in Mocha * Fix Cucumber * Partial fix Vitest * Add OPTION_OVERRIDE * Update CLI Vitest * Fix Playwright
…nstrumentations with Node 24 (#5711) * Add node24 * Make it work for Jest but custom tags * Fix Jest * Fix Mocha * Update subscription channel Mocha * Fix propagation error in Mocha * Fix active span in Mocha * Fix Cucumber * Partial fix Vitest * Add OPTION_OVERRIDE * Update CLI Vitest * Fix Playwright
What does this PR do?
Replace
AsyncResourceusage forrunStoresin the following frameworks:Motivation
There is a bug in Node 24 when using
AsyncResourcethat isn't triggered when usingrunStoresinstead.Plugin Checklist
Additional Notes