Skip to content

[test-optimization] [SDTEST-1990] Make compatible Test Optimization instrumentations with Node 24 #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Mariovido
Copy link
Contributor

@Mariovido Mariovido commented May 9, 2025

What does this PR do?

Replace AsyncResource usage for runStores in the following frameworks:

  • Jest
  • Mocha
  • Cucumber (WIP)
  • Playwright (WIP)
  • Vitest (WIP)

Motivation

There is a bug in Node 24 when using AsyncResource that isn't triggered when using runStores instead.

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented May 9, 2025

Overall package size

Self size: 9.36 MB
Deduped: 103.38 MB
No deduping: 103.9 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 158 lines in your changes missing coverage. Please review.

Project coverage is 77.30%. Comparing base (d6df5c1) to head (f4716e8).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
...ckages/datadog-instrumentations/src/mocha/utils.js 0.00% 47 Missing ⚠️
packages/datadog-plugin-mocha/src/index.js 0.00% 39 Missing ⚠️
...ackages/datadog-instrumentations/src/mocha/main.js 0.00% 27 Missing ⚠️
packages/datadog-instrumentations/src/cucumber.js 0.00% 24 Missing ⚠️
packages/datadog-plugin-cucumber/src/index.js 0.00% 21 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5692      +/-   ##
==========================================
- Coverage   79.02%   77.30%   -1.73%     
==========================================
  Files         512      484      -28     
  Lines       23455    22141    -1314     
==========================================
- Hits        18536    17115    -1421     
- Misses       4919     5026     +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

Datadog Report

Branch report: mario.vidal/support_node_24_test_optimization
Commit report: e4c348a
Test service: dd-trace-js-integration-tests

❌ 1 Failed (0 Known Flaky), 481 Passed, 0 Skipped, 3m 17.24s Total Time

❌ Failed Tests (1)

  • selenium 4.11.0 with jest identifies tests using selenium as browser tests - integration-tests/selenium/selenium.spec.js - Details

    Expand for error
     expected { '_dd.p.dm': '-4', …(39) } to have property 'test.browser.driver'
    

@pr-commenter
Copy link

pr-commenter bot commented May 9, 2025

Benchmarks

Benchmark execution time: 2025-05-13 09:01:52

Comparing candidate commit 90e2023 in PR branch mario.vidal/support_node_24_test_optimization with baseline commit d6df5c1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1268 metrics, 55 unstable metrics.

@Mariovido Mariovido changed the title [test-optimization] [SDTEST-1990] Make compatible Test Optimization instrumentations [test-optimization] [SDTEST-1990] Make compatible Test Optimization instrumentations with Node 24 May 12, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 12, 2025

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Test Optimization Report

Branch report: mario.vidal/support_node_24_test_optimization
Commit report: 90e2023
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 930 Passed, 0 Skipped, 13m 24.87s Total Time


Was this helpful? Give us feedback!

@Mariovido Mariovido force-pushed the mario.vidal/support_node_24_test_optimization branch from f4716e8 to 90e2023 Compare May 13, 2025 09:07
@Mariovido Mariovido closed this May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant