Skip to content

[Debugger] Remove inspector/promises polyfill #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: BridgeAR/remove-outdated-node-version-checks
Choose a base branch
from

Conversation

watson
Copy link
Collaborator

@watson watson commented May 8, 2025

What does this PR do?

Removes a polyfill used to support Node.js versions below version 19.0.0.

Motivation

For the upcoming release of dd-trace version 6, these Node.js versions are no longer supported and the polyfill can be removed.

Plugin Checklist

Additional Notes

Copy link
Collaborator Author

watson commented May 8, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented May 8, 2025

Overall package size

Self size: 9.26 MB
Deduped: 102.51 MB
No deduping: 103.03 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.1 | 29.73 MB | 29.73 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 3.3.1 | 13.99 MB | 13.99 MB | | @datadog/pprof | 5.7.1 | 9.51 MB | 9.88 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.8 | 25.08 kB | 25.08 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@watson watson self-assigned this May 8, 2025
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.99%. Comparing base (e56d49f) to head (a809413).

Additional details and impacted files
@@                               Coverage Diff                                @@
##           BridgeAR/remove-outdated-node-version-checks    #5685      +/-   ##
================================================================================
- Coverage                                         79.12%   78.99%   -0.13%     
================================================================================
  Files                                               512      503       -9     
  Lines                                             23392    23234     -158     
================================================================================
- Hits                                              18509    18354     -155     
+ Misses                                             4883     4880       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented May 8, 2025

Datadog Report

Branch report: watson/drop-nodejs-18
Commit report: 8c10ab1
Test service: dd-trace-js-integration-tests

❌ 2 Failed (0 Known Flaky), 884 Passed, 0 Skipped, 14m 30.44s Total Time

❌ Failed Tests (2)

  • jest CommonJS when jest is using workers to run tests in parallel can work with Failed Test Replay - integration-tests/jest/jest.spec.js - Details

    Expand for error
     expected { '_dd.p.dm': '-4', …(50) } to have property 'error.debug_info_captured'
    
  • mocha CommonJS dynamic instrumentation runs retries with dynamic instrumentation - integration-tests/mocha/mocha.spec.js - Details

    Expand for error
     Cannot read properties of undefined (reading 'logMessage')
    

@pr-commenter
Copy link

pr-commenter bot commented May 8, 2025

Benchmarks

Benchmark execution time: 2025-05-08 07:54:01

Comparing candidate commit a809413 in PR branch watson/drop-nodejs-18 with baseline commit e56d49f in branch BridgeAR/remove-outdated-node-version-checks.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1252 metrics, 51 unstable metrics.

@watson watson changed the base branch from master to BridgeAR/remove-outdated-node-version-checks May 8, 2025 07:41
This was required for Node.js version below 19.0.0. For the upcoming
release of dd-trace version 6, these Node.js versions are no longer
supported and the polyfill can be removed.
@watson watson force-pushed the watson/drop-nodejs-18 branch from 7281ece to a809413 Compare May 8, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants