-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify span metrics from OpenTelemetry libraries with 'otel.library' tag #4724
Identify span metrics from OpenTelemetry libraries with 'otel.library' tag #4724
Conversation
Overall package sizeSelf size: 7.55 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.1.1 | 18.67 MB | 18.68 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.59 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
d913f12
to
2143f16
Compare
BenchmarksBenchmark execution time: 2024-10-21 09:26:59 Comparing candidate commit eb4eedc in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics. |
2143f16
to
d05b92d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4724 +/- ##
==========================================
+ Coverage 91.42% 94.61% +3.19%
==========================================
Files 112 117 +5
Lines 3475 3752 +277
Branches 33 33
==========================================
+ Hits 3177 3550 +373
+ Misses 298 202 -96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d05b92d
to
85904bb
Compare
85904bb
to
d458242
Compare
d458242
to
661c397
Compare
…' tag. Use existing 'otel' tag for other sources of spans, such as manual tracing.
661c397
to
eb4eedc
Compare
…' tag (#4724) Use existing 'otel' tag for other sources of spans, such as manual tracing
…' tag (#4724) Use existing 'otel' tag for other sources of spans, such as manual tracing
…' tag (#4724) Use existing 'otel' tag for other sources of spans, such as manual tracing
…' tag (#4724) Use existing 'otel' tag for other sources of spans, such as manual tracing
…' tag (#4724) Use existing 'otel' tag for other sources of spans, such as manual tracing
What does this PR do?
Identify span metrics from OpenTelemetry libraries with 'otel.library' tag. Use existing 'otel' tag for other sources of spans, such as manual tracing.
Motivation
We'd like to track span metrics from OpenTelemetry auto-instrumentations separately to those from manual instrumentation. This PR uses the integration details from the OTel tracer to decide whether to use the new 'otel.library' tag or the existing 'otel' tag.
Jira ticket: APMAPI-154