Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Check rewriter regression with wasm-pack@0.13.0 #4531

Closed
wants to merge 9 commits into from

Conversation

iunanua
Copy link
Contributor

@iunanua iunanua commented Jul 18, 2024

What does this PR do?

Do not merge

Motivation

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Jul 18, 2024

Overall package size

Self size: 6.84 MB
Deduped: 59.15 MB
No deduping: 59.43 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.0.0 | 11.14 MB | 11.15 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.4.0-pre-002 | 2.5 MB | 2.59 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jul 19, 2024

Benchmarks

Benchmark execution time: 2024-07-22 13:42:09

Comparing candidate commit 9fe00ce in PR branch igor/test-wasm-pack@0.13.0 with baseline commit a34a685 in branch master.

Found 0 performance improvements and 15 performance regressions! Performance is the same for 245 metrics, 6 unstable metrics.

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18

  • 🟥 cpu_user_time [+486.865ms; +525.052ms] or [+40.986%; +44.201%]
  • 🟥 execution_time [+473.140ms; +553.325ms] or [+34.381%; +40.208%]
  • 🟥 max_rss_usage [+43.668MB; +47.238MB] or [+37.119%; +40.154%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

  • 🟥 cpu_user_time [+486.843ms; +514.724ms] or [+42.317%; +44.740%]
  • 🟥 execution_time [+482.694ms; +553.682ms] or [+36.261%; +41.593%]
  • 🟥 max_rss_usage [+43.969MB; +47.100MB] or [+37.595%; +40.273%]

scenario:appsec-iast-startup-time-iast-enabled-18

  • 🟥 cpu_user_time [+506.305ms; +541.030ms] or [+33.091%; +35.361%]
  • 🟥 execution_time [+527.693ms; +557.889ms] or [+31.285%; +33.076%]
  • 🟥 max_rss_usage [+34.296MB; +38.142MB] or [+26.763%; +29.764%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18

  • 🟥 cpu_user_time [+405.410ms; +474.731ms] or [+23.604%; +27.640%]
  • 🟥 execution_time [+533.321ms; +697.090ms] or [+22.074%; +28.852%]
  • 🟥 max_rss_usage [+39.310MB; +42.429MB] or [+31.975%; +34.512%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18

  • 🟥 cpu_user_time [+423.097ms; +475.434ms] or [+26.560%; +29.846%]
  • 🟥 execution_time [+512.051ms; +671.349ms] or [+23.127%; +30.321%]
  • 🟥 max_rss_usage [+39.414MB; +49.450MB] or [+32.478%; +40.748%]

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (a34a685) to head (fd42228).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4531      +/-   ##
==========================================
- Coverage   95.85%   89.01%   -6.85%     
==========================================
  Files         105      255     +150     
  Lines        3451    11098    +7647     
  Branches       33       33              
==========================================
+ Hits         3308     9879    +6571     
- Misses        143     1219    +1076     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iunanua iunanua closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant