-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide non-config properties on config object #4521
Conversation
Overall package sizeSelf size: 6.85 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.0.0 | 11.14 MB | 11.15 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.3.1 | 2.15 MB | 2.24 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-07-23 12:13:06 Comparing candidate commit 401da13 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics. |
c05490c
to
35c4813
Compare
Library Vulnerabilities✅ No library vulnerabilities found (scanned dfc947f). |
35c4813
to
dfc947f
Compare
c1adefe
to
8592587
Compare
fa300e8
to
0e69d6d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4521 +/- ##
===========================================
- Coverage 95.85% 17.65% -78.21%
===========================================
Files 105 6 -99
Lines 3451 776 -2675
Branches 33 33
===========================================
- Hits 3308 137 -3171
- Misses 143 639 +496 ☔ View full report in Codecov by Sentry. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0e69d6d
to
d2c0b2c
Compare
Hide internal-only properties so they are not exposed to the rest of the app. This makes reasoning about what's a config option and what's not easier.
d2c0b2c
to
401da13
Compare
Hide internal-only properties so they are not exposed to the rest of the app. This makes reasoning about what's a config option and what's not easier. A better approach would be to use private properties on the class, but it isn't currently possible since the ESLint config disallows using private properties. The main motivation about this change is to make it simpler to send the config options to another thread as all the internal state will no longer be copied, but only the actual config options themselves. It also means that if you ever have to `console.log(config)`, the output will be _just_ the config options, which again is much cleaner.
Hide internal-only properties so they are not exposed to the rest of the app. This makes reasoning about what's a config option and what's not easier. A better approach would be to use private properties on the class, but it isn't currently possible since the ESLint config disallows using private properties. The main motivation about this change is to make it simpler to send the config options to another thread as all the internal state will no longer be copied, but only the actual config options themselves. It also means that if you ever have to `console.log(config)`, the output will be _just_ the config options, which again is much cleaner.
Hide internal-only properties so they are not exposed to the rest of the app. This makes reasoning about what's a config option and what's not easier. A better approach would be to use private properties on the class, but it isn't currently possible since the ESLint config disallows using private properties. The main motivation about this change is to make it simpler to send the config options to another thread as all the internal state will no longer be copied, but only the actual config options themselves. It also means that if you ever have to `console.log(config)`, the output will be _just_ the config options, which again is much cleaner.
Hide internal-only properties so they are not exposed to the rest of the app. This makes reasoning about what's a config option and what's not easier. A better approach would be to use private properties on the class, but it isn't currently possible since the ESLint config disallows using private properties. The main motivation about this change is to make it simpler to send the config options to another thread as all the internal state will no longer be copied, but only the actual config options themselves. It also means that if you ever have to `console.log(config)`, the output will be _just_ the config options, which again is much cleaner.
Hide internal-only properties so they are not exposed to the rest of the app. This makes reasoning about what's a config option and what's not easier. A better approach would be to use private properties on the class, but it isn't currently possible since the ESLint config disallows using private properties. The main motivation about this change is to make it simpler to send the config options to another thread as all the internal state will no longer be copied, but only the actual config options themselves. It also means that if you ever have to `console.log(config)`, the output will be _just_ the config options, which again is much cleaner.
Hide internal-only properties so they are not exposed to the rest of the app. This makes reasoning about what's a config option and what's not easier. A better approach would be to use private properties on the class, but it isn't currently possible since the ESLint config disallows using private properties. The main motivation about this change is to make it simpler to send the config options to another thread as all the internal state will no longer be copied, but only the actual config options themselves. It also means that if you ever have to `console.log(config)`, the output will be _just_ the config options, which again is much cleaner.
Hide internal-only properties so they are not exposed to the rest of the app. This makes reasoning about what's a config option and what's not easier.
A better approach would be to use private properties on the class, but it has not been possible for me to do so since our ESLint config disallows using private properties.
The main motivation about this change is to make it simpler to send the config options to another thread as all the internal state will no longer be copied, but only the actual config options themselves. It also means that if you ever have to
console.log(config)
, the output will be just the config options, which again is much cleaner.Expand to see the config object prior to hiding the internal-only properties
Expand to see the config object after hiding the internal-only properties