use name and version as key for package package-guardrails #4502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this was only using the name and had the version as a property. This was incorrectly calling instrumentations failed when they succeeded, since later hooks would fail as out of range and they'd be set that way.
Overall package sizeSelf size: 6.85 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.0.0 | 11.14 MB | 11.15 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.3.1 | 2.15 MB | 2.24 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Qard
previously approved these changes
Jul 10, 2024
Qard
approved these changes
Jul 11, 2024
wconti27
pushed a commit
that referenced
this pull request
Jul 30, 2024
* use name and version as key for package package-guardrails Previously this was only using the name and had the version as a property. This was incorrectly calling instrumentations failed when they succeeded, since later hooks would fail as out of range and they'd be set that way. * lint
wconti27
pushed a commit
that referenced
this pull request
Jul 31, 2024
* use name and version as key for package package-guardrails Previously this was only using the name and had the version as a property. This was incorrectly calling instrumentations failed when they succeeded, since later hooks would fail as out of range and they'd be set that way. * lint
wconti27
pushed a commit
that referenced
this pull request
Jul 31, 2024
* use name and version as key for package package-guardrails Previously this was only using the name and had the version as a property. This was incorrectly calling instrumentations failed when they succeeded, since later hooks would fail as out of range and they'd be set that way. * lint
wconti27
pushed a commit
that referenced
this pull request
Jul 31, 2024
* use name and version as key for package package-guardrails Previously this was only using the name and had the version as a property. This was incorrectly calling instrumentations failed when they succeeded, since later hooks would fail as out of range and they'd be set that way. * lint
juan-fernandez
pushed a commit
that referenced
this pull request
Aug 5, 2024
* use name and version as key for package package-guardrails Previously this was only using the name and had the version as a property. This was incorrectly calling instrumentations failed when they succeeded, since later hooks would fail as out of range and they'd be set that way. * lint
juan-fernandez
pushed a commit
that referenced
this pull request
Aug 5, 2024
* use name and version as key for package package-guardrails Previously this was only using the name and had the version as a property. This was incorrectly calling instrumentations failed when they succeeded, since later hooks would fail as out of range and they'd be set that way. * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this was only using the name and had the version as a property. This was incorrectly calling instrumentations failed when they succeeded, since later hooks would fail as out of range and they'd be set that way.