Only call activeSpan.finish() if there's an activeSpan #3617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
approved these changes
Sep 8, 2023
Codecov Report
@@ Coverage Diff @@
## master #3617 +/- ##
=======================================
Coverage 84.53% 84.53%
=======================================
Files 217 217
Lines 8773 8773
Branches 33 33
=======================================
Hits 7416 7416
Misses 1357 1357
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
khanayan123
pushed a commit
that referenced
this pull request
Sep 8, 2023
Co-authored-by: GitHub Actions <github-actions@momentum.io>
khanayan123
pushed a commit
that referenced
this pull request
Sep 8, 2023
Co-authored-by: GitHub Actions <github-actions@momentum.io>
khanayan123
pushed a commit
that referenced
this pull request
Sep 8, 2023
Co-authored-by: GitHub Actions <github-actions@momentum.io>
khanayan123
pushed a commit
that referenced
this pull request
Sep 8, 2023
Co-authored-by: GitHub Actions <github-actions@momentum.io>
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses #3527 which is causing process crashing.
Motivation
The issue needs to be resolved as it's affected our systems resilience.
Plugin Checklist
Additional Notes