Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[profiling] Adapt to new pprof-nodejs API #3368

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

nsavoire
Copy link
Collaborator

@nsavoire nsavoire commented Jul 7, 2023

What does this PR do?

Bump pprof-nodejs version to 3.0.0 and adapt to changes in the API.

Motivation

Prepare for new version of code hotspots (ability to link profile samples with traces).

This also remove cpu-experimental profiler which is currently broken and will be replaced by wall profiler + code hotspots.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Overall package size

Self size: 4.8 MB
Deduped: 57.79 MB
No deduping: 57.88 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.5.0 14.86 MB 14.86 MB
@datadog/native-appsec 3.2.0 13.38 MB 13.39 MB
@datadog/pprof 3.0.0 10.54 MB 11.39 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.0.1 2.09 MB 2.1 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.3 93.39 kB 123.79 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.0.1 59.52 kB 59.52 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
ignore 5.2.0 48.87 kB 48.87 kB
import-in-the-middle 1.3.5 34.34 kB 38.81 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
retry 0.10.1 27.44 kB 27.44 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
node-abort-controller 3.0.1 14.33 kB 14.33 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
diagnostics_channel 1.1.0 7.07 kB 7.07 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #3368 (3d84f4c) into master (8e26824) will decrease coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3368      +/-   ##
==========================================
- Coverage   84.21%   84.11%   -0.10%     
==========================================
  Files         205      204       -1     
  Lines        8071     8015      -56     
  Branches       33       33              
==========================================
- Hits         6797     6742      -55     
+ Misses       1274     1273       -1     
Impacted Files Coverage Δ
packages/dd-trace/src/profiling/config.js 96.33% <ø> (-0.07%) ⬇️
packages/dd-trace/src/profiling/index.js 100.00% <ø> (ø)
packages/dd-trace/src/profiling/profilers/wall.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

r1viollet
r1viollet previously approved these changes Jul 7, 2023
Copy link

@r1viollet r1viollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
This will fix compatibility with main branch 👍

@nsavoire nsavoire requested a review from szegedi July 10, 2023 08:19
@nsavoire nsavoire force-pushed the nsavoire/new_major_profiler_version branch 2 times, most recently from 9d0618d to be1cd1d Compare July 10, 2023 08:53
@pr-commenter
Copy link

pr-commenter bot commented Jul 10, 2023

Benchmarks

Benchmark execution time: 2023-07-10 13:01:11

Comparing candidate commit 3d84f4c in PR branch nsavoire/new_major_profiler_version with baseline commit 8e26824 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 461 metrics, 31 unstable metrics.

@nsavoire nsavoire force-pushed the nsavoire/new_major_profiler_version branch from be1cd1d to 3d84f4c Compare July 10, 2023 12:53
Copy link
Contributor

@szegedi szegedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@nsavoire nsavoire merged commit d00a4e0 into master Jul 10, 2023
Qard pushed a commit that referenced this pull request Jul 11, 2023
* Remove cpu-experimental profiler
* Adapt to API changes in pprof-nodejs
Qard pushed a commit that referenced this pull request Jul 11, 2023
* Remove cpu-experimental profiler
* Adapt to API changes in pprof-nodejs
Qard pushed a commit that referenced this pull request Jul 11, 2023
* Remove cpu-experimental profiler
* Adapt to API changes in pprof-nodejs
This was referenced Jul 11, 2023
Qard pushed a commit that referenced this pull request Jul 11, 2023
* Remove cpu-experimental profiler
* Adapt to API changes in pprof-nodejs
Qard pushed a commit that referenced this pull request Jul 11, 2023
* Remove cpu-experimental profiler
* Adapt to API changes in pprof-nodejs
Qard pushed a commit that referenced this pull request Jul 11, 2023
* Remove cpu-experimental profiler
* Adapt to API changes in pprof-nodejs
Qard pushed a commit that referenced this pull request Jul 14, 2023
* Remove cpu-experimental profiler
* Adapt to API changes in pprof-nodejs
Qard pushed a commit that referenced this pull request Jul 14, 2023
* Remove cpu-experimental profiler
* Adapt to API changes in pprof-nodejs
Qard pushed a commit that referenced this pull request Jul 14, 2023
* Remove cpu-experimental profiler
* Adapt to API changes in pprof-nodejs
@nsavoire nsavoire deleted the nsavoire/new_major_profiler_version branch July 17, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants