-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[profiling] Adapt to new pprof-nodejs API #3368
Conversation
Overall package sizeSelf size: 4.8 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report
@@ Coverage Diff @@
## master #3368 +/- ##
==========================================
- Coverage 84.21% 84.11% -0.10%
==========================================
Files 205 204 -1
Lines 8071 8015 -56
Branches 33 33
==========================================
- Hits 6797 6742 -55
+ Misses 1274 1273 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This will fix compatibility with main branch 👍
9d0618d
to
be1cd1d
Compare
BenchmarksBenchmark execution time: 2023-07-10 13:01:11 Comparing candidate commit 3d84f4c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 461 metrics, 31 unstable metrics. |
be1cd1d
to
3d84f4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
* Remove cpu-experimental profiler * Adapt to API changes in pprof-nodejs
What does this PR do?
Bump pprof-nodejs version to 3.0.0 and adapt to changes in the API.
Motivation
Prepare for new version of code hotspots (ability to link profile samples with traces).
This also remove
cpu-experimental
profiler which is currently broken and will be replaced by wall profiler + code hotspots.