add all dns addresses as a new tag when option is set #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
==========================================
+ Coverage 92.87% 92.88% +0.01%
==========================================
Files 203 203
Lines 8262 8266 +4
==========================================
+ Hits 7673 7678 +5
+ Misses 589 588 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
bengl
approved these changes
May 5, 2022
juan-fernandez
pushed a commit
that referenced
this pull request
May 5, 2022
juan-fernandez
pushed a commit
that referenced
this pull request
May 5, 2022
juan-fernandez
pushed a commit
that referenced
this pull request
May 5, 2022
Meemaw
reviewed
May 10, 2022
| span.setTag('dns.address', address) | ||
|
|
||
| if (Array.isArray(result)) { | ||
| const addresses = Array.isArray(result) |
There was a problem hiding this comment.
This Array.isArray(result) checks seems unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add all dns addresses as a new tag when option is set.
Motivation
This is a trade-off so that switching between
all: trueandall: falsedoesn't change the value of thedns.addresstag by adding a newdns.addressestag instead to store all the addresses while the former will continue to only store the first address.See #2031 (comment)