Repository navigation
fix(net): clean up synchronous connection failures - #10128
Merged
Merged
Conversation
Node.js validates some TCP and IPC connection options synchronously before a socket emits any lifecycle event. Those failures bypassed tracer cleanup and retained listeners plus a nested emit wrapper on every retry. Clean up only the current attempt before rethrowing the original error, and leave caller-owned listeners, callback identity, and the previous emit implementation unchanged.
Contributor
Overall package sizeSelf size: 8.74 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: eebbe00 | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10128 +/- ##
==========================================
- Coverage 98.63% 98.62% -0.01%
==========================================
Files 1002 1002
Lines 154897 154894 -3
Branches 13358 13358
==========================================
- Hits 152779 152765 -14
- Misses 2118 2129 +11 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2026-09-03 15:14:30 Comparing candidate commit eebbe00 in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 2307 metrics, 18 unstable metrics.
|
The restoration assignment owns no state or lifecycle, so keeping it in a helper obscured the existing connection branches. Inline the assignment at each branch while preserving the accepted own-property contract.
BridgeAR
marked this pull request as ready for review
September 3, 2026 15:02
BridgeAR
enabled auto-merge (squash)
September 3, 2026 16:25
bengl
approved these changes
Sep 3, 2026
BridgeAR
disabled auto-merge
September 3, 2026 19:54
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
* fix(net): clean up synchronous connection failures Node.js validates some TCP and IPC connection options synchronously before a socket emits any lifecycle event. Those failures bypassed tracer cleanup and retained listeners plus a nested emit wrapper on every retry. Clean up only the current attempt before rethrowing the original error, and leave caller-owned listeners, callback identity, and the previous emit implementation unchanged. * refactor(net): inline socket emit restoration The restoration assignment owns no state or lifecycle, so keeping it in a helper obscured the existing connection branches. Inline the assignment at each branch while preserving the accepted own-property contract.
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Sep 3, 2026
* fix(net): clean up synchronous connection failures Node.js validates some TCP and IPC connection options synchronously before a socket emits any lifecycle event. Those failures bypassed tracer cleanup and retained listeners plus a nested emit wrapper on every retry. Clean up only the current attempt before rethrowing the original error, and leave caller-owned listeners, callback identity, and the previous emit implementation unchanged. * refactor(net): inline socket emit restoration The restoration assignment owns no state or lifecycle, so keeping it in a helper obscured the existing connection branches. Inline the assignment at each branch while preserving the accepted own-property contract.
BridgeAR
added a commit
that referenced
this pull request
Sep 4, 2026
* fix(net): clean up synchronous connection failures Node.js validates some TCP and IPC connection options synchronously before a socket emits any lifecycle event. Those failures bypassed tracer cleanup and retained listeners plus a nested emit wrapper on every retry. Clean up only the current attempt before rethrowing the original error, and leave caller-owned listeners, callback identity, and the previous emit implementation unchanged. * refactor(net): inline socket emit restoration The restoration assignment owns no state or lifecycle, so keeping it in a helper obscured the existing connection branches. Inline the assignment at each branch while preserving the accepted own-property contract.
BridgeAR
added a commit
that referenced
this pull request
Sep 4, 2026
* fix(net): clean up synchronous connection failures Node.js validates some TCP and IPC connection options synchronously before a socket emits any lifecycle event. Those failures bypassed tracer cleanup and retained listeners plus a nested emit wrapper on every retry. Clean up only the current attempt before rethrowing the original error, and leave caller-owned listeners, callback identity, and the previous emit implementation unchanged. * refactor(net): inline socket emit restoration The restoration assignment owns no state or lifecycle, so keeping it in a helper obscured the existing connection branches. Inline the assignment at each branch while preserving the accepted own-property contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js validates some TCP and IPC connection options synchronously before a socket emits any lifecycle event. Those failures bypassed tracer cleanup and retained listeners plus a nested
emitwrapper on every retry.Clean up only the current attempt before rethrowing the original error, and leave caller-owned listeners, callback identity, and the previous
emitimplementation unchanged.