Repository navigation
perf(tracer): build runtime strings directly - #10089
Conversation
Overall package sizeSelf size: 8.64 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.4.0 | 127.33 kB | 447.04 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: 0236535 | Docs | View more details | Give us feedback! |
BenchmarksBenchmark execution time: 2026-09-01 09:32:10 Comparing candidate commit 0236535 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2290 metrics, 20 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10089 +/- ##
========================================
Coverage 98.62% 98.62%
========================================
Files 996 996
Lines 152043 152050 +7
Branches 13207 12945 -262
========================================
+ Hits 149956 149963 +7
Misses 2087 2087
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 863f5932ab
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Direct concatenation reduced one-block formatting from 22.4–22.6 ns to 5.0 ns and three-block formatting from 46.4–47.6 ns to 12.6–12.9 ns. The benchmark used Node 22.20.0 / V8 12.4, one million iterations, and seven trials with the best and worst removed. AMQP link names without an underscore previously produced an empty short name, which dropped the link name from the span resource.
863f593 to
0236535
Compare
Direct concatenation reduced one-block formatting from 22.4–22.6 ns to 5.0 ns and three-block formatting from 46.4–47.6 ns to 12.6–12.9 ns. The benchmark used Node 22.20.0 / V8 12.4, one million iterations, and seven trials with the best and worst removed. AMQP link names without an underscore previously produced an empty short name, which dropped the link name from the span resource.
Direct concatenation reduced one-block formatting from 22.4–22.6 ns to 5.0 ns and three-block formatting from 46.4–47.6 ns to 12.6–12.9 ns. The benchmark used Node 22.20.0 / V8 12.4, one million iterations, and seven trials with the best and worst removed. AMQP link names without an underscore previously produced an empty short name, which dropped the link name from the span resource.
Direct concatenation reduced one-block formatting from 22.4–22.6 ns to 5.0 ns and three-block formatting from 46.4–47.6 ns to 12.6–12.9 ns. The benchmark used Node 22.20.0 / V8 12.4, one million iterations, and seven trials with the best and worst removed. AMQP link names without an underscore previously produced an empty short name, which dropped the link name from the span resource.
Direct concatenation reduced one-block formatting from 22.4–22.6 ns to 5.0 ns and three-block formatting from 46.4–47.6 ns to 12.6–12.9 ns. The benchmark used Node 22.20.0 / V8 12.4, one million iterations, and seven trials with the best and worst removed. AMQP link names without an underscore previously produced an empty short name, which dropped the link name from the span resource.
Direct concatenation reduced one-block formatting from 22.4–22.6 ns to 5.0 ns. Three-block formatting dropped from 46.4–47.6 ns to 12.6–12.9 ns.
The benchmark used Node 22.20.0 / V8 12.4, one million iterations, and seven trials with the best and worst removed.
Caller-provided AMQP link names without an underscore previously produced an empty short name, which dropped the link name from the span resource.