Repository navigation
fix(test-optimization): retry transient HTTP responses - #10039
Conversation
Retry HTTP 408, 429, and 500-599 responses for background and finalization payload sends. Keep the existing attempt cap for background work, allow finalization retries while its deadline has capacity, and bound background rate-limit waits without constraining a larger finalization budget.
Overall package sizeSelf size: 8.42 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.3 | 125.43 kB | 445.14 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
@codex review |
|
/datadog autotest review |
![datadog-prod-us1-5[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
More details
The retry rules keep the background attempt limit and rate-limit bound. Finalization retries remain limited by the deadline.
🤖 Datadog Autotest · Commit b0af7e2 · What is Autotest? · @DataDog review to ask questions · Any feedback? Reach out in #autotest
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
BenchmarksBenchmark execution time: 2026-08-28 09:13:55 Comparing candidate commit b0af7e2 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2297 metrics, 13 unstable metrics.
|
|
✅ All CI checks and tests passed. 🎉 All green!🧪 All tests passed 🎯 Code Coverage (details) 🔗 Commit SHA: b0af7e2 | Docs | View more details | Give us feedback! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #10039 +/- ##
==========================================
- Coverage 98.58% 98.58% -0.01%
==========================================
Files 991 991
Lines 149346 149354 +8
Branches 12707 13085 +378
==========================================
+ Hits 147237 147244 +7
- Misses 2109 2110 +1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
What does this PR do?
Retries transient HTTP 408, 429, and 500-599 responses for Test Optimization payloads during both background sends and finalization. Background sends retain the existing attempt cap, while finalization retries continue only while the existing deadline has capacity.
Rate-limit reset headers remain bounded to 30 seconds for background sends. A larger reset delay is allowed during finalization only when it fits inside the finalization deadline.
Motivation
Background payload sends currently retry transient network errors but not transient HTTP responses, and HTTP 408 is not retried at all. This can drop a payload after a single temporary intake response even though the request is replayable.
This change is extracted from #9987 and is based directly on master. It is independent of #10018 and #10038.
Additional Notes
This PR intentionally excludes socket concurrency, payload buffering/backpressure, request attempt timeouts, detachment, final-flush timeout changes, and telemetry enrichment.
Verification: