Repository navigation
Conversation
palazzem
approved these changes
Feb 5, 2018
| const map = { | ||
| 'service.name': 'service', | ||
| 'span.type': 'type', | ||
| 'resource.name': 'resource' |
| } | ||
| } | ||
|
|
||
| function extractTags (trace, tags) { |
Contributor
There was a problem hiding this comment.
this approach works, and probably we should do something similar to report errors (from OpenTracing API). We can chat about that later and not in this PR since attaching errors is something we can do later.
alrosot
pushed a commit
to alrosot/dd-trace-js
that referenced
this pull request
May 20, 2021
config standardization
This was referenced Aug 19, 2026
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a formatter that converts an OpenTracing span to a Datadog trace span.