Skip to content

dd-trace-js can't wrap query or execute method on mysql2@3.11.5 #4958

Closed
@0816i

Description

@0816i

In version 3.11.5 of the mysql2 library (refer to the PR below), some dependencies have been reorganized, and the query, execute, and addCommand methods have been consolidated into the Connection class under the base directory.

Therefore, when creating hooks for the mysql2 library in datadog-instrumentations, it seems necessary to add hooks based on lib/base/connection.js for version 3.11.5.

Additionally, since the query and execute methods in lib/connection.js, lib/pool.js, and lib/pool_cluster.js also reference the query and execute methods in lib/base/connection.js, it is necessary to ensure that they are not hooked redundantly.

sidorares/node-mysql2#3081

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions