-
Notifications
You must be signed in to change notification settings - Fork 317
Fix oversight with one overload of startSpan not using singleSpanBuilder #9995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed oversight where one overload of startSpan wasn't updated to use singleSpanBuilder
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~80f389c6fe, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1098013
Total [baseline] (10.74 s) : 0, 10740231
Agent [candidate] (1.109 s) : 0, 1109455
Total [candidate] (10.946 s) : 0, 10945667
section appsec
Agent [baseline] (1.276 s) : 0, 1276087
Total [baseline] (11.037 s) : 0, 11036752
Agent [candidate] (1.297 s) : 0, 1296936
Total [candidate] (11.096 s) : 0, 11095693
section iast
Agent [baseline] (1.238 s) : 0, 1237518
Total [baseline] (11.23 s) : 0, 11230164
Agent [candidate] (1.233 s) : 0, 1232971
Total [candidate] (11.236 s) : 0, 11235933
section profiling
Agent [baseline] (1.228 s) : 0, 1227569
Total [baseline] (11.072 s) : 0, 11071556
Agent [candidate] (1.229 s) : 0, 1229026
Total [candidate] (11.006 s) : 0, 11006381
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~80f389c6fe, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.469 ms) : 0, 1469
BytebuddyAgent [baseline] (704.742 ms) : 0, 704742
BytebuddyAgent [candidate] (713.333 ms) : 0, 713333
GlobalTracer [baseline] (248.321 ms) : 0, 248321
GlobalTracer [candidate] (249.922 ms) : 0, 249922
AppSec [baseline] (32.241 ms) : 0, 32241
AppSec [candidate] (32.536 ms) : 0, 32536
Debugger [baseline] (63.967 ms) : 0, 63967
Debugger [candidate] (64.415 ms) : 0, 64415
Remote Config [baseline] (637.125 µs) : 0, 637
Remote Config [candidate] (639.282 µs) : 0, 639
Telemetry [baseline] (8.217 ms) : 0, 8217
Telemetry [candidate] (8.314 ms) : 0, 8314
Flare Poller [baseline] (3.694 ms) : 0, 3694
Flare Poller [candidate] (3.725 ms) : 0, 3725
section appsec
crashtracking [baseline] (1.442 ms) : 0, 1442
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (728.061 ms) : 0, 728061
BytebuddyAgent [candidate] (739.887 ms) : 0, 739887
GlobalTracer [baseline] (239.923 ms) : 0, 239923
GlobalTracer [candidate] (244.528 ms) : 0, 244528
IAST [baseline] (24.781 ms) : 0, 24781
IAST [candidate] (25.474 ms) : 0, 25474
AppSec [baseline] (174.045 ms) : 0, 174045
AppSec [candidate] (175.745 ms) : 0, 175745
Debugger [baseline] (60.109 ms) : 0, 60109
Debugger [candidate] (61.525 ms) : 0, 61525
Remote Config [baseline] (664.797 µs) : 0, 665
Remote Config [candidate] (684.388 µs) : 0, 684
Telemetry [baseline] (8.268 ms) : 0, 8268
Telemetry [candidate] (8.414 ms) : 0, 8414
Flare Poller [baseline] (3.839 ms) : 0, 3839
Flare Poller [candidate] (3.917 ms) : 0, 3917
section iast
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (829.524 ms) : 0, 829524
BytebuddyAgent [candidate] (825.424 ms) : 0, 825424
GlobalTracer [baseline] (237.944 ms) : 0, 237944
GlobalTracer [candidate] (236.962 ms) : 0, 236962
IAST [baseline] (29.203 ms) : 0, 29203
IAST [candidate] (27.361 ms) : 0, 27361
AppSec [baseline] (32.445 ms) : 0, 32445
AppSec [candidate] (34.24 ms) : 0, 34240
Debugger [baseline] (60.52 ms) : 0, 60520
Debugger [candidate] (61.03 ms) : 0, 61030
Remote Config [baseline] (541.192 µs) : 0, 541
Remote Config [candidate] (556.385 µs) : 0, 556
Telemetry [baseline] (7.593 ms) : 0, 7593
Telemetry [candidate] (7.7 ms) : 0, 7700
Flare Poller [baseline] (3.41 ms) : 0, 3410
Flare Poller [candidate] (3.485 ms) : 0, 3485
section profiling
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (729.282 ms) : 0, 729282
BytebuddyAgent [candidate] (730.85 ms) : 0, 730850
GlobalTracer [baseline] (221.866 ms) : 0, 221866
GlobalTracer [candidate] (221.836 ms) : 0, 221836
AppSec [baseline] (32.165 ms) : 0, 32165
AppSec [candidate] (32.207 ms) : 0, 32207
Debugger [baseline] (63.167 ms) : 0, 63167
Debugger [candidate] (63.479 ms) : 0, 63479
Remote Config [baseline] (674.041 µs) : 0, 674
Remote Config [candidate] (651.62 µs) : 0, 652
Telemetry [baseline] (8.066 ms) : 0, 8066
Telemetry [candidate] (7.997 ms) : 0, 7997
Flare Poller [baseline] (3.827 ms) : 0, 3827
Flare Poller [candidate] (3.769 ms) : 0, 3769
ProfilingAgent [baseline] (97.5 ms) : 0, 97500
ProfilingAgent [candidate] (97.13 ms) : 0, 97130
Profiling [baseline] (98.089 ms) : 0, 98089
Profiling [candidate] (97.728 ms) : 0, 97728
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~80f389c6fe, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.097 s) : 0, 1096762
Total [baseline] (8.852 s) : 0, 8851501
Agent [candidate] (1.094 s) : 0, 1093931
Total [candidate] (8.825 s) : 0, 8825231
section iast
Agent [baseline] (1.229 s) : 0, 1229176
Total [baseline] (9.512 s) : 0, 9512127
Agent [candidate] (1.233 s) : 0, 1232882
Total [candidate] (9.524 s) : 0, 9524347
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~80f389c6fe, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.442 ms) : 0, 1442
BytebuddyAgent [baseline] (703.47 ms) : 0, 703470
BytebuddyAgent [candidate] (702.586 ms) : 0, 702586
GlobalTracer [baseline] (248.907 ms) : 0, 248907
GlobalTracer [candidate] (247.679 ms) : 0, 247679
AppSec [baseline] (32.631 ms) : 0, 32631
AppSec [candidate] (32.054 ms) : 0, 32054
Debugger [baseline] (63.099 ms) : 0, 63099
Debugger [candidate] (62.952 ms) : 0, 62952
Remote Config [baseline] (635.332 µs) : 0, 635
Remote Config [candidate] (627.735 µs) : 0, 628
Telemetry [baseline] (8.21 ms) : 0, 8210
Telemetry [candidate] (8.169 ms) : 0, 8169
Flare Poller [baseline] (3.655 ms) : 0, 3655
Flare Poller [candidate] (3.68 ms) : 0, 3680
section iast
crashtracking [baseline] (1.445 ms) : 0, 1445
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (824.348 ms) : 0, 824348
BytebuddyAgent [candidate] (826.437 ms) : 0, 826437
GlobalTracer [baseline] (236.66 ms) : 0, 236660
GlobalTracer [candidate] (237.308 ms) : 0, 237308
IAST [baseline] (28.953 ms) : 0, 28953
IAST [candidate] (27.202 ms) : 0, 27202
AppSec [baseline] (32.085 ms) : 0, 32085
AppSec [candidate] (34.094 ms) : 0, 34094
Debugger [baseline] (59.379 ms) : 0, 59379
Debugger [candidate] (59.898 ms) : 0, 59898
Remote Config [baseline] (541.88 µs) : 0, 542
Remote Config [candidate] (534.045 µs) : 0, 534
Telemetry [baseline] (7.597 ms) : 0, 7597
Telemetry [candidate] (7.575 ms) : 0, 7575
Flare Poller [baseline] (3.41 ms) : 0, 3410
Flare Poller [candidate] (3.43 ms) : 0, 3430
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 4 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~80f389c6fe, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section baseline
no_agent (19.463 ms) : 19264, 19663
. : milestone, 19463,
appsec (18.467 ms) : 18281, 18653
. : milestone, 18467,
code_origins (18.956 ms) : 18767, 19146
. : milestone, 18956,
iast (17.704 ms) : 17528, 17880
. : milestone, 17704,
profiling (18.863 ms) : 18676, 19050
. : milestone, 18863,
tracing (17.749 ms) : 17573, 17926
. : milestone, 17749,
section candidate
no_agent (17.128 ms) : 16957, 17299
. : milestone, 17128,
appsec (18.838 ms) : 18648, 19028
. : milestone, 18838,
code_origins (17.774 ms) : 17596, 17952
. : milestone, 17774,
iast (17.782 ms) : 17604, 17960
. : milestone, 17782,
profiling (20.715 ms) : 20508, 20922
. : milestone, 20715,
tracing (17.884 ms) : 17701, 18067
. : milestone, 17884,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~80f389c6fe, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section baseline
no_agent (1.205 ms) : 1193, 1216
. : milestone, 1205,
iast (3.177 ms) : 3133, 3220
. : milestone, 3177,
iast_FULL (5.723 ms) : 5667, 5779
. : milestone, 5723,
iast_GLOBAL (3.536 ms) : 3487, 3585
. : milestone, 3536,
profiling (2.125 ms) : 2105, 2146
. : milestone, 2125,
tracing (1.89 ms) : 1875, 1906
. : milestone, 1890,
section candidate
no_agent (1.186 ms) : 1175, 1197
. : milestone, 1186,
iast (3.278 ms) : 3234, 3321
. : milestone, 3278,
iast_FULL (5.798 ms) : 5741, 5856
. : milestone, 5798,
iast_GLOBAL (3.807 ms) : 3718, 3895
. : milestone, 3807,
profiling (2.207 ms) : 2188, 2226
. : milestone, 2207,
tracing (1.851 ms) : 1835, 1866
. : milestone, 1851,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~80f389c6fe, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.691 ms) : 3474, 3909
. : milestone, 3691,
iast (2.209 ms) : 2146, 2273
. : milestone, 2209,
iast_GLOBAL (2.261 ms) : 2197, 2326
. : milestone, 2261,
profiling (2.067 ms) : 2015, 2119
. : milestone, 2067,
tracing (2.056 ms) : 2005, 2106
. : milestone, 2056,
section candidate
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.596 ms) : 3389, 3803
. : milestone, 3596,
iast (2.217 ms) : 2153, 2281
. : milestone, 2217,
iast_GLOBAL (2.261 ms) : 2196, 2325
. : milestone, 2261,
profiling (2.088 ms) : 2035, 2141
. : milestone, 2088,
tracing (2.031 ms) : 1981, 2081
. : milestone, 2031,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~80f389c6fe, baseline=1.56.0-SNAPSHOT~fb40abaeee
dateFormat X
axisFormat %s
section baseline
no_agent (15.004 s) : 15004000, 15004000
. : milestone, 15004000,
appsec (15.207 s) : 15207000, 15207000
. : milestone, 15207000,
iast (18.593 s) : 18593000, 18593000
. : milestone, 18593000,
iast_GLOBAL (17.957 s) : 17957000, 17957000
. : milestone, 17957000,
profiling (15.079 s) : 15079000, 15079000
. : milestone, 15079000,
tracing (14.769 s) : 14769000, 14769000
. : milestone, 14769000,
section candidate
no_agent (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
appsec (14.729 s) : 14729000, 14729000
. : milestone, 14729000,
iast (19.057 s) : 19057000, 19057000
. : milestone, 19057000,
iast_GLOBAL (17.995 s) : 17995000, 17995000
. : milestone, 17995000,
profiling (15.619 s) : 15619000, 15619000
. : milestone, 15619000,
tracing (14.859 s) : 14859000, 14859000
. : milestone, 14859000,
|
What Does This Do
Fixed oversight where one overload of startSpan wasn't updated to use singleSpanBuilder
Motivation
singleSpanBuilder is able to reuse SpanBuilders to reduce allocation / garbage collection overhead
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]