-
Notifications
You must be signed in to change notification settings - Fork 316
Use ClassNameTrie from its new location in dd-instrument-java
#9977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
aa6b425 to
090d6c1
Compare
|
🎯 Code Coverage 🔗 Commit SHA: 394917e | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
Debugger benchmarksParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 5 unstable metrics. See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (320.244 µs) : 294, 347
. : milestone, 320,
basic (292.425 µs) : 284, 301
. : milestone, 292,
loop (8.441 ms) : 8379, 8502
. : milestone, 8441,
section candidate
noprobe (325.464 µs) : 293, 358
. : milestone, 325,
basic (295.09 µs) : 288, 303
. : milestone, 295,
loop (8.448 ms) : 8385, 8510
. : milestone, 8448,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~394917e215, baseline=1.56.0-SNAPSHOT~121136e971
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.1 s) : 0, 1100481
Total [baseline] (8.885 s) : 0, 8884628
Agent [candidate] (1.109 s) : 0, 1109164
Total [candidate] (8.862 s) : 0, 8861771
section iast
Agent [baseline] (1.234 s) : 0, 1234439
Total [baseline] (9.547 s) : 0, 9546990
Agent [candidate] (1.244 s) : 0, 1244155
Total [candidate] (9.568 s) : 0, 9567815
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~394917e215, baseline=1.56.0-SNAPSHOT~121136e971
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (705.974 ms) : 0, 705974
BytebuddyAgent [candidate] (713.294 ms) : 0, 713294
GlobalTracer [baseline] (249.388 ms) : 0, 249388
GlobalTracer [candidate] (250.853 ms) : 0, 250853
AppSec [baseline] (32.468 ms) : 0, 32468
AppSec [candidate] (32.641 ms) : 0, 32641
Debugger [baseline] (63.977 ms) : 0, 63977
Debugger [candidate] (63.461 ms) : 0, 63461
Remote Config [baseline] (640.308 µs) : 0, 640
Remote Config [candidate] (625.999 µs) : 0, 626
Telemetry [baseline] (8.147 ms) : 0, 8147
Telemetry [candidate] (8.119 ms) : 0, 8119
Flare Poller [baseline] (3.638 ms) : 0, 3638
Flare Poller [candidate] (3.599 ms) : 0, 3599
section iast
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (828.13 ms) : 0, 828130
BytebuddyAgent [candidate] (834.849 ms) : 0, 834849
GlobalTracer [baseline] (237.226 ms) : 0, 237226
GlobalTracer [candidate] (238.631 ms) : 0, 238631
IAST [baseline] (28.272 ms) : 0, 28272
IAST [candidate] (26.755 ms) : 0, 26755
AppSec [baseline] (32.933 ms) : 0, 32933
AppSec [candidate] (35.202 ms) : 0, 35202
Debugger [baseline] (59.904 ms) : 0, 59904
Debugger [candidate] (60.414 ms) : 0, 60414
Remote Config [baseline] (536.554 µs) : 0, 537
Remote Config [candidate] (543.73 µs) : 0, 544
Telemetry [baseline] (7.616 ms) : 0, 7616
Telemetry [candidate] (7.687 ms) : 0, 7687
Flare Poller [baseline] (3.454 ms) : 0, 3454
Flare Poller [candidate] (3.503 ms) : 0, 3503
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~394917e215, baseline=1.56.0-SNAPSHOT~121136e971
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.097 s) : 0, 1097044
Total [baseline] (10.756 s) : 0, 10756441
Agent [candidate] (1.1 s) : 0, 1100257
Total [candidate] (10.805 s) : 0, 10805317
section appsec
Agent [baseline] (1.292 s) : 0, 1291639
Total [baseline] (11.058 s) : 0, 11057904
Agent [candidate] (1.279 s) : 0, 1279143
Total [candidate] (11.05 s) : 0, 11050224
section iast
Agent [baseline] (1.246 s) : 0, 1245530
Total [baseline] (11.232 s) : 0, 11231904
Agent [candidate] (1.236 s) : 0, 1236107
Total [candidate] (11.316 s) : 0, 11316243
section profiling
Agent [baseline] (1.229 s) : 0, 1228948
Total [baseline] (11.069 s) : 0, 11069423
Agent [candidate] (1.228 s) : 0, 1228300
Total [candidate] (11.013 s) : 0, 11012796
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~394917e215, baseline=1.56.0-SNAPSHOT~121136e971
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (703.916 ms) : 0, 703916
BytebuddyAgent [candidate] (705.965 ms) : 0, 705965
GlobalTracer [baseline] (247.806 ms) : 0, 247806
GlobalTracer [candidate] (248.534 ms) : 0, 248534
AppSec [baseline] (32.213 ms) : 0, 32213
AppSec [candidate] (32.339 ms) : 0, 32339
Debugger [baseline] (64.341 ms) : 0, 64341
Debugger [candidate] (64.4 ms) : 0, 64400
Remote Config [baseline] (690.842 µs) : 0, 691
Remote Config [candidate] (627.324 µs) : 0, 627
Telemetry [baseline] (8.116 ms) : 0, 8116
Telemetry [candidate] (8.244 ms) : 0, 8244
Flare Poller [baseline] (3.71 ms) : 0, 3710
Flare Poller [candidate] (3.661 ms) : 0, 3661
section appsec
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (737.502 ms) : 0, 737502
BytebuddyAgent [candidate] (730.867 ms) : 0, 730867
GlobalTracer [baseline] (242.544 ms) : 0, 242544
GlobalTracer [candidate] (239.789 ms) : 0, 239789
IAST [baseline] (25.274 ms) : 0, 25274
IAST [candidate] (24.701 ms) : 0, 24701
AppSec [baseline] (175.489 ms) : 0, 175489
AppSec [candidate] (174.149 ms) : 0, 174149
Debugger [baseline] (61.324 ms) : 0, 61324
Debugger [candidate] (60.259 ms) : 0, 60259
Remote Config [baseline] (665.701 µs) : 0, 666
Remote Config [candidate] (718.357 µs) : 0, 718
Telemetry [baseline] (8.257 ms) : 0, 8257
Telemetry [candidate] (8.27 ms) : 0, 8270
Flare Poller [baseline] (3.82 ms) : 0, 3820
Flare Poller [candidate] (3.847 ms) : 0, 3847
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (835.724 ms) : 0, 835724
BytebuddyAgent [candidate] (827.65 ms) : 0, 827650
GlobalTracer [baseline] (238.968 ms) : 0, 238968
GlobalTracer [candidate] (238.054 ms) : 0, 238054
IAST [baseline] (28.227 ms) : 0, 28227
IAST [candidate] (30.026 ms) : 0, 30026
AppSec [baseline] (33.427 ms) : 0, 33427
AppSec [candidate] (31.308 ms) : 0, 31308
Debugger [baseline] (60.72 ms) : 0, 60720
Debugger [candidate] (61.063 ms) : 0, 61063
Remote Config [baseline] (545.406 µs) : 0, 545
Remote Config [candidate] (539.714 µs) : 0, 540
Telemetry [baseline] (7.829 ms) : 0, 7829
Telemetry [candidate] (7.707 ms) : 0, 7707
Flare Poller [baseline] (3.47 ms) : 0, 3470
Flare Poller [candidate] (3.522 ms) : 0, 3522
section profiling
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (730.386 ms) : 0, 730386
BytebuddyAgent [candidate] (730.557 ms) : 0, 730557
GlobalTracer [baseline] (222.063 ms) : 0, 222063
GlobalTracer [candidate] (222.209 ms) : 0, 222209
AppSec [baseline] (32.405 ms) : 0, 32405
AppSec [candidate] (32.18 ms) : 0, 32180
Debugger [baseline] (63.022 ms) : 0, 63022
Debugger [candidate] (62.729 ms) : 0, 62729
Remote Config [baseline] (656.208 µs) : 0, 656
Remote Config [candidate] (646.839 µs) : 0, 647
Telemetry [baseline] (8.021 ms) : 0, 8021
Telemetry [candidate] (7.934 ms) : 0, 7934
Flare Poller [baseline] (3.819 ms) : 0, 3819
Flare Poller [candidate] (3.749 ms) : 0, 3749
ProfilingAgent [baseline] (97.406 ms) : 0, 97406
ProfilingAgent [candidate] (97.138 ms) : 0, 97138
Profiling [baseline] (97.991 ms) : 0, 97991
Profiling [candidate] (97.714 ms) : 0, 97714
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~394917e215, baseline=1.56.0-SNAPSHOT~121136e971
dateFormat X
axisFormat %s
section baseline
no_agent (19.126 ms) : 18930, 19322
. : milestone, 19126,
appsec (18.427 ms) : 18240, 18614
. : milestone, 18427,
code_origins (17.74 ms) : 17565, 17914
. : milestone, 17740,
iast (17.875 ms) : 17697, 18053
. : milestone, 17875,
profiling (18.629 ms) : 18443, 18815
. : milestone, 18629,
tracing (17.597 ms) : 17423, 17772
. : milestone, 17597,
section candidate
no_agent (19.026 ms) : 18831, 19221
. : milestone, 19026,
appsec (18.591 ms) : 18400, 18782
. : milestone, 18591,
code_origins (19.666 ms) : 19473, 19858
. : milestone, 19666,
iast (17.719 ms) : 17545, 17893
. : milestone, 17719,
profiling (18.635 ms) : 18447, 18823
. : milestone, 18635,
tracing (18.652 ms) : 18464, 18839
. : milestone, 18652,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~394917e215, baseline=1.56.0-SNAPSHOT~121136e971
dateFormat X
axisFormat %s
section baseline
no_agent (1.177 ms) : 1165, 1189
. : milestone, 1177,
iast (3.212 ms) : 3144, 3279
. : milestone, 3212,
iast_FULL (5.679 ms) : 5577, 5781
. : milestone, 5679,
iast_GLOBAL (3.675 ms) : 3622, 3728
. : milestone, 3675,
profiling (1.899 ms) : 1883, 1914
. : milestone, 1899,
tracing (1.821 ms) : 1806, 1836
. : milestone, 1821,
section candidate
no_agent (1.187 ms) : 1176, 1199
. : milestone, 1187,
iast (3.222 ms) : 3181, 3262
. : milestone, 3222,
iast_FULL (5.673 ms) : 5617, 5728
. : milestone, 5673,
iast_GLOBAL (3.762 ms) : 3673, 3851
. : milestone, 3762,
profiling (2.027 ms) : 2008, 2046
. : milestone, 2027,
tracing (1.795 ms) : 1779, 1810
. : milestone, 1795,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~394917e215, baseline=1.56.0-SNAPSHOT~121136e971
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.716 ms) : 3498, 3934
. : milestone, 3716,
iast (2.218 ms) : 2155, 2282
. : milestone, 2218,
iast_GLOBAL (2.269 ms) : 2205, 2333
. : milestone, 2269,
profiling (2.074 ms) : 2022, 2125
. : milestone, 2074,
tracing (2.043 ms) : 1993, 2093
. : milestone, 2043,
section candidate
no_agent (1.486 ms) : 1474, 1498
. : milestone, 1486,
appsec (3.723 ms) : 3504, 3941
. : milestone, 3723,
iast (2.232 ms) : 2169, 2296
. : milestone, 2232,
iast_GLOBAL (2.259 ms) : 2195, 2322
. : milestone, 2259,
profiling (2.098 ms) : 2045, 2151
. : milestone, 2098,
tracing (2.032 ms) : 1983, 2081
. : milestone, 2032,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~394917e215, baseline=1.56.0-SNAPSHOT~121136e971
dateFormat X
axisFormat %s
section baseline
no_agent (15.024 s) : 15024000, 15024000
. : milestone, 15024000,
appsec (14.583 s) : 14583000, 14583000
. : milestone, 14583000,
iast (18.55 s) : 18550000, 18550000
. : milestone, 18550000,
iast_GLOBAL (17.742 s) : 17742000, 17742000
. : milestone, 17742000,
profiling (15.007 s) : 15007000, 15007000
. : milestone, 15007000,
tracing (14.729 s) : 14729000, 14729000
. : milestone, 14729000,
section candidate
no_agent (15.7 s) : 15700000, 15700000
. : milestone, 15700000,
appsec (15.171 s) : 15171000, 15171000
. : milestone, 15171000,
iast (18.074 s) : 18074000, 18074000
. : milestone, 18074000,
iast_GLOBAL (17.906 s) : 17906000, 17906000
. : milestone, 17906000,
profiling (15.412 s) : 15412000, 15412000
. : milestone, 15412000,
tracing (14.94 s) : 14940000, 14940000
. : milestone, 14940000,
|
What Does This Do
ClassNameTrieis now part of https://github.com/DataDog/dd-instrument-javaMotivation
Remove duplicate class.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]