Use `ClassNameFilter` to track uninteresting classes #9976

mcculls · 2025-11-15T19:36:31Z

What Does This Do

Replaces ClassCodeFilter with ClassNameFilter from https://github.com/DataDog/dd-instrument-java

ClassNameFilter has a number of improvements, including:

higher load factor
- more classes can be added to filters of the same size
faster membership testing
- avoids allocations when checking classes against class-codes

Motivation

Uninteresting classes can be excluded from further type-matching.

Note this information can be shared across runs if the type-resolver cache is enabled with
-Ddd.resolver.cache.dir=<directory> or DD_RESOLVER_CACHE_DIR=<directory>

Additional Notes

Also uses ClassNameFilter to track public classes.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

datadog-official · 2025-11-15T19:45:38Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 63.15% (+3.49%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 460fc41 | Docs | Datadog PR Page | Was this helpful? Give us feedback!}

pr-commenter · 2025-11-15T20:11:58Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/faster-class-name-filter
git_commit_date	1763394962	1763395873
git_commit_sha	`121136e`	`460fc41`
release_version	1.56.0-SNAPSHOT~121136e971	1.56.0-SNAPSHOT~460fc410b0

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1763397671	1763397671
ci_job_id	1239458851	1239458851
ci_pipeline_id	82735927	82735927
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-zr2umlod 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-zr2umlod 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics.

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~460fc410b0, baseline=1.56.0-SNAPSHOT~121136e971

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097840
Total [baseline] (10.816 s) : 0, 10815670
Agent [candidate] (1.108 s) : 0, 1108059
Total [candidate] (10.883 s) : 0, 10883473
section appsec
Agent [baseline] (1.281 s) : 0, 1280898
Total [baseline] (11.111 s) : 0, 11110802
Agent [candidate] (1.278 s) : 0, 1278038
Total [candidate] (11.056 s) : 0, 11055584
section iast
Agent [baseline] (1.247 s) : 0, 1246857
Total [baseline] (11.25 s) : 0, 11250337
Agent [candidate] (1.253 s) : 0, 1253487
Total [candidate] (11.268 s) : 0, 11268231
section profiling
Agent [baseline] (1.237 s) : 0, 1236881
Total [baseline] (11.106 s) : 0, 11105643
Agent [candidate] (1.243 s) : 0, 1242524
Total [candidate] (11.148 s) : 0, 11148281

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.098 s	-
Agent	appsec	1.281 s	183.058 ms (16.7%)
Agent	iast	1.247 s	149.017 ms (13.6%)
Agent	profiling	1.237 s	139.041 ms (12.7%)
Total	tracing	10.816 s	-
Total	appsec	11.111 s	295.132 ms (2.7%)
Total	iast	11.25 s	434.667 ms (4.0%)
Total	profiling	11.106 s	289.973 ms (2.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.108 s	-
Agent	appsec	1.278 s	169.978 ms (15.3%)
Agent	iast	1.253 s	145.427 ms (13.1%)
Agent	profiling	1.243 s	134.465 ms (12.1%)
Total	tracing	10.883 s	-
Total	appsec	11.056 s	172.112 ms (1.6%)
Total	iast	11.268 s	384.759 ms (3.5%)
Total	profiling	11.148 s	264.808 ms (2.4%)

gantt
    title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~460fc410b0, baseline=1.56.0-SNAPSHOT~121136e971

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (705.029 ms) : 0, 705029
BytebuddyAgent [candidate] (710.512 ms) : 0, 710512
GlobalTracer [baseline] (247.94 ms) : 0, 247940
GlobalTracer [candidate] (250.837 ms) : 0, 250837
AppSec [baseline] (32.033 ms) : 0, 32033
AppSec [candidate] (32.91 ms) : 0, 32910
Debugger [baseline] (63.992 ms) : 0, 63992
Debugger [candidate] (64.427 ms) : 0, 64427
Remote Config [baseline] (635.364 µs) : 0, 635
Remote Config [candidate] (650.442 µs) : 0, 650
Telemetry [baseline] (8.18 ms) : 0, 8180
Telemetry [candidate] (8.325 ms) : 0, 8325
Flare Poller [baseline] (3.733 ms) : 0, 3733
Flare Poller [candidate] (3.767 ms) : 0, 3767
section appsec
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (730.067 ms) : 0, 730067
BytebuddyAgent [candidate] (728.974 ms) : 0, 728974
GlobalTracer [baseline] (240.244 ms) : 0, 240244
GlobalTracer [candidate] (240.436 ms) : 0, 240436
AppSec [baseline] (174.851 ms) : 0, 174851
AppSec [candidate] (173.849 ms) : 0, 173849
Debugger [baseline] (61.553 ms) : 0, 61553
Debugger [candidate] (60.85 ms) : 0, 60850
Remote Config [baseline] (734.551 µs) : 0, 735
Remote Config [candidate] (646.567 µs) : 0, 647
Telemetry [baseline] (8.405 ms) : 0, 8405
Telemetry [candidate] (8.235 ms) : 0, 8235
Flare Poller [baseline] (3.986 ms) : 0, 3986
Flare Poller [candidate] (3.808 ms) : 0, 3808
IAST [baseline] (24.594 ms) : 0, 24594
IAST [candidate] (24.881 ms) : 0, 24881
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.483 ms) : 0, 1483
BytebuddyAgent [baseline] (836.403 ms) : 0, 836403
BytebuddyAgent [candidate] (842.103 ms) : 0, 842103
GlobalTracer [baseline] (238.984 ms) : 0, 238984
GlobalTracer [candidate] (239.494 ms) : 0, 239494
AppSec [baseline] (34.288 ms) : 0, 34288
AppSec [candidate] (30.586 ms) : 0, 30586
Debugger [baseline] (61.458 ms) : 0, 61458
Debugger [candidate] (61.55 ms) : 0, 61550
Remote Config [baseline] (544.265 µs) : 0, 544
Remote Config [candidate] (550.598 µs) : 0, 551
Telemetry [baseline] (7.734 ms) : 0, 7734
Telemetry [candidate] (7.718 ms) : 0, 7718
Flare Poller [baseline] (3.487 ms) : 0, 3487
Flare Poller [candidate] (3.509 ms) : 0, 3509
IAST [baseline] (27.396 ms) : 0, 27396
IAST [candidate] (31.498 ms) : 0, 31498
section profiling
ProfilingAgent [baseline] (97.449 ms) : 0, 97449
ProfilingAgent [candidate] (98.244 ms) : 0, 98244
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (736.196 ms) : 0, 736196
BytebuddyAgent [candidate] (739.901 ms) : 0, 739901
GlobalTracer [baseline] (223.652 ms) : 0, 223652
GlobalTracer [candidate] (223.83 ms) : 0, 223830
AppSec [baseline] (32.491 ms) : 0, 32491
AppSec [candidate] (32.536 ms) : 0, 32536
Debugger [baseline] (63.178 ms) : 0, 63178
Debugger [candidate] (63.54 ms) : 0, 63540
Remote Config [baseline] (652.265 µs) : 0, 652
Remote Config [candidate] (673.83 µs) : 0, 674
Telemetry [baseline] (7.891 ms) : 0, 7891
Telemetry [candidate] (8.169 ms) : 0, 8169
Flare Poller [baseline] (3.783 ms) : 0, 3783
Flare Poller [candidate] (3.823 ms) : 0, 3823
Profiling [baseline] (98.056 ms) : 0, 98056
Profiling [candidate] (98.833 ms) : 0, 98833

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~460fc410b0, baseline=1.56.0-SNAPSHOT~121136e971

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1095709
Total [baseline] (8.829 s) : 0, 8828853
Agent [candidate] (1.104 s) : 0, 1104494
Total [candidate] (8.809 s) : 0, 8809276
section iast
Agent [baseline] (1.236 s) : 0, 1235586
Total [baseline] (9.516 s) : 0, 9515957
Agent [candidate] (1.236 s) : 0, 1236236
Total [candidate] (9.529 s) : 0, 9528782

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.096 s	-
Agent	iast	1.236 s	139.877 ms (12.8%)
Total	tracing	8.829 s	-
Total	iast	9.516 s	687.104 ms (7.8%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.104 s	-
Agent	iast	1.236 s	131.743 ms (11.9%)
Total	tracing	8.809 s	-
Total	iast	9.529 s	719.506 ms (8.2%)

gantt
    title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~460fc410b0, baseline=1.56.0-SNAPSHOT~121136e971

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (703.694 ms) : 0, 703694
BytebuddyAgent [candidate] (709.647 ms) : 0, 709647
GlobalTracer [baseline] (247.901 ms) : 0, 247901
GlobalTracer [candidate] (249.795 ms) : 0, 249795
AppSec [baseline] (32.192 ms) : 0, 32192
AppSec [candidate] (32.467 ms) : 0, 32467
Debugger [baseline] (63.342 ms) : 0, 63342
Debugger [candidate] (63.607 ms) : 0, 63607
Remote Config [baseline] (642.416 µs) : 0, 642
Remote Config [candidate] (643.179 µs) : 0, 643
Telemetry [baseline] (8.077 ms) : 0, 8077
Telemetry [candidate] (8.217 ms) : 0, 8217
Flare Poller [baseline] (3.637 ms) : 0, 3637
Flare Poller [candidate] (3.683 ms) : 0, 3683
section iast
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (828.815 ms) : 0, 828815
BytebuddyAgent [candidate] (829.566 ms) : 0, 829566
GlobalTracer [baseline] (237.605 ms) : 0, 237605
GlobalTracer [candidate] (237.393 ms) : 0, 237393
IAST [baseline] (26.667 ms) : 0, 26667
IAST [candidate] (27.541 ms) : 0, 27541
AppSec [baseline] (34.564 ms) : 0, 34564
AppSec [candidate] (33.793 ms) : 0, 33793
Debugger [baseline] (60.0 ms) : 0, 60000
Debugger [candidate] (60.081 ms) : 0, 60081
Remote Config [baseline] (547.661 µs) : 0, 548
Remote Config [candidate] (545.851 µs) : 0, 546
Telemetry [baseline] (7.581 ms) : 0, 7581
Telemetry [candidate] (7.609 ms) : 0, 7609
Flare Poller [baseline] (3.449 ms) : 0, 3449
Flare Poller [candidate] (3.394 ms) : 0, 3394

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/faster-class-name-filter
git_commit_date	1763394962	1763395873
git_commit_sha	`121136e`	`460fc41`
release_version	1.56.0-SNAPSHOT~121136e971	1.56.0-SNAPSHOT~460fc410b0

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1763398209	1763398209
ci_job_id	1239458853	1239458853
ci_pipeline_id	82735927	82735927
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-ivj33ily 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-ivj33ily 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 4 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.

scenario	Δ mean agg_http_req_duration_p50	Δ mean agg_http_req_duration_p95	Δ mean throughput	candidate mean agg_http_req_duration_p50	candidate mean agg_http_req_duration_p95	candidate mean throughput	baseline mean agg_http_req_duration_p50	baseline mean agg_http_req_duration_p95	baseline mean throughput
scenario:load:insecure-bank:iast_GLOBAL:high_load	worse [+129.313µs; +241.180µs] or [+4.666%; +8.703%]	unstable [-2637.203µs; +1167.453µs] or [-29.623%; +13.114%]	unstable [-191.726op/s; +126.851op/s] or [-15.207%; +10.062%]	2.957ms	8.168ms	1228.312op/s	2.771ms	8.903ms	1260.750op/s
scenario:load:petclinic:no_agent:high_load	worse [+1.361ms; +2.743ms] or [+8.205%; +16.539%]	unstable [+1.501ms; +4.554ms] or [+5.314%; +16.122%]	unstable [-54.937op/s; -1.063op/s] or [-20.186%; -0.391%]	18.636ms	31.278ms	244.156op/s	16.584ms	28.250ms	272.156op/s
scenario:load:petclinic:profiling:high_load	worse [+1.025ms; +2.178ms] or [+5.634%; +11.969%]	worse [+0.901ms; +3.345ms] or [+3.046%; +11.301%]	unstable [-42.566op/s; +6.254op/s] or [-16.864%; +2.478%]	19.795ms	31.717ms	234.250op/s	18.194ms	29.594ms	252.406op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~460fc410b0, baseline=1.56.0-SNAPSHOT~121136e971
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.179 ms) : 1168, 1191
.   : milestone, 1179,
iast (3.207 ms) : 3172, 3242
.   : milestone, 3207,
iast_FULL (5.75 ms) : 5692, 5808
.   : milestone, 5750,
iast_GLOBAL (3.639 ms) : 3521, 3756
.   : milestone, 3639,
profiling (2.018 ms) : 2000, 2037
.   : milestone, 2018,
tracing (1.818 ms) : 1803, 1833
.   : milestone, 1818,
section candidate
no_agent (1.19 ms) : 1178, 1201
.   : milestone, 1190,
iast (3.193 ms) : 3158, 3229
.   : milestone, 3193,
iast_FULL (5.827 ms) : 5769, 5886
.   : milestone, 5827,
iast_GLOBAL (3.738 ms) : 3675, 3800
.   : milestone, 3738,
profiling (1.902 ms) : 1887, 1918
.   : milestone, 1902,
tracing (1.794 ms) : 1779, 1808
.   : milestone, 1794,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.179 ms [1.168 ms, 1.191 ms]	-
iast	3.207 ms [3.172 ms, 3.242 ms]	2.027 ms (171.9%)
iast_FULL	5.75 ms [5.692 ms, 5.808 ms]	4.57 ms (387.5%)
iast_GLOBAL	3.639 ms [3.521 ms, 3.756 ms]	2.459 ms (208.5%)
profiling	2.018 ms [2.0 ms, 2.037 ms]	838.794 µs (71.1%)
tracing	1.818 ms [1.803 ms, 1.833 ms]	638.475 µs (54.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.19 ms [1.178 ms, 1.201 ms]	-
iast	3.193 ms [3.158 ms, 3.229 ms]	2.003 ms (168.4%)
iast_FULL	5.827 ms [5.769 ms, 5.886 ms]	4.638 ms (389.9%)
iast_GLOBAL	3.738 ms [3.675 ms, 3.8 ms]	2.548 ms (214.2%)
profiling	1.902 ms [1.887 ms, 1.918 ms]	712.523 µs (59.9%)
tracing	1.794 ms [1.779 ms, 1.808 ms]	604.077 µs (50.8%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~460fc410b0, baseline=1.56.0-SNAPSHOT~121136e971
    dateFormat X
    axisFormat %s
section baseline
no_agent (17.144 ms) : 16972, 17317
.   : milestone, 17144,
appsec (18.752 ms) : 18562, 18941
.   : milestone, 18752,
code_origins (17.733 ms) : 17558, 17909
.   : milestone, 17733,
iast (17.709 ms) : 17532, 17885
.   : milestone, 17709,
profiling (18.488 ms) : 18303, 18674
.   : milestone, 18488,
tracing (17.754 ms) : 17576, 17931
.   : milestone, 17754,
section candidate
no_agent (19.115 ms) : 18916, 19315
.   : milestone, 19115,
appsec (18.403 ms) : 18216, 18589
.   : milestone, 18403,
code_origins (17.658 ms) : 17485, 17832
.   : milestone, 17658,
iast (18.007 ms) : 17820, 18194
.   : milestone, 18007,
profiling (19.929 ms) : 19721, 20137
.   : milestone, 19929,
tracing (17.697 ms) : 17522, 17873
.   : milestone, 17697,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	17.144 ms [16.972 ms, 17.317 ms]	-
appsec	18.752 ms [18.562 ms, 18.941 ms]	1.607 ms (9.4%)
code_origins	17.733 ms [17.558 ms, 17.909 ms]	588.824 µs (3.4%)
iast	17.709 ms [17.532 ms, 17.885 ms]	564.438 µs (3.3%)
profiling	18.488 ms [18.303 ms, 18.674 ms]	1.344 ms (7.8%)
tracing	17.754 ms [17.576 ms, 17.931 ms]	609.143 µs (3.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	19.115 ms [18.916 ms, 19.315 ms]	-
appsec	18.403 ms [18.216 ms, 18.589 ms]	-712.931 µs (-3.7%)
code_origins	17.658 ms [17.485 ms, 17.832 ms]	-1.457 ms (-7.6%)
iast	18.007 ms [17.82 ms, 18.194 ms]	-1.108 ms (-5.8%)
profiling	19.929 ms [19.721 ms, 20.137 ms]	813.584 µs (4.3%)
tracing	17.697 ms [17.522 ms, 17.873 ms]	-1.418 ms (-7.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/faster-class-name-filter
git_commit_date	1763394962	1763395873
git_commit_sha	`121136e`	`460fc41`
release_version	1.56.0-SNAPSHOT~121136e971	1.56.0-SNAPSHOT~460fc410b0

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1763398006	1763398006
ci_job_id	1239458854	1239458854
ci_pipeline_id	82735927	82735927
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-0k7a1wpn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-0k7a1wpn 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~460fc410b0, baseline=1.56.0-SNAPSHOT~121136e971
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.046 s) : 15046000, 15046000
.   : milestone, 15046000,
appsec (14.723 s) : 14723000, 14723000
.   : milestone, 14723000,
iast (18.003 s) : 18003000, 18003000
.   : milestone, 18003000,
iast_GLOBAL (17.989 s) : 17989000, 17989000
.   : milestone, 17989000,
profiling (15.093 s) : 15093000, 15093000
.   : milestone, 15093000,
tracing (15.101 s) : 15101000, 15101000
.   : milestone, 15101000,
section candidate
no_agent (15.679 s) : 15679000, 15679000
.   : milestone, 15679000,
appsec (14.715 s) : 14715000, 14715000
.   : milestone, 14715000,
iast (18.303 s) : 18303000, 18303000
.   : milestone, 18303000,
iast_GLOBAL (17.981 s) : 17981000, 17981000
.   : milestone, 17981000,
profiling (15.379 s) : 15379000, 15379000
.   : milestone, 15379000,
tracing (15.044 s) : 15044000, 15044000
.   : milestone, 15044000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.046 s [15.046 s, 15.046 s]	-
appsec	14.723 s [14.723 s, 14.723 s]	-323.0 ms (-2.1%)
iast	18.003 s [18.003 s, 18.003 s]	2.957 s (19.7%)
iast_GLOBAL	17.989 s [17.989 s, 17.989 s]	2.943 s (19.6%)
profiling	15.093 s [15.093 s, 15.093 s]	47.0 ms (0.3%)
tracing	15.101 s [15.101 s, 15.101 s]	55.0 ms (0.4%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.679 s [15.679 s, 15.679 s]	-
appsec	14.715 s [14.715 s, 14.715 s]	-964.0 ms (-6.1%)
iast	18.303 s [18.303 s, 18.303 s]	2.624 s (16.7%)
iast_GLOBAL	17.981 s [17.981 s, 17.981 s]	2.302 s (14.7%)
profiling	15.379 s [15.379 s, 15.379 s]	-300.0 ms (-1.9%)
tracing	15.044 s [15.044 s, 15.044 s]	-635.0 ms (-4.1%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~460fc410b0, baseline=1.56.0-SNAPSHOT~121136e971
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
.   : milestone, 1470,
appsec (3.632 ms) : 3420, 3845
.   : milestone, 3632,
iast (2.206 ms) : 2142, 2269
.   : milestone, 2206,
iast_GLOBAL (2.243 ms) : 2179, 2307
.   : milestone, 2243,
profiling (2.495 ms) : 2322, 2668
.   : milestone, 2495,
tracing (2.029 ms) : 1979, 2079
.   : milestone, 2029,
section candidate
no_agent (1.468 ms) : 1457, 1480
.   : milestone, 1468,
appsec (3.703 ms) : 3485, 3922
.   : milestone, 3703,
iast (2.203 ms) : 2140, 2267
.   : milestone, 2203,
iast_GLOBAL (2.243 ms) : 2179, 2307
.   : milestone, 2243,
profiling (2.058 ms) : 2006, 2109
.   : milestone, 2058,
tracing (2.021 ms) : 1971, 2071
.   : milestone, 2021,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.459 ms, 1.482 ms]	-
appsec	3.632 ms [3.42 ms, 3.845 ms]	2.162 ms (147.0%)
iast	2.206 ms [2.142 ms, 2.269 ms]	735.252 µs (50.0%)
iast_GLOBAL	2.243 ms [2.179 ms, 2.307 ms]	772.783 µs (52.6%)
profiling	2.495 ms [2.322 ms, 2.668 ms]	1.025 ms (69.7%)
tracing	2.029 ms [1.979 ms, 2.079 ms]	558.448 µs (38.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.468 ms [1.457 ms, 1.48 ms]	-
appsec	3.703 ms [3.485 ms, 3.922 ms]	2.235 ms (152.2%)
iast	2.203 ms [2.14 ms, 2.267 ms]	735.184 µs (50.1%)
iast_GLOBAL	2.243 ms [2.179 ms, 2.307 ms]	774.722 µs (52.8%)
profiling	2.058 ms [2.006 ms, 2.109 ms]	589.348 µs (40.1%)
tracing	2.021 ms [1.971 ms, 2.071 ms]	553.248 µs (37.7%)

bric3

It looks ok to me, but maybe another pair of eye could be useful!

bric3 · 2025-11-17T17:11:26Z

...agent-tooling/src/main/java/datadog/trace/agent/tooling/bytebuddy/memoize/NoMatchFilter.java

+        new DataInputStream(new BufferedInputStream(Files.newInputStream(noMatchFile)))) {
+      while (true) {
+        switch (in.readUTF()) {
+          case "dd-java-agent":


nitpick: Should we use a constant for these strings and in the counter part persist function) ?

bric3 · 2025-11-17T17:14:14Z

...agent-tooling/src/main/java/datadog/trace/agent/tooling/bytebuddy/memoize/NoMatchFilter.java

+        // populate filter from current run and persist at shutdown
+        ClassNameFilter filter = emptyNoMatchFilter();
+        Runtime.getRuntime().addShutdownHook(new ShutdownHook(noMatchFile, filter));
+        return filter;


question: Should (over) writing be toggleable ?

AlexeyKuznetsov-DD

Just curious if it is possible to cover changes with tests?
Or it is 100% identical to previous code and already covered?

mcculls added 3 commits November 15, 2025 19:21

Replace IsPublicFilter with ClassNameFilter

3a1f72d

Replace NoMatchFilter with ClassNameFilter

0826fc5

Remove now unused ClassCodeFilter

9e87923

mcculls added comp: core Tracer core tag: performance Performance related changes type: refactoring labels Nov 15, 2025

mcculls requested a review from a team as a code owner November 15, 2025 19:36

mcculls requested a review from mhlidd November 15, 2025 19:36

Merge branch 'master' into mcculls/faster-class-name-filter

460fc41

bric3 approved these changes Nov 17, 2025

View reviewed changes

AlexeyKuznetsov-DD approved these changes Nov 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use `ClassNameFilter` to track uninteresting classes #9976

Use `ClassNameFilter` to track uninteresting classes #9976

Uh oh!

mcculls commented Nov 15, 2025

Uh oh!

datadog-official bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

bric3 left a comment

Uh oh!

bric3 Nov 17, 2025

Uh oh!

bric3 Nov 17, 2025

Uh oh!

AlexeyKuznetsov-DD left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Use ClassNameFilter to track uninteresting classes #9976

Are you sure you want to change the base?

Use ClassNameFilter to track uninteresting classes #9976

Uh oh!

Conversation

mcculls commented Nov 15, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

bric3 left a comment

Choose a reason for hiding this comment

Uh oh!

bric3 Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

bric3 Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Use `ClassNameFilter` to track uninteresting classes #9976

Use `ClassNameFilter` to track uninteresting classes #9976

datadog-official bot commented Nov 15, 2025 •

edited

Loading

pr-commenter bot commented Nov 15, 2025 •

edited

Loading