-
Notifications
You must be signed in to change notification settings - Fork 317
Refactor jaxws / jaxrs instrumentations #9972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 3b866b2 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~3b866b23b0, baseline=1.56.0-SNAPSHOT~0ba9af0798
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.104 s) : 0, 1104395
Total [baseline] (8.799 s) : 0, 8799307
Agent [candidate] (1.112 s) : 0, 1111856
Total [candidate] (8.885 s) : 0, 8884617
section iast
Agent [baseline] (1.237 s) : 0, 1237438
Total [baseline] (9.54 s) : 0, 9539822
Agent [candidate] (1.246 s) : 0, 1245793
Total [candidate] (9.575 s) : 0, 9574579
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~3b866b23b0, baseline=1.56.0-SNAPSHOT~0ba9af0798
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (710.018 ms) : 0, 710018
BytebuddyAgent [candidate] (714.453 ms) : 0, 714453
GlobalTracer [baseline] (249.529 ms) : 0, 249529
GlobalTracer [candidate] (251.663 ms) : 0, 251663
AppSec [baseline] (32.486 ms) : 0, 32486
AppSec [candidate] (32.765 ms) : 0, 32765
Debugger [baseline] (63.53 ms) : 0, 63530
Debugger [candidate] (63.953 ms) : 0, 63953
Remote Config [baseline] (630.468 µs) : 0, 630
Remote Config [candidate] (638.868 µs) : 0, 639
Telemetry [baseline] (8.095 ms) : 0, 8095
Telemetry [candidate] (8.152 ms) : 0, 8152
Flare Poller [baseline] (3.653 ms) : 0, 3653
Flare Poller [candidate] (3.717 ms) : 0, 3717
section iast
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (829.96 ms) : 0, 829960
BytebuddyAgent [candidate] (835.087 ms) : 0, 835087
GlobalTracer [baseline] (237.83 ms) : 0, 237830
GlobalTracer [candidate] (239.221 ms) : 0, 239221
IAST [baseline] (27.325 ms) : 0, 27325
IAST [candidate] (27.866 ms) : 0, 27866
AppSec [baseline] (33.989 ms) : 0, 33989
AppSec [candidate] (34.492 ms) : 0, 34492
Debugger [baseline] (60.268 ms) : 0, 60268
Debugger [candidate] (60.723 ms) : 0, 60723
Remote Config [baseline] (538.518 µs) : 0, 539
Remote Config [candidate] (552.966 µs) : 0, 553
Telemetry [baseline] (7.716 ms) : 0, 7716
Telemetry [candidate] (7.76 ms) : 0, 7760
Flare Poller [baseline] (3.503 ms) : 0, 3503
Flare Poller [candidate] (3.51 ms) : 0, 3510
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~3b866b23b0, baseline=1.56.0-SNAPSHOT~0ba9af0798
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096213
Total [baseline] (10.791 s) : 0, 10790577
Agent [candidate] (1.096 s) : 0, 1095561
Total [candidate] (10.743 s) : 0, 10743254
section appsec
Agent [baseline] (1.291 s) : 0, 1291357
Total [baseline] (11.053 s) : 0, 11053210
Agent [candidate] (1.276 s) : 0, 1275832
Total [candidate] (11.044 s) : 0, 11044134
section iast
Agent [baseline] (1.235 s) : 0, 1234527
Total [baseline] (11.16 s) : 0, 11160341
Agent [candidate] (1.238 s) : 0, 1237534
Total [candidate] (11.213 s) : 0, 11213377
section profiling
Agent [baseline] (1.241 s) : 0, 1240899
Total [baseline] (11.106 s) : 0, 11105848
Agent [candidate] (1.241 s) : 0, 1240651
Total [candidate] (11.139 s) : 0, 11139432
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~3b866b23b0, baseline=1.56.0-SNAPSHOT~0ba9af0798
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.444 ms) : 0, 1444
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (703.899 ms) : 0, 703899
BytebuddyAgent [candidate] (702.716 ms) : 0, 702716
GlobalTracer [baseline] (247.344 ms) : 0, 247344
GlobalTracer [candidate] (247.814 ms) : 0, 247814
AppSec [baseline] (31.998 ms) : 0, 31998
AppSec [candidate] (32.22 ms) : 0, 32220
Debugger [baseline] (64.362 ms) : 0, 64362
Debugger [candidate] (64.218 ms) : 0, 64218
Remote Config [baseline] (626.046 µs) : 0, 626
Remote Config [candidate] (622.024 µs) : 0, 622
Telemetry [baseline] (8.1 ms) : 0, 8100
Telemetry [candidate] (8.146 ms) : 0, 8146
Flare Poller [baseline] (3.669 ms) : 0, 3669
Flare Poller [candidate] (3.681 ms) : 0, 3681
section appsec
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (737.19 ms) : 0, 737190
BytebuddyAgent [candidate] (727.044 ms) : 0, 727044
GlobalTracer [baseline] (242.45 ms) : 0, 242450
GlobalTracer [candidate] (240.049 ms) : 0, 240049
IAST [baseline] (25.234 ms) : 0, 25234
IAST [candidate] (24.733 ms) : 0, 24733
AppSec [baseline] (175.273 ms) : 0, 175273
AppSec [candidate] (173.906 ms) : 0, 173906
Debugger [baseline] (61.515 ms) : 0, 61515
Debugger [candidate] (61.026 ms) : 0, 61026
Remote Config [baseline] (675.777 µs) : 0, 676
Remote Config [candidate] (739.729 µs) : 0, 740
Telemetry [baseline] (8.371 ms) : 0, 8371
Telemetry [candidate] (8.153 ms) : 0, 8153
Flare Poller [baseline] (3.88 ms) : 0, 3880
Flare Poller [candidate] (3.861 ms) : 0, 3861
section iast
crashtracking [baseline] (1.456 ms) : 0, 1456
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (828.351 ms) : 0, 828351
BytebuddyAgent [candidate] (829.051 ms) : 0, 829051
GlobalTracer [baseline] (237.067 ms) : 0, 237067
GlobalTracer [candidate] (237.67 ms) : 0, 237670
IAST [baseline] (29.699 ms) : 0, 29699
IAST [candidate] (28.616 ms) : 0, 28616
AppSec [baseline] (31.243 ms) : 0, 31243
AppSec [candidate] (33.067 ms) : 0, 33067
Debugger [baseline] (60.391 ms) : 0, 60391
Debugger [candidate] (61.149 ms) : 0, 61149
Remote Config [baseline] (543.37 µs) : 0, 543
Remote Config [candidate] (543.045 µs) : 0, 543
Telemetry [baseline] (7.578 ms) : 0, 7578
Telemetry [candidate] (7.703 ms) : 0, 7703
Flare Poller [baseline] (3.438 ms) : 0, 3438
Flare Poller [candidate] (3.484 ms) : 0, 3484
section profiling
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (737.382 ms) : 0, 737382
BytebuddyAgent [candidate] (740.024 ms) : 0, 740024
GlobalTracer [baseline] (224.171 ms) : 0, 224171
GlobalTracer [candidate] (223.547 ms) : 0, 223547
AppSec [baseline] (32.873 ms) : 0, 32873
AppSec [candidate] (32.632 ms) : 0, 32632
Debugger [baseline] (63.857 ms) : 0, 63857
Debugger [candidate] (63.354 ms) : 0, 63354
Remote Config [baseline] (670.982 µs) : 0, 671
Remote Config [candidate] (648.806 µs) : 0, 649
Telemetry [baseline] (8.071 ms) : 0, 8071
Telemetry [candidate] (8.096 ms) : 0, 8096
Flare Poller [baseline] (3.826 ms) : 0, 3826
Flare Poller [candidate] (3.838 ms) : 0, 3838
ProfilingAgent [baseline] (98.221 ms) : 0, 98221
ProfilingAgent [candidate] (96.728 ms) : 0, 96728
Profiling [baseline] (98.817 ms) : 0, 98817
Profiling [candidate] (97.304 ms) : 0, 97304
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 3 performance regressions! Performance is the same for 15 metrics, 17 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3b866b23b0, baseline=1.56.0-SNAPSHOT~0ba9af0798
dateFormat X
axisFormat %s
section baseline
no_agent (19.404 ms) : 19204, 19605
. : milestone, 19404,
appsec (18.509 ms) : 18324, 18695
. : milestone, 18509,
code_origins (17.635 ms) : 17461, 17809
. : milestone, 17635,
iast (17.577 ms) : 17405, 17748
. : milestone, 17577,
profiling (19.618 ms) : 19418, 19817
. : milestone, 19618,
tracing (17.667 ms) : 17493, 17841
. : milestone, 17667,
section candidate
no_agent (18.356 ms) : 18168, 18545
. : milestone, 18356,
appsec (18.514 ms) : 18323, 18704
. : milestone, 18514,
code_origins (17.678 ms) : 17502, 17853
. : milestone, 17678,
iast (17.587 ms) : 17411, 17763
. : milestone, 17587,
profiling (18.62 ms) : 18433, 18807
. : milestone, 18620,
tracing (17.614 ms) : 17437, 17790
. : milestone, 17614,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~3b866b23b0, baseline=1.56.0-SNAPSHOT~0ba9af0798
dateFormat X
axisFormat %s
section baseline
no_agent (1.199 ms) : 1187, 1211
. : milestone, 1199,
iast (3.193 ms) : 3150, 3236
. : milestone, 3193,
iast_FULL (5.769 ms) : 5711, 5826
. : milestone, 5769,
iast_GLOBAL (3.524 ms) : 3471, 3577
. : milestone, 3524,
profiling (1.928 ms) : 1911, 1945
. : milestone, 1928,
tracing (1.818 ms) : 1802, 1834
. : milestone, 1818,
section candidate
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.296 ms) : 3204, 3388
. : milestone, 3296,
iast_FULL (6.198 ms) : 6133, 6262
. : milestone, 6198,
iast_GLOBAL (3.53 ms) : 3476, 3583
. : milestone, 3530,
profiling (2.427 ms) : 2402, 2452
. : milestone, 2427,
tracing (1.834 ms) : 1818, 1850
. : milestone, 1834,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3b866b23b0, baseline=1.56.0-SNAPSHOT~0ba9af0798
dateFormat X
axisFormat %s
section baseline
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (2.443 ms) : 2392, 2493
. : milestone, 2443,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.241 ms) : 2177, 2304
. : milestone, 2241,
profiling (2.046 ms) : 1995, 2097
. : milestone, 2046,
tracing (2.013 ms) : 1964, 2062
. : milestone, 2013,
section candidate
no_agent (1.473 ms) : 1461, 1485
. : milestone, 1473,
appsec (2.447 ms) : 2396, 2498
. : milestone, 2447,
iast (2.195 ms) : 2132, 2258
. : milestone, 2195,
iast_GLOBAL (2.242 ms) : 2179, 2306
. : milestone, 2242,
profiling (2.056 ms) : 2004, 2108
. : milestone, 2056,
tracing (2.022 ms) : 1972, 2072
. : milestone, 2022,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~3b866b23b0, baseline=1.56.0-SNAPSHOT~0ba9af0798
dateFormat X
axisFormat %s
section baseline
no_agent (15.579 s) : 15579000, 15579000
. : milestone, 15579000,
appsec (14.75 s) : 14750000, 14750000
. : milestone, 14750000,
iast (18.03 s) : 18030000, 18030000
. : milestone, 18030000,
iast_GLOBAL (17.916 s) : 17916000, 17916000
. : milestone, 17916000,
profiling (15.33 s) : 15330000, 15330000
. : milestone, 15330000,
tracing (14.879 s) : 14879000, 14879000
. : milestone, 14879000,
section candidate
no_agent (15.635 s) : 15635000, 15635000
. : milestone, 15635000,
appsec (15.2 s) : 15200000, 15200000
. : milestone, 15200000,
iast (18.271 s) : 18271000, 18271000
. : milestone, 18271000,
iast_GLOBAL (17.948 s) : 17948000, 17948000
. : milestone, 17948000,
profiling (14.726 s) : 14726000, 14726000
. : milestone, 14726000,
tracing (14.828 s) : 14828000, 14828000
. : milestone, 14828000,
|
bf937d4 to
2692ff6
Compare
2692ff6 to
3b866b2
Compare
What Does This Do
Group jaxrs (and jakarta) and jaxws (and jakarta) respectively under
rsandwsuber-modules.Also, group things concerning jersey and resteasy together
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]