-
Notifications
You must be signed in to change notification settings - Fork 317
mark flaky Exception Replay integration test #9970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
ExceptionDebuggerIntegrationTest::test3CapturedRecursiveFrames
967d961 to
e3c7eda
Compare
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~56898bf128, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.105 s) : 0, 1104737
Total [baseline] (8.932 s) : 0, 8931555
Agent [candidate] (1.106 s) : 0, 1105890
Total [candidate] (8.853 s) : 0, 8853308
section iast
Agent [baseline] (1.242 s) : 0, 1241696
Total [baseline] (9.551 s) : 0, 9551277
Agent [candidate] (1.238 s) : 0, 1237574
Total [candidate] (9.549 s) : 0, 9549302
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~56898bf128, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (708.56 ms) : 0, 708560
BytebuddyAgent [candidate] (710.678 ms) : 0, 710678
GlobalTracer [baseline] (249.976 ms) : 0, 249976
GlobalTracer [candidate] (249.898 ms) : 0, 249898
AppSec [baseline] (32.711 ms) : 0, 32711
AppSec [candidate] (32.519 ms) : 0, 32519
Debugger [baseline] (64.339 ms) : 0, 64339
Debugger [candidate] (63.979 ms) : 0, 63979
Remote Config [baseline] (650.071 µs) : 0, 650
Remote Config [candidate] (623.466 µs) : 0, 623
Telemetry [baseline] (8.401 ms) : 0, 8401
Telemetry [candidate] (8.065 ms) : 0, 8065
Flare Poller [baseline] (3.756 ms) : 0, 3756
Flare Poller [candidate] (3.65 ms) : 0, 3650
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.449 ms) : 0, 1449
BytebuddyAgent [baseline] (833.558 ms) : 0, 833558
BytebuddyAgent [candidate] (829.988 ms) : 0, 829988
GlobalTracer [baseline] (238.194 ms) : 0, 238194
GlobalTracer [candidate] (238.316 ms) : 0, 238316
AppSec [baseline] (32.223 ms) : 0, 32223
AppSec [candidate] (34.917 ms) : 0, 34917
Debugger [baseline] (60.15 ms) : 0, 60150
Debugger [candidate] (59.802 ms) : 0, 59802
Remote Config [baseline] (549.869 µs) : 0, 550
Remote Config [candidate] (542.721 µs) : 0, 543
Telemetry [baseline] (7.708 ms) : 0, 7708
Telemetry [candidate] (7.595 ms) : 0, 7595
Flare Poller [baseline] (3.474 ms) : 0, 3474
Flare Poller [candidate] (3.431 ms) : 0, 3431
IAST [baseline] (29.29 ms) : 0, 29290
IAST [candidate] (26.578 ms) : 0, 26578
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~56898bf128, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.096 s) : 0, 1096322
Total [baseline] (10.766 s) : 0, 10765669
Agent [candidate] (1.099 s) : 0, 1098546
Total [candidate] (10.77 s) : 0, 10769789
section appsec
Agent [baseline] (1.288 s) : 0, 1288342
Total [baseline] (11.141 s) : 0, 11141080
Agent [candidate] (1.279 s) : 0, 1278710
Total [candidate] (11.152 s) : 0, 11152485
section iast
Agent [baseline] (1.24 s) : 0, 1239513
Total [baseline] (11.218 s) : 0, 11218167
Agent [candidate] (1.236 s) : 0, 1236199
Total [candidate] (11.273 s) : 0, 11272622
section profiling
Agent [baseline] (1.243 s) : 0, 1242513
Total [baseline] (10.983 s) : 0, 10983336
Agent [candidate] (1.227 s) : 0, 1226724
Total [candidate] (11.017 s) : 0, 11016948
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~56898bf128, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (704.399 ms) : 0, 704399
BytebuddyAgent [candidate] (705.541 ms) : 0, 705541
GlobalTracer [baseline] (247.446 ms) : 0, 247446
GlobalTracer [candidate] (248.167 ms) : 0, 248167
AppSec [baseline] (32.074 ms) : 0, 32074
AppSec [candidate] (32.169 ms) : 0, 32169
Debugger [baseline] (63.802 ms) : 0, 63802
Debugger [candidate] (63.856 ms) : 0, 63856
Remote Config [baseline] (617.11 µs) : 0, 617
Remote Config [candidate] (625.482 µs) : 0, 625
Telemetry [baseline] (8.145 ms) : 0, 8145
Telemetry [candidate] (8.224 ms) : 0, 8224
Flare Poller [baseline] (3.633 ms) : 0, 3633
Flare Poller [candidate] (3.649 ms) : 0, 3649
section appsec
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (735.355 ms) : 0, 735355
BytebuddyAgent [candidate] (729.659 ms) : 0, 729659
GlobalTracer [baseline] (241.803 ms) : 0, 241803
GlobalTracer [candidate] (240.245 ms) : 0, 240245
IAST [baseline] (25.215 ms) : 0, 25215
IAST [candidate] (24.903 ms) : 0, 24903
AppSec [baseline] (174.79 ms) : 0, 174790
AppSec [candidate] (173.862 ms) : 0, 173862
Debugger [baseline] (61.41 ms) : 0, 61410
Debugger [candidate] (60.695 ms) : 0, 60695
Remote Config [baseline] (699.861 µs) : 0, 700
Remote Config [candidate] (675.801 µs) : 0, 676
Telemetry [baseline] (8.369 ms) : 0, 8369
Telemetry [candidate] (8.366 ms) : 0, 8366
Flare Poller [baseline] (3.981 ms) : 0, 3981
Flare Poller [candidate] (3.918 ms) : 0, 3918
section iast
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (830.477 ms) : 0, 830477
BytebuddyAgent [candidate] (827.859 ms) : 0, 827859
GlobalTracer [baseline] (238.226 ms) : 0, 238226
GlobalTracer [candidate] (237.764 ms) : 0, 237764
IAST [baseline] (28.946 ms) : 0, 28946
IAST [candidate] (28.284 ms) : 0, 28284
AppSec [baseline] (32.376 ms) : 0, 32376
AppSec [candidate] (33.021 ms) : 0, 33021
Debugger [baseline] (61.331 ms) : 0, 61331
Debugger [candidate] (61.166 ms) : 0, 61166
Remote Config [baseline] (551.311 µs) : 0, 551
Remote Config [candidate] (551.521 µs) : 0, 552
Telemetry [baseline] (7.763 ms) : 0, 7763
Telemetry [candidate] (7.649 ms) : 0, 7649
Flare Poller [baseline] (3.532 ms) : 0, 3532
Flare Poller [candidate] (3.484 ms) : 0, 3484
section profiling
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (740.671 ms) : 0, 740671
BytebuddyAgent [candidate] (729.651 ms) : 0, 729651
GlobalTracer [baseline] (224.018 ms) : 0, 224018
GlobalTracer [candidate] (221.656 ms) : 0, 221656
AppSec [baseline] (32.634 ms) : 0, 32634
AppSec [candidate] (32.173 ms) : 0, 32173
Debugger [baseline] (63.697 ms) : 0, 63697
Debugger [candidate] (62.52 ms) : 0, 62520
Remote Config [baseline] (656.223 µs) : 0, 656
Remote Config [candidate] (646.808 µs) : 0, 647
Telemetry [baseline] (8.016 ms) : 0, 8016
Telemetry [candidate] (8.03 ms) : 0, 8030
Flare Poller [baseline] (3.853 ms) : 0, 3853
Flare Poller [candidate] (3.749 ms) : 0, 3749
ProfilingAgent [baseline] (96.993 ms) : 0, 96993
ProfilingAgent [candidate] (97.143 ms) : 0, 97143
Profiling [baseline] (97.585 ms) : 0, 97585
Profiling [candidate] (97.722 ms) : 0, 97722
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 17 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~56898bf128, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.203 ms) : 1191, 1214
. : milestone, 1203,
iast (3.288 ms) : 3188, 3387
. : milestone, 3288,
iast_FULL (5.82 ms) : 5761, 5879
. : milestone, 5820,
iast_GLOBAL (3.439 ms) : 3393, 3485
. : milestone, 3439,
profiling (2.003 ms) : 1986, 2021
. : milestone, 2003,
tracing (1.805 ms) : 1790, 1819
. : milestone, 1805,
section candidate
no_agent (1.182 ms) : 1170, 1194
. : milestone, 1182,
iast (3.187 ms) : 3151, 3224
. : milestone, 3187,
iast_FULL (5.662 ms) : 5606, 5717
. : milestone, 5662,
iast_GLOBAL (3.677 ms) : 3627, 3727
. : milestone, 3677,
profiling (1.99 ms) : 1974, 2006
. : milestone, 1990,
tracing (1.811 ms) : 1796, 1826
. : milestone, 1811,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~56898bf128, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (18.4 ms) : 18213, 18586
. : milestone, 18400,
appsec (19.561 ms) : 19361, 19760
. : milestone, 19561,
code_origins (17.638 ms) : 17462, 17814
. : milestone, 17638,
iast (17.646 ms) : 17473, 17818
. : milestone, 17646,
profiling (18.495 ms) : 18307, 18683
. : milestone, 18495,
tracing (17.718 ms) : 17542, 17893
. : milestone, 17718,
section candidate
no_agent (19.454 ms) : 19254, 19654
. : milestone, 19454,
appsec (18.538 ms) : 18352, 18724
. : milestone, 18538,
code_origins (18.083 ms) : 17902, 18263
. : milestone, 18083,
iast (17.786 ms) : 17611, 17962
. : milestone, 17786,
profiling (18.614 ms) : 18423, 18804
. : milestone, 18614,
tracing (17.301 ms) : 17131, 17470
. : milestone, 17301,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~56898bf128, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1468, 1491
. : milestone, 1480,
appsec (3.76 ms) : 3540, 3979
. : milestone, 3760,
iast (2.223 ms) : 2159, 2286
. : milestone, 2223,
iast_GLOBAL (2.267 ms) : 2203, 2330
. : milestone, 2267,
profiling (2.511 ms) : 2348, 2674
. : milestone, 2511,
tracing (2.036 ms) : 1986, 2085
. : milestone, 2036,
section candidate
no_agent (1.487 ms) : 1475, 1499
. : milestone, 1487,
appsec (3.711 ms) : 3491, 3930
. : milestone, 3711,
iast (2.23 ms) : 2167, 2294
. : milestone, 2230,
iast_GLOBAL (2.27 ms) : 2206, 2334
. : milestone, 2270,
profiling (2.085 ms) : 2032, 2138
. : milestone, 2085,
tracing (2.051 ms) : 2001, 2100
. : milestone, 2051,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~56898bf128, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (15.008 s) : 15008000, 15008000
. : milestone, 15008000,
appsec (15.205 s) : 15205000, 15205000
. : milestone, 15205000,
iast (18.645 s) : 18645000, 18645000
. : milestone, 18645000,
iast_GLOBAL (17.96 s) : 17960000, 17960000
. : milestone, 17960000,
profiling (14.95 s) : 14950000, 14950000
. : milestone, 14950000,
tracing (14.596 s) : 14596000, 14596000
. : milestone, 14596000,
section candidate
no_agent (15.478 s) : 15478000, 15478000
. : milestone, 15478000,
appsec (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
iast (18.651 s) : 18651000, 18651000
. : milestone, 18651000,
iast_GLOBAL (17.779 s) : 17779000, 17779000
. : milestone, 17779000,
profiling (14.934 s) : 14934000, 14934000
. : milestone, 14934000,
tracing (14.755 s) : 14755000, 14755000
. : milestone, 14755000,
|
| }); | ||
| } | ||
|
|
||
| @Flaky |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like more tests are flaky:
- test3CapturedFrames,
- test3CapturedRecursiveFrames,
- test5CapturedFrames,
- testLambdaHiddenFrames
- testNoSubsequentCaptureAfterFirst
ExceptionDebuggerIntegrationTest::test3CapturedRecursiveFrames
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]