-
Notifications
You must be signed in to change notification settings - Fork 316
Simplify the default crashtracker message #9964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 45aec39 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~45aec39134, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.098 s) : 0, 1097642
Total [baseline] (8.86 s) : 0, 8860224
Agent [candidate] (1.109 s) : 0, 1108944
Total [candidate] (8.832 s) : 0, 8831963
section iast
Agent [baseline] (1.246 s) : 0, 1246193
Total [baseline] (9.56 s) : 0, 9559762
Agent [candidate] (1.243 s) : 0, 1243071
Total [candidate] (9.548 s) : 0, 9547558
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~45aec39134, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (704.928 ms) : 0, 704928
BytebuddyAgent [candidate] (712.793 ms) : 0, 712793
GlobalTracer [baseline] (248.435 ms) : 0, 248435
GlobalTracer [candidate] (250.601 ms) : 0, 250601
AppSec [baseline] (32.326 ms) : 0, 32326
AppSec [candidate] (32.63 ms) : 0, 32630
Debugger [baseline] (63.231 ms) : 0, 63231
Debugger [candidate] (63.867 ms) : 0, 63867
Remote Config [baseline] (662.224 µs) : 0, 662
Remote Config [candidate] (646.711 µs) : 0, 647
Telemetry [baseline] (8.249 ms) : 0, 8249
Telemetry [candidate] (8.309 ms) : 0, 8309
Flare Poller [baseline] (3.676 ms) : 0, 3676
Flare Poller [candidate] (3.726 ms) : 0, 3726
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (836.022 ms) : 0, 836022
BytebuddyAgent [candidate] (835.741 ms) : 0, 835741
GlobalTracer [baseline] (239.354 ms) : 0, 239354
GlobalTracer [candidate] (237.704 ms) : 0, 237704
AppSec [baseline] (31.8 ms) : 0, 31800
AppSec [candidate] (33.9 ms) : 0, 33900
Debugger [baseline] (60.545 ms) : 0, 60545
Debugger [candidate] (60.347 ms) : 0, 60347
Remote Config [baseline] (555.009 µs) : 0, 555
Remote Config [candidate] (539.632 µs) : 0, 540
Telemetry [baseline] (7.76 ms) : 0, 7760
Telemetry [candidate] (7.667 ms) : 0, 7667
Flare Poller [baseline] (3.476 ms) : 0, 3476
Flare Poller [candidate] (3.433 ms) : 0, 3433
IAST [baseline] (30.266 ms) : 0, 30266
IAST [candidate] (27.414 ms) : 0, 27414
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~45aec39134, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.104 s) : 0, 1104241
Total [baseline] (10.766 s) : 0, 10765540
Agent [candidate] (1.122 s) : 0, 1121553
Total [candidate] (10.865 s) : 0, 10864749
section appsec
Agent [baseline] (1.295 s) : 0, 1294671
Total [baseline] (11.21 s) : 0, 11209651
Agent [candidate] (1.281 s) : 0, 1280532
Total [candidate] (11.003 s) : 0, 11002737
section iast
Agent [baseline] (1.237 s) : 0, 1236656
Total [baseline] (11.271 s) : 0, 11270572
Agent [candidate] (1.239 s) : 0, 1238774
Total [candidate] (11.211 s) : 0, 11211496
section profiling
Agent [baseline] (1.229 s) : 0, 1229364
Total [baseline] (11.04 s) : 0, 11040428
Agent [candidate] (1.229 s) : 0, 1229434
Total [candidate] (11.151 s) : 0, 11150722
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~45aec39134, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (708.211 ms) : 0, 708211
BytebuddyAgent [candidate] (720.933 ms) : 0, 720933
GlobalTracer [baseline] (250.035 ms) : 0, 250035
GlobalTracer [candidate] (253.16 ms) : 0, 253160
AppSec [baseline] (32.498 ms) : 0, 32498
AppSec [candidate] (33.151 ms) : 0, 33151
Debugger [baseline] (64.715 ms) : 0, 64715
Debugger [candidate] (65.078 ms) : 0, 65078
Remote Config [baseline] (646.495 µs) : 0, 646
Remote Config [candidate] (656.837 µs) : 0, 657
Telemetry [baseline] (8.202 ms) : 0, 8202
Telemetry [candidate] (8.228 ms) : 0, 8228
Flare Poller [baseline] (3.658 ms) : 0, 3658
Flare Poller [candidate] (3.723 ms) : 0, 3723
section appsec
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (738.93 ms) : 0, 738930
BytebuddyAgent [candidate] (730.972 ms) : 0, 730972
GlobalTracer [baseline] (243.194 ms) : 0, 243194
GlobalTracer [candidate] (240.986 ms) : 0, 240986
AppSec [baseline] (176.137 ms) : 0, 176137
AppSec [candidate] (174.073 ms) : 0, 174073
Debugger [baseline] (61.504 ms) : 0, 61504
Debugger [candidate] (60.761 ms) : 0, 60761
Remote Config [baseline] (706.861 µs) : 0, 707
Remote Config [candidate] (732.367 µs) : 0, 732
Telemetry [baseline] (8.247 ms) : 0, 8247
Telemetry [candidate] (8.16 ms) : 0, 8160
Flare Poller [baseline] (3.928 ms) : 0, 3928
Flare Poller [candidate] (3.857 ms) : 0, 3857
IAST [baseline] (25.392 ms) : 0, 25392
IAST [candidate] (24.825 ms) : 0, 24825
section iast
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (827.722 ms) : 0, 827722
BytebuddyAgent [candidate] (830.296 ms) : 0, 830296
GlobalTracer [baseline] (238.713 ms) : 0, 238713
GlobalTracer [candidate] (238.578 ms) : 0, 238578
AppSec [baseline] (29.735 ms) : 0, 29735
AppSec [candidate] (30.556 ms) : 0, 30556
Debugger [baseline] (60.772 ms) : 0, 60772
Debugger [candidate] (60.858 ms) : 0, 60858
Remote Config [baseline] (547.85 µs) : 0, 548
Remote Config [candidate] (547.609 µs) : 0, 548
Telemetry [baseline] (7.672 ms) : 0, 7672
Telemetry [candidate] (7.734 ms) : 0, 7734
Flare Poller [baseline] (3.549 ms) : 0, 3549
Flare Poller [candidate] (3.478 ms) : 0, 3478
IAST [baseline] (31.806 ms) : 0, 31806
IAST [candidate] (30.597 ms) : 0, 30597
section profiling
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.441 ms) : 0, 1441
BytebuddyAgent [baseline] (730.605 ms) : 0, 730605
BytebuddyAgent [candidate] (730.544 ms) : 0, 730544
GlobalTracer [baseline] (222.761 ms) : 0, 222761
GlobalTracer [candidate] (223.044 ms) : 0, 223044
AppSec [baseline] (32.085 ms) : 0, 32085
AppSec [candidate] (32.145 ms) : 0, 32145
Debugger [baseline] (62.754 ms) : 0, 62754
Debugger [candidate] (63.222 ms) : 0, 63222
Remote Config [baseline] (649.096 µs) : 0, 649
Remote Config [candidate] (663.677 µs) : 0, 664
Telemetry [baseline] (7.962 ms) : 0, 7962
Telemetry [candidate] (7.87 ms) : 0, 7870
Flare Poller [baseline] (3.789 ms) : 0, 3789
Flare Poller [candidate] (3.723 ms) : 0, 3723
ProfilingAgent [baseline] (97.758 ms) : 0, 97758
ProfilingAgent [candidate] (97.082 ms) : 0, 97082
Profiling [baseline] (98.355 ms) : 0, 98355
Profiling [candidate] (97.668 ms) : 0, 97668
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 0 performance regressions! Performance is the same for 16 metrics, 18 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~45aec39134, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section baseline
no_agent (17.794 ms) : 17610, 17979
. : milestone, 17794,
appsec (18.555 ms) : 18370, 18741
. : milestone, 18555,
code_origins (18.391 ms) : 18206, 18576
. : milestone, 18391,
iast (18.168 ms) : 17987, 18350
. : milestone, 18168,
profiling (18.574 ms) : 18389, 18759
. : milestone, 18574,
tracing (17.543 ms) : 17365, 17720
. : milestone, 17543,
section candidate
no_agent (19.377 ms) : 19174, 19580
. : milestone, 19377,
appsec (18.438 ms) : 18246, 18629
. : milestone, 18438,
code_origins (17.596 ms) : 17419, 17773
. : milestone, 17596,
iast (17.614 ms) : 17436, 17792
. : milestone, 17614,
profiling (18.516 ms) : 18332, 18700
. : milestone, 18516,
tracing (17.597 ms) : 17422, 17773
. : milestone, 17597,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~45aec39134, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section baseline
no_agent (1.192 ms) : 1181, 1204
. : milestone, 1192,
iast (3.279 ms) : 3234, 3325
. : milestone, 3279,
iast_FULL (6.07 ms) : 6009, 6132
. : milestone, 6070,
iast_GLOBAL (3.578 ms) : 3524, 3631
. : milestone, 3578,
profiling (2.097 ms) : 2077, 2117
. : milestone, 2097,
tracing (1.818 ms) : 1803, 1833
. : milestone, 1818,
section candidate
no_agent (1.173 ms) : 1162, 1184
. : milestone, 1173,
iast (3.219 ms) : 3181, 3256
. : milestone, 3219,
iast_FULL (5.962 ms) : 5901, 6023
. : milestone, 5962,
iast_GLOBAL (3.557 ms) : 3503, 3611
. : milestone, 3557,
profiling (1.912 ms) : 1895, 1928
. : milestone, 1912,
tracing (1.842 ms) : 1828, 1857
. : milestone, 1842,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~45aec39134, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1464, 1487
. : milestone, 1475,
appsec (3.596 ms) : 3384, 3808
. : milestone, 3596,
iast (2.208 ms) : 2144, 2271
. : milestone, 2208,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.046 ms) : 1995, 2098
. : milestone, 2046,
tracing (2.02 ms) : 1971, 2070
. : milestone, 2020,
section candidate
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (3.709 ms) : 3491, 3927
. : milestone, 3709,
iast (2.202 ms) : 2139, 2265
. : milestone, 2202,
iast_GLOBAL (2.248 ms) : 2183, 2312
. : milestone, 2248,
profiling (2.072 ms) : 2019, 2125
. : milestone, 2072,
tracing (2.022 ms) : 1973, 2072
. : milestone, 2022,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~45aec39134, baseline=1.56.0-SNAPSHOT~8ceb94de51
dateFormat X
axisFormat %s
section baseline
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (14.755 s) : 14755000, 14755000
. : milestone, 14755000,
iast (17.838 s) : 17838000, 17838000
. : milestone, 17838000,
iast_GLOBAL (17.812 s) : 17812000, 17812000
. : milestone, 17812000,
profiling (14.738 s) : 14738000, 14738000
. : milestone, 14738000,
tracing (14.813 s) : 14813000, 14813000
. : milestone, 14813000,
section candidate
no_agent (15.577 s) : 15577000, 15577000
. : milestone, 15577000,
appsec (14.519 s) : 14519000, 14519000
. : milestone, 14519000,
iast (18.675 s) : 18675000, 18675000
. : milestone, 18675000,
iast_GLOBAL (17.838 s) : 17838000, 17838000
. : milestone, 17838000,
profiling (15.03 s) : 15030000, 15030000
. : milestone, 15030000,
tracing (14.822 s) : 14822000, 14822000
. : milestone, 14822000,
|
What Does This Do
Change the default crashtracker message to
Process terminated by signal {{SIGNAL}}in order to have the same of other tracers. All in all, having the raw stackframes as message is redundant since the same information is present in the structured part of the messageMotivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]