Skip to content

Conversation

@bric3
Copy link
Contributor

@bric3 bric3 commented Nov 13, 2025

What Does This Do

Drop the restrictions on the toolchain lookup features. However maintain the restrictions when running in CI.

This reduce the friction when setting up a new project ; this still requires to have the environment variables when using the testJvm property.

Motivation

In order to allow running on later JDK, we need to drop some constraints on which JDK to look for. This will help in particular

Maybe we can even drive the actual JVM used by gradle with

Additional Notes

A follow-up PR, removes the need to have JAVA_xx_HOME environment variables locally, to use the testJvm feature.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3 bric3 changed the title Drop from env toolchain restriction for local environment Drop fromEnv toolchain restriction for local environment Nov 13, 2025
@bric3 bric3 requested a review from PerfectSlayer November 13, 2025 15:27
@bric3 bric3 marked this pull request as ready for review November 13, 2025 15:30
@bric3 bric3 requested review from a team as code owners November 13, 2025 15:30
@bric3 bric3 requested review from TonyCTHsu and removed request for a team November 13, 2025 15:30
@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Nov 13, 2025
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 thought: ‏Interesting. I should keep a look at it to update the onboarding documentation and setup scripts. Feel free to remind me to update them when you think we are ready to drop the actual requirements.

Comment on lines +174 to +179
- |
cat >> gradle.properties <<'EOF'
org.gradle.java.installations.auto-detect=false
org.gradle.java.installations.auto-download=false
org.gradle.java.installations.fromEnv=JAVA_8_HOME,JAVA_11_HOME,JAVA_17_HOME,JAVA_21_HOME,JAVA_25_HOME
EOF
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AlexeyKuznetsov-DD
Copy link
Contributor

💭 thought: ‏Interesting. I should keep a look at it to update the onboarding documentation and setup scripts. Feel free to remind me to update them when you think we are ready to drop the actual requirements.

I agree on that, we need to update our readme files about fact that we need JAVA_xx_HOME for some tests.

@bric3
Copy link
Contributor Author

bric3 commented Nov 14, 2025

I agree on that, we need to update our readme files about fact that we need JAVA_xx_HOME for some tests.

@AlexeyKuznetsov-DD You're fast :) I was working on this (as you saw). The #9968 is stacked on top of this PR.

I should keep a look at it to update the onboarding documentation and setup scripts. Feel free to remind me to update them when you think we are ready to drop the actual requirements.

I intentionally left this as a left-over as I'd like things to settle down before adapting the onboarding doc. The good thing is that currently it shouldn't require to change on laptop config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants