-
Notifications
You must be signed in to change notification settings - Fork 316
Drop fromEnv toolchain restriction for local environment #9950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…ocal env, but keep them in CI
…ocal env, but keep them in CI
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 thought: Interesting. I should keep a look at it to update the onboarding documentation and setup scripts. Feel free to remind me to update them when you think we are ready to drop the actual requirements.
| - | | ||
| cat >> gradle.properties <<'EOF' | ||
| org.gradle.java.installations.auto-detect=false | ||
| org.gradle.java.installations.auto-download=false | ||
| org.gradle.java.installations.fromEnv=JAVA_8_HOME,JAVA_11_HOME,JAVA_17_HOME,JAVA_21_HOME,JAVA_25_HOME | ||
| EOF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
I agree on that, we need to update our readme files about fact that we need |
@AlexeyKuznetsov-DD You're fast :) I was working on this (as you saw). The #9968 is stacked on top of this PR.
I intentionally left this as a left-over as I'd like things to settle down before adapting the onboarding doc. The good thing is that currently it shouldn't require to change on laptop config. |
What Does This Do
Drop the restrictions on the toolchain lookup features. However maintain the restrictions when running in CI.
This reduce the friction when setting up a new project ; this still requires to have the environment variables when using the
testJvmproperty.Motivation
In order to allow running on later JDK, we need to drop some constraints on which JDK to look for. This will help in particular
Maybe we can even drive the actual JVM used by gradle with
Additional Notes
A follow-up PR, removes the need to have
JAVA_xx_HOMEenvironment variables locally, to use thetestJvmfeature.testJvmconstraint #9968Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]