-
Notifications
You must be signed in to change notification settings - Fork 317
Migrate V1 Config Inversion CI Jobs to V2 CI Jobs #9946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: f9ee58f | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~f9ee58f5e4, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.102 s) : 0, 1102028
Total [baseline] (8.842 s) : 0, 8841874
Agent [candidate] (1.109 s) : 0, 1108569
Total [candidate] (8.844 s) : 0, 8843743
section iast
Agent [baseline] (1.245 s) : 0, 1244612
Total [baseline] (9.545 s) : 0, 9544544
Agent [candidate] (1.237 s) : 0, 1237112
Total [candidate] (9.547 s) : 0, 9546907
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~f9ee58f5e4, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (708.193 ms) : 0, 708193
BytebuddyAgent [candidate] (713.027 ms) : 0, 713027
GlobalTracer [baseline] (249.065 ms) : 0, 249065
GlobalTracer [candidate] (250.295 ms) : 0, 250295
AppSec [baseline] (32.452 ms) : 0, 32452
AppSec [candidate] (32.512 ms) : 0, 32512
Debugger [baseline] (63.408 ms) : 0, 63408
Debugger [candidate] (63.809 ms) : 0, 63809
Remote Config [baseline] (637.419 µs) : 0, 637
Remote Config [candidate] (627.305 µs) : 0, 627
Telemetry [baseline] (8.244 ms) : 0, 8244
Telemetry [candidate] (8.164 ms) : 0, 8164
Flare Poller [baseline] (3.701 ms) : 0, 3701
Flare Poller [candidate] (3.684 ms) : 0, 3684
section iast
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (835.316 ms) : 0, 835316
BytebuddyAgent [candidate] (829.432 ms) : 0, 829432
GlobalTracer [baseline] (238.904 ms) : 0, 238904
GlobalTracer [candidate] (237.901 ms) : 0, 237901
IAST [baseline] (27.816 ms) : 0, 27816
IAST [candidate] (28.272 ms) : 0, 28272
AppSec [baseline] (33.967 ms) : 0, 33967
AppSec [candidate] (33.063 ms) : 0, 33063
Debugger [baseline] (60.418 ms) : 0, 60418
Debugger [candidate] (60.314 ms) : 0, 60314
Remote Config [baseline] (541.912 µs) : 0, 542
Remote Config [candidate] (541.888 µs) : 0, 542
Telemetry [baseline] (7.656 ms) : 0, 7656
Telemetry [candidate] (7.647 ms) : 0, 7647
Flare Poller [baseline] (3.45 ms) : 0, 3450
Flare Poller [candidate] (3.483 ms) : 0, 3483
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~f9ee58f5e4, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.101 s) : 0, 1100683
Total [baseline] (10.81 s) : 0, 10810136
Agent [candidate] (1.107 s) : 0, 1106695
Total [candidate] (10.808 s) : 0, 10807806
section appsec
Agent [baseline] (1.278 s) : 0, 1278216
Total [baseline] (11.073 s) : 0, 11072787
Agent [candidate] (1.291 s) : 0, 1290512
Total [candidate] (10.989 s) : 0, 10989424
section iast
Agent [baseline] (1.239 s) : 0, 1239327
Total [baseline] (11.226 s) : 0, 11226459
Agent [candidate] (1.25 s) : 0, 1250172
Total [candidate] (11.283 s) : 0, 11282776
section profiling
Agent [baseline] (1.228 s) : 0, 1227734
Total [baseline] (10.99 s) : 0, 10989581
Agent [candidate] (1.229 s) : 0, 1228581
Total [candidate] (11.092 s) : 0, 11091552
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~f9ee58f5e4, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.451 ms) : 0, 1451
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (705.857 ms) : 0, 705857
BytebuddyAgent [candidate] (711.388 ms) : 0, 711388
GlobalTracer [baseline] (248.842 ms) : 0, 248842
GlobalTracer [candidate] (249.879 ms) : 0, 249879
AppSec [baseline] (32.362 ms) : 0, 32362
AppSec [candidate] (32.425 ms) : 0, 32425
Debugger [baseline] (64.774 ms) : 0, 64774
Debugger [candidate] (64.088 ms) : 0, 64088
Remote Config [baseline] (627.013 µs) : 0, 627
Remote Config [candidate] (634.585 µs) : 0, 635
Telemetry [baseline] (8.219 ms) : 0, 8219
Telemetry [candidate] (8.175 ms) : 0, 8175
Flare Poller [baseline] (3.691 ms) : 0, 3691
Flare Poller [candidate] (3.686 ms) : 0, 3686
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (729.452 ms) : 0, 729452
BytebuddyAgent [candidate] (735.912 ms) : 0, 735912
GlobalTracer [baseline] (240.069 ms) : 0, 240069
GlobalTracer [candidate] (242.49 ms) : 0, 242490
IAST [baseline] (24.755 ms) : 0, 24755
IAST [candidate] (25.308 ms) : 0, 25308
AppSec [baseline] (173.841 ms) : 0, 173841
AppSec [candidate] (175.794 ms) : 0, 175794
Debugger [baseline] (60.869 ms) : 0, 60869
Debugger [candidate] (61.378 ms) : 0, 61378
Remote Config [baseline] (666.633 µs) : 0, 667
Remote Config [candidate] (675.522 µs) : 0, 676
Telemetry [baseline] (8.358 ms) : 0, 8358
Telemetry [candidate] (8.37 ms) : 0, 8370
Flare Poller [baseline] (3.859 ms) : 0, 3859
Flare Poller [candidate] (3.911 ms) : 0, 3911
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.473 ms) : 0, 1473
BytebuddyAgent [baseline] (830.236 ms) : 0, 830236
BytebuddyAgent [candidate] (840.572 ms) : 0, 840572
GlobalTracer [baseline] (238.433 ms) : 0, 238433
GlobalTracer [candidate] (239.059 ms) : 0, 239059
IAST [baseline] (29.978 ms) : 0, 29978
IAST [candidate] (29.806 ms) : 0, 29806
AppSec [baseline] (31.629 ms) : 0, 31629
AppSec [candidate] (31.188 ms) : 0, 31188
Debugger [baseline] (60.936 ms) : 0, 60936
Debugger [candidate] (61.173 ms) : 0, 61173
Remote Config [baseline] (556.896 µs) : 0, 557
Remote Config [candidate] (549.425 µs) : 0, 549
Telemetry [baseline] (7.686 ms) : 0, 7686
Telemetry [candidate] (7.712 ms) : 0, 7712
Flare Poller [baseline] (3.481 ms) : 0, 3481
Flare Poller [candidate] (3.499 ms) : 0, 3499
section profiling
crashtracking [baseline] (1.433 ms) : 0, 1433
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (729.938 ms) : 0, 729938
BytebuddyAgent [candidate] (730.815 ms) : 0, 730815
GlobalTracer [baseline] (222.276 ms) : 0, 222276
GlobalTracer [candidate] (222.582 ms) : 0, 222582
AppSec [baseline] (32.179 ms) : 0, 32179
AppSec [candidate] (31.965 ms) : 0, 31965
Debugger [baseline] (62.665 ms) : 0, 62665
Debugger [candidate] (62.501 ms) : 0, 62501
Remote Config [baseline] (636.297 µs) : 0, 636
Remote Config [candidate] (641.174 µs) : 0, 641
Telemetry [baseline] (7.93 ms) : 0, 7930
Telemetry [candidate] (7.936 ms) : 0, 7936
Flare Poller [baseline] (3.715 ms) : 0, 3715
Flare Poller [candidate] (3.738 ms) : 0, 3738
ProfilingAgent [baseline] (97.186 ms) : 0, 97186
ProfilingAgent [candidate] (97.097 ms) : 0, 97097
Profiling [baseline] (97.784 ms) : 0, 97784
Profiling [candidate] (97.684 ms) : 0, 97684
LoadParameters
See matching parameters
SummaryFound 5 performance improvements and 1 performance regressions! Performance is the same for 14 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~f9ee58f5e4, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.185 ms) : 1174, 1197
. : milestone, 1185,
iast (3.283 ms) : 3241, 3324
. : milestone, 3283,
iast_FULL (5.988 ms) : 5927, 6048
. : milestone, 5988,
iast_GLOBAL (3.685 ms) : 3620, 3749
. : milestone, 3685,
profiling (2.115 ms) : 2095, 2135
. : milestone, 2115,
tracing (1.991 ms) : 1972, 2011
. : milestone, 1991,
section candidate
no_agent (1.205 ms) : 1193, 1217
. : milestone, 1205,
iast (3.258 ms) : 3215, 3302
. : milestone, 3258,
iast_FULL (5.633 ms) : 5577, 5689
. : milestone, 5633,
iast_GLOBAL (3.741 ms) : 3685, 3796
. : milestone, 3741,
profiling (2.064 ms) : 2046, 2082
. : milestone, 2064,
tracing (1.776 ms) : 1761, 1790
. : milestone, 1776,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~f9ee58f5e4, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (19.303 ms) : 19103, 19504
. : milestone, 19303,
appsec (18.608 ms) : 18417, 18798
. : milestone, 18608,
code_origins (20.026 ms) : 19828, 20225
. : milestone, 20026,
iast (17.697 ms) : 17517, 17877
. : milestone, 17697,
profiling (18.77 ms) : 18581, 18959
. : milestone, 18770,
tracing (17.72 ms) : 17545, 17895
. : milestone, 17720,
section candidate
no_agent (19.514 ms) : 19317, 19711
. : milestone, 19514,
appsec (18.748 ms) : 18560, 18936
. : milestone, 18748,
code_origins (17.547 ms) : 17375, 17719
. : milestone, 17547,
iast (17.712 ms) : 17534, 17889
. : milestone, 17712,
profiling (19.811 ms) : 19611, 20010
. : milestone, 19811,
tracing (17.61 ms) : 17437, 17783
. : milestone, 17610,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~f9ee58f5e4, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (15.014 s) : 15014000, 15014000
. : milestone, 15014000,
appsec (14.613 s) : 14613000, 14613000
. : milestone, 14613000,
iast (18.634 s) : 18634000, 18634000
. : milestone, 18634000,
iast_GLOBAL (17.997 s) : 17997000, 17997000
. : milestone, 17997000,
profiling (15.471 s) : 15471000, 15471000
. : milestone, 15471000,
tracing (14.559 s) : 14559000, 14559000
. : milestone, 14559000,
section candidate
no_agent (14.949 s) : 14949000, 14949000
. : milestone, 14949000,
appsec (14.61 s) : 14610000, 14610000
. : milestone, 14610000,
iast (18.833 s) : 18833000, 18833000
. : milestone, 18833000,
iast_GLOBAL (17.902 s) : 17902000, 17902000
. : milestone, 17902000,
profiling (15.582 s) : 15582000, 15582000
. : milestone, 15582000,
tracing (14.439 s) : 14439000, 14439000
. : milestone, 14439000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~f9ee58f5e4, baseline=1.56.0-SNAPSHOT~b6d4e4fc4a
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1463, 1486
. : milestone, 1474,
appsec (3.714 ms) : 3492, 3937
. : milestone, 3714,
iast (2.208 ms) : 2143, 2272
. : milestone, 2208,
iast_GLOBAL (2.255 ms) : 2190, 2320
. : milestone, 2255,
profiling (2.048 ms) : 1997, 2099
. : milestone, 2048,
tracing (2.018 ms) : 1968, 2068
. : milestone, 2018,
section candidate
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (3.629 ms) : 3415, 3843
. : milestone, 3629,
iast (2.207 ms) : 2143, 2271
. : milestone, 2207,
iast_GLOBAL (2.248 ms) : 2184, 2312
. : milestone, 2248,
profiling (2.075 ms) : 2023, 2128
. : milestone, 2075,
tracing (2.021 ms) : 1972, 2071
. : milestone, 2021,
|
86f796d to
e427da3
Compare
d546122 to
f9ee58f
Compare
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
sarahchen6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for including the relevant links in the description 👍
What Does This Do
Currently, dd-trace-java has CI jobs in place to enforce and update the documentation of configurations in the Feature Parity Dashboard. With the introduction of a v2 format for the local
metadata/supported-configurations.jsonfile, we need to verify additional fields against the FPD. This is done in new CI jobs in libdatadog-build.This PR migrates the CI jobs used in dd-trace-java from the v1 versions to v2 versions. Note that the local
metadata/supported-configurations.jsonfile does not have to be in v2 format in order to use the v2 CI jobs.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]