-
Notifications
You must be signed in to change notification settings - Fork 317
Fix NullPointerException in ApplicationModuleImpl #9879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NullPointerException in ApplicationModuleImpl #9879
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: a7a1623 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 12 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~a7a1623a7b, baseline=1.55.0-SNAPSHOT~949ee8ce67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.039 s) : 0, 1039390
Total [baseline] (10.85 s) : 0, 10850473
Agent [candidate] (1.03 s) : 0, 1029683
Total [candidate] (10.906 s) : 0, 10905539
section appsec
Agent [baseline] (1.212 s) : 0, 1211993
Total [baseline] (10.908 s) : 0, 10908353
Agent [candidate] (1.205 s) : 0, 1204783
Total [candidate] (10.964 s) : 0, 10963766
section iast
Agent [baseline] (1.181 s) : 0, 1180946
Total [baseline] (11.221 s) : 0, 11220887
Agent [candidate] (1.178 s) : 0, 1177522
Total [candidate] (11.251 s) : 0, 11251029
section profiling
Agent [baseline] (1.176 s) : 0, 1176319
Total [baseline] (11.048 s) : 0, 11048362
Agent [candidate] (1.184 s) : 0, 1183737
Total [candidate] (10.938 s) : 0, 10937804
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~a7a1623a7b, baseline=1.55.0-SNAPSHOT~949ee8ce67
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.479 ms) : 0, 1479
BytebuddyAgent [baseline] (708.616 ms) : 0, 708616
BytebuddyAgent [candidate] (701.796 ms) : 0, 701796
GlobalTracer [baseline] (247.047 ms) : 0, 247047
GlobalTracer [candidate] (245.297 ms) : 0, 245297
AppSec [baseline] (32.724 ms) : 0, 32724
AppSec [candidate] (32.209 ms) : 0, 32209
Debugger [baseline] (6.456 ms) : 0, 6456
Debugger [candidate] (6.398 ms) : 0, 6398
Remote Config [baseline] (683.329 µs) : 0, 683
Remote Config [candidate] (673.833 µs) : 0, 674
Telemetry [baseline] (15.317 ms) : 0, 15317
Telemetry [candidate] (13.703 ms) : 0, 13703
Flare Poller [baseline] (5.782 ms) : 0, 5782
Flare Poller [candidate] (7.011 ms) : 0, 7011
section appsec
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (733.048 ms) : 0, 733048
BytebuddyAgent [candidate] (727.307 ms) : 0, 727307
GlobalTracer [baseline] (237.66 ms) : 0, 237660
GlobalTracer [candidate] (236.357 ms) : 0, 236357
AppSec [baseline] (174.395 ms) : 0, 174395
AppSec [candidate] (174.603 ms) : 0, 174603
Debugger [baseline] (5.884 ms) : 0, 5884
Debugger [candidate] (5.981 ms) : 0, 5981
Remote Config [baseline] (626.141 µs) : 0, 626
Remote Config [candidate] (613.908 µs) : 0, 614
Telemetry [baseline] (8.347 ms) : 0, 8347
Telemetry [candidate] (8.449 ms) : 0, 8449
Flare Poller [baseline] (3.928 ms) : 0, 3928
Flare Poller [candidate] (3.958 ms) : 0, 3958
IAST [baseline] (25.239 ms) : 0, 25239
IAST [candidate] (24.975 ms) : 0, 24975
section iast
crashtracking [baseline] (1.495 ms) : 0, 1495
crashtracking [candidate] (1.491 ms) : 0, 1491
BytebuddyAgent [baseline] (839.59 ms) : 0, 839590
BytebuddyAgent [candidate] (836.844 ms) : 0, 836844
GlobalTracer [baseline] (236.841 ms) : 0, 236841
GlobalTracer [candidate] (236.11 ms) : 0, 236110
AppSec [baseline] (28.753 ms) : 0, 28753
AppSec [candidate] (31.467 ms) : 0, 31467
Debugger [baseline] (6.19 ms) : 0, 6190
Debugger [candidate] (6.176 ms) : 0, 6176
Remote Config [baseline] (605.291 µs) : 0, 605
Remote Config [candidate] (601.784 µs) : 0, 602
Telemetry [baseline] (8.469 ms) : 0, 8469
Telemetry [candidate] (8.637 ms) : 0, 8637
Flare Poller [baseline] (4.116 ms) : 0, 4116
Flare Poller [candidate] (4.242 ms) : 0, 4242
IAST [baseline] (33.161 ms) : 0, 33161
IAST [candidate] (30.081 ms) : 0, 30081
section profiling
ProfilingAgent [baseline] (109.691 ms) : 0, 109691
ProfilingAgent [candidate] (110.45 ms) : 0, 110450
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.474 ms) : 0, 1474
BytebuddyAgent [baseline] (728.032 ms) : 0, 728032
BytebuddyAgent [candidate] (732.351 ms) : 0, 732351
GlobalTracer [baseline] (221.384 ms) : 0, 221384
GlobalTracer [candidate] (223.025 ms) : 0, 223025
AppSec [baseline] (32.392 ms) : 0, 32392
AppSec [candidate] (32.525 ms) : 0, 32525
Debugger [baseline] (12.171 ms) : 0, 12171
Debugger [candidate] (12.253 ms) : 0, 12253
Remote Config [baseline] (1.519 ms) : 0, 1519
Remote Config [candidate] (689.559 µs) : 0, 690
Telemetry [baseline] (9.927 ms) : 0, 9927
Telemetry [candidate] (10.653 ms) : 0, 10653
Flare Poller [baseline] (4.121 ms) : 0, 4121
Flare Poller [candidate] (4.163 ms) : 0, 4163
Profiling [baseline] (110.348 ms) : 0, 110348
Profiling [candidate] (111.107 ms) : 0, 111107
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~a7a1623a7b, baseline=1.55.0-SNAPSHOT~949ee8ce67
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.036 s) : 0, 1035593
Total [baseline] (8.691 s) : 0, 8690580
Agent [candidate] (1.037 s) : 0, 1037229
Total [candidate] (8.657 s) : 0, 8657176
section iast
Agent [baseline] (1.178 s) : 0, 1178157
Total [baseline] (9.387 s) : 0, 9386610
Agent [candidate] (1.171 s) : 0, 1170778
Total [candidate] (9.368 s) : 0, 9367944
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~a7a1623a7b, baseline=1.55.0-SNAPSHOT~949ee8ce67
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.486 ms) : 0, 1486
BytebuddyAgent [baseline] (706.33 ms) : 0, 706330
BytebuddyAgent [candidate] (707.409 ms) : 0, 707409
GlobalTracer [baseline] (245.832 ms) : 0, 245832
GlobalTracer [candidate] (246.601 ms) : 0, 246601
AppSec [baseline] (32.497 ms) : 0, 32497
AppSec [candidate] (32.526 ms) : 0, 32526
Debugger [baseline] (6.416 ms) : 0, 6416
Debugger [candidate] (6.447 ms) : 0, 6447
Remote Config [baseline] (690.387 µs) : 0, 690
Remote Config [candidate] (690.407 µs) : 0, 690
Telemetry [baseline] (14.552 ms) : 0, 14552
Telemetry [candidate] (15.092 ms) : 0, 15092
Flare Poller [baseline] (6.513 ms) : 0, 6513
Flare Poller [candidate] (5.72 ms) : 0, 5720
section iast
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (836.963 ms) : 0, 836963
BytebuddyAgent [candidate] (831.48 ms) : 0, 831480
GlobalTracer [baseline] (236.468 ms) : 0, 236468
GlobalTracer [candidate] (235.632 ms) : 0, 235632
AppSec [baseline] (29.067 ms) : 0, 29067
AppSec [candidate] (27.994 ms) : 0, 27994
Debugger [baseline] (6.171 ms) : 0, 6171
Debugger [candidate] (6.09 ms) : 0, 6090
Remote Config [baseline] (609.055 µs) : 0, 609
Remote Config [candidate] (603.853 µs) : 0, 604
Telemetry [baseline] (8.623 ms) : 0, 8623
Telemetry [candidate] (8.425 ms) : 0, 8425
Flare Poller [baseline] (4.178 ms) : 0, 4178
Flare Poller [candidate] (4.115 ms) : 0, 4115
IAST [baseline] (32.968 ms) : 0, 32968
IAST [candidate] (33.502 ms) : 0, 33502
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a7a1623a7b, baseline=1.55.0-SNAPSHOT~949ee8ce67
dateFormat X
axisFormat %s
section baseline
no_agent (1.208 ms) : 1195, 1220
. : milestone, 1208,
iast (3.265 ms) : 3220, 3311
. : milestone, 3265,
iast_FULL (6.074 ms) : 6012, 6136
. : milestone, 6074,
iast_GLOBAL (3.617 ms) : 3567, 3668
. : milestone, 3617,
profiling (1.966 ms) : 1948, 1983
. : milestone, 1966,
tracing (1.804 ms) : 1789, 1820
. : milestone, 1804,
section candidate
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.211 ms) : 3169, 3254
. : milestone, 3211,
iast_FULL (6.07 ms) : 6008, 6132
. : milestone, 6070,
iast_GLOBAL (3.711 ms) : 3645, 3776
. : milestone, 3711,
profiling (1.966 ms) : 1949, 1983
. : milestone, 1966,
tracing (1.792 ms) : 1778, 1806
. : milestone, 1792,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a7a1623a7b, baseline=1.55.0-SNAPSHOT~949ee8ce67
dateFormat X
axisFormat %s
section baseline
no_agent (18.133 ms) : 17946, 18321
. : milestone, 18133,
appsec (20.411 ms) : 20206, 20616
. : milestone, 20411,
code_origins (17.491 ms) : 17316, 17666
. : milestone, 17491,
iast (18.455 ms) : 18270, 18640
. : milestone, 18455,
profiling (19.109 ms) : 18914, 19304
. : milestone, 19109,
tracing (18.611 ms) : 18424, 18798
. : milestone, 18611,
section candidate
no_agent (18.176 ms) : 17987, 18365
. : milestone, 18176,
appsec (19.618 ms) : 19417, 19819
. : milestone, 19618,
code_origins (17.393 ms) : 17222, 17563
. : milestone, 17393,
iast (18.247 ms) : 18062, 18432
. : milestone, 18247,
profiling (19.518 ms) : 19322, 19714
. : milestone, 19518,
tracing (18.376 ms) : 18192, 18559
. : milestone, 18376,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a7a1623a7b, baseline=1.55.0-SNAPSHOT~949ee8ce67
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.494 ms) : 2441, 2547
. : milestone, 2494,
iast (2.2 ms) : 2137, 2263
. : milestone, 2200,
iast_GLOBAL (2.242 ms) : 2178, 2307
. : milestone, 2242,
profiling (2.052 ms) : 2001, 2104
. : milestone, 2052,
tracing (2.035 ms) : 1986, 2085
. : milestone, 2035,
section candidate
no_agent (1.473 ms) : 1462, 1485
. : milestone, 1473,
appsec (3.666 ms) : 3453, 3879
. : milestone, 3666,
iast (2.205 ms) : 2141, 2268
. : milestone, 2205,
iast_GLOBAL (2.247 ms) : 2184, 2311
. : milestone, 2247,
profiling (2.469 ms) : 2308, 2631
. : milestone, 2469,
tracing (2.028 ms) : 1978, 2078
. : milestone, 2028,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a7a1623a7b, baseline=1.55.0-SNAPSHOT~949ee8ce67
dateFormat X
axisFormat %s
section baseline
no_agent (14.817 s) : 14817000, 14817000
. : milestone, 14817000,
appsec (14.963 s) : 14963000, 14963000
. : milestone, 14963000,
iast (18.566 s) : 18566000, 18566000
. : milestone, 18566000,
iast_GLOBAL (17.97 s) : 17970000, 17970000
. : milestone, 17970000,
profiling (15.393 s) : 15393000, 15393000
. : milestone, 15393000,
tracing (15.477 s) : 15477000, 15477000
. : milestone, 15477000,
section candidate
no_agent (15.521 s) : 15521000, 15521000
. : milestone, 15521000,
appsec (14.925 s) : 14925000, 14925000
. : milestone, 14925000,
iast (18.565 s) : 18565000, 18565000
. : milestone, 18565000,
iast_GLOBAL (18.312 s) : 18312000, 18312000
. : milestone, 18312000,
profiling (15.343 s) : 15343000, 15343000
. : milestone, 15343000,
tracing (15.562 s) : 15562000, 15562000
. : milestone, 15562000,
|
What Does This Do
Added a guard in InsecureJspFolderVisitor.preVisitDirectory to keep walking when a directory lacks a name, preventing the previous NullPointerException.
Introduced a regression test that instantiates the visitor and verifies it safely handles the filesystem root path.
Motivation
Error tracking bug detected
Additional Notes
stacktrace
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: APPSEC-59849