-
Notifications
You must be signed in to change notification settings - Fork 318
Fix NullPointerException in ObjectIntrospection #9878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NullPointerException in ObjectIntrospection #9878
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 11 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~24a32547c0, baseline=1.55.0-SNAPSHOT~d86fe5521e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059348
Total [baseline] (11.282 s) : 0, 11282165
Agent [candidate] (1.059 s) : 0, 1058592
Total [candidate] (11.22 s) : 0, 11220377
section appsec
Agent [baseline] (1.235 s) : 0, 1234649
Total [baseline] (11.306 s) : 0, 11305840
Agent [candidate] (1.243 s) : 0, 1243307
Total [candidate] (11.233 s) : 0, 11233159
section iast
Agent [baseline] (1.202 s) : 0, 1201941
Total [baseline] (11.447 s) : 0, 11446969
Agent [candidate] (1.196 s) : 0, 1195629
Total [candidate] (11.52 s) : 0, 11520355
section profiling
Agent [baseline] (1.201 s) : 0, 1200928
Total [baseline] (11.308 s) : 0, 11308318
Agent [candidate] (1.211 s) : 0, 1211163
Total [candidate] (11.404 s) : 0, 11404185
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~24a32547c0, baseline=1.55.0-SNAPSHOT~d86fe5521e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.526 ms) : 0, 1526
crashtracking [candidate] (1.52 ms) : 0, 1520
BytebuddyAgent [baseline] (719.45 ms) : 0, 719450
BytebuddyAgent [candidate] (719.787 ms) : 0, 719787
GlobalTracer [baseline] (254.616 ms) : 0, 254616
GlobalTracer [candidate] (253.351 ms) : 0, 253351
AppSec [baseline] (33.557 ms) : 0, 33557
AppSec [candidate] (33.222 ms) : 0, 33222
Debugger [baseline] (6.759 ms) : 0, 6759
Debugger [candidate] (6.642 ms) : 0, 6642
Remote Config [baseline] (721.004 µs) : 0, 721
Remote Config [candidate] (705.707 µs) : 0, 706
Telemetry [baseline] (16.886 ms) : 0, 16886
Telemetry [candidate] (16.932 ms) : 0, 16932
Flare Poller [baseline] (4.389 ms) : 0, 4389
Flare Poller [candidate] (5.108 ms) : 0, 5108
section appsec
crashtracking [baseline] (1.523 ms) : 0, 1523
crashtracking [candidate] (1.552 ms) : 0, 1552
BytebuddyAgent [baseline] (743.288 ms) : 0, 743288
BytebuddyAgent [candidate] (748.885 ms) : 0, 748885
GlobalTracer [baseline] (243.766 ms) : 0, 243766
GlobalTracer [candidate] (246.267 ms) : 0, 246267
AppSec [baseline] (179.464 ms) : 0, 179464
AppSec [candidate] (179.413 ms) : 0, 179413
Debugger [baseline] (6.04 ms) : 0, 6040
Debugger [candidate] (6.015 ms) : 0, 6015
Remote Config [baseline] (652.077 µs) : 0, 652
Remote Config [candidate] (643.441 µs) : 0, 643
Telemetry [baseline] (8.679 ms) : 0, 8679
Telemetry [candidate] (8.552 ms) : 0, 8552
Flare Poller [baseline] (3.962 ms) : 0, 3962
Flare Poller [candidate] (3.947 ms) : 0, 3947
IAST [baseline] (25.965 ms) : 0, 25965
IAST [candidate] (26.575 ms) : 0, 26575
section iast
crashtracking [baseline] (1.533 ms) : 0, 1533
crashtracking [candidate] (1.521 ms) : 0, 1521
BytebuddyAgent [baseline] (850.371 ms) : 0, 850371
BytebuddyAgent [candidate] (843.678 ms) : 0, 843678
GlobalTracer [baseline] (243.971 ms) : 0, 243971
GlobalTracer [candidate] (244.677 ms) : 0, 244677
AppSec [baseline] (28.047 ms) : 0, 28047
AppSec [candidate] (28.812 ms) : 0, 28812
Debugger [baseline] (6.419 ms) : 0, 6419
Debugger [candidate] (6.48 ms) : 0, 6480
Remote Config [baseline] (635.515 µs) : 0, 636
Remote Config [candidate] (635.909 µs) : 0, 636
Telemetry [baseline] (8.914 ms) : 0, 8914
Telemetry [candidate] (8.875 ms) : 0, 8875
Flare Poller [baseline] (4.077 ms) : 0, 4077
Flare Poller [candidate] (4.134 ms) : 0, 4134
IAST [baseline] (36.3 ms) : 0, 36300
IAST [candidate] (35.242 ms) : 0, 35242
section profiling
crashtracking [baseline] (1.51 ms) : 0, 1510
crashtracking [candidate] (1.524 ms) : 0, 1524
BytebuddyAgent [baseline] (741.951 ms) : 0, 741951
BytebuddyAgent [candidate] (749.302 ms) : 0, 749302
GlobalTracer [baseline] (229.492 ms) : 0, 229492
GlobalTracer [candidate] (231.177 ms) : 0, 231177
AppSec [baseline] (33.278 ms) : 0, 33278
AppSec [candidate] (34.491 ms) : 0, 34491
Debugger [baseline] (14.75 ms) : 0, 14750
Debugger [candidate] (13.227 ms) : 0, 13227
Remote Config [baseline] (740.439 µs) : 0, 740
Remote Config [candidate] (720.155 µs) : 0, 720
Telemetry [baseline] (9.152 ms) : 0, 9152
Telemetry [candidate] (10.276 ms) : 0, 10276
Flare Poller [baseline] (4.275 ms) : 0, 4275
Flare Poller [candidate] (4.272 ms) : 0, 4272
ProfilingAgent [baseline] (109.889 ms) : 0, 109889
ProfilingAgent [candidate] (109.651 ms) : 0, 109651
Profiling [baseline] (110.567 ms) : 0, 110567
Profiling [candidate] (110.295 ms) : 0, 110295
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~24a32547c0, baseline=1.55.0-SNAPSHOT~d86fe5521e
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1056367
Total [baseline] (9.335 s) : 0, 9335064
Agent [candidate] (1.063 s) : 0, 1063187
Total [candidate] (9.294 s) : 0, 9293767
section iast
Agent [baseline] (1.195 s) : 0, 1195094
Total [baseline] (9.901 s) : 0, 9901335
Agent [candidate] (1.191 s) : 0, 1191493
Total [candidate] (9.898 s) : 0, 9897619
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~24a32547c0, baseline=1.55.0-SNAPSHOT~d86fe5521e
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.536 ms) : 0, 1536
crashtracking [candidate] (1.536 ms) : 0, 1536
BytebuddyAgent [baseline] (718.289 ms) : 0, 718289
BytebuddyAgent [candidate] (722.751 ms) : 0, 722751
GlobalTracer [baseline] (252.486 ms) : 0, 252486
GlobalTracer [candidate] (254.398 ms) : 0, 254398
AppSec [baseline] (33.235 ms) : 0, 33235
AppSec [candidate] (33.521 ms) : 0, 33521
Debugger [baseline] (6.643 ms) : 0, 6643
Debugger [candidate] (6.705 ms) : 0, 6705
Remote Config [baseline] (726.075 µs) : 0, 726
Remote Config [candidate] (715.358 µs) : 0, 715
Telemetry [baseline] (16.946 ms) : 0, 16946
Telemetry [candidate] (15.987 ms) : 0, 15987
Flare Poller [baseline] (5.135 ms) : 0, 5135
Flare Poller [candidate] (6.065 ms) : 0, 6065
section iast
crashtracking [baseline] (1.529 ms) : 0, 1529
crashtracking [candidate] (1.522 ms) : 0, 1522
BytebuddyAgent [baseline] (844.156 ms) : 0, 844156
BytebuddyAgent [candidate] (841.193 ms) : 0, 841193
GlobalTracer [baseline] (243.834 ms) : 0, 243834
GlobalTracer [candidate] (243.384 ms) : 0, 243384
AppSec [baseline] (29.845 ms) : 0, 29845
AppSec [candidate] (28.838 ms) : 0, 28838
Debugger [baseline] (6.432 ms) : 0, 6432
Debugger [candidate] (6.445 ms) : 0, 6445
Remote Config [baseline] (638.377 µs) : 0, 638
Remote Config [candidate] (643.426 µs) : 0, 643
Telemetry [baseline] (8.841 ms) : 0, 8841
Telemetry [candidate] (8.868 ms) : 0, 8868
Flare Poller [baseline] (4.105 ms) : 0, 4105
Flare Poller [candidate] (4.088 ms) : 0, 4088
IAST [baseline] (34.169 ms) : 0, 34169
IAST [candidate] (34.961 ms) : 0, 34961
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 1 performance regressions! Performance is the same for 11 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~24a32547c0, baseline=1.55.0-SNAPSHOT~d86fe5521e
dateFormat X
axisFormat %s
section baseline
no_agent (1.203 ms) : 1191, 1215
. : milestone, 1203,
iast (3.251 ms) : 3210, 3292
. : milestone, 3251,
iast_FULL (5.786 ms) : 5730, 5843
. : milestone, 5786,
iast_GLOBAL (3.685 ms) : 3631, 3739
. : milestone, 3685,
profiling (2.026 ms) : 2008, 2044
. : milestone, 2026,
tracing (1.775 ms) : 1760, 1790
. : milestone, 1775,
section candidate
no_agent (1.201 ms) : 1189, 1213
. : milestone, 1201,
iast (3.203 ms) : 3160, 3247
. : milestone, 3203,
iast_FULL (5.786 ms) : 5728, 5843
. : milestone, 5786,
iast_GLOBAL (3.614 ms) : 3553, 3675
. : milestone, 3614,
profiling (2.064 ms) : 2045, 2082
. : milestone, 2064,
tracing (1.782 ms) : 1767, 1796
. : milestone, 1782,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~24a32547c0, baseline=1.55.0-SNAPSHOT~d86fe5521e
dateFormat X
axisFormat %s
section baseline
no_agent (18.676 ms) : 18487, 18864
. : milestone, 18676,
appsec (20.551 ms) : 20337, 20764
. : milestone, 20551,
code_origins (18.569 ms) : 18379, 18759
. : milestone, 18569,
iast (18.307 ms) : 18121, 18494
. : milestone, 18307,
profiling (20.406 ms) : 20204, 20609
. : milestone, 20406,
tracing (19.262 ms) : 19071, 19453
. : milestone, 19262,
section candidate
no_agent (19.646 ms) : 19445, 19847
. : milestone, 19646,
appsec (20.783 ms) : 20573, 20993
. : milestone, 20783,
code_origins (18.68 ms) : 18493, 18866
. : milestone, 18680,
iast (18.277 ms) : 18093, 18461
. : milestone, 18277,
profiling (20.357 ms) : 20153, 20561
. : milestone, 20357,
tracing (19.527 ms) : 19332, 19723
. : milestone, 19527,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~24a32547c0, baseline=1.55.0-SNAPSHOT~d86fe5521e
dateFormat X
axisFormat %s
section baseline
no_agent (15.655 s) : 15655000, 15655000
. : milestone, 15655000,
appsec (15.233 s) : 15233000, 15233000
. : milestone, 15233000,
iast (18.896 s) : 18896000, 18896000
. : milestone, 18896000,
iast_GLOBAL (17.875 s) : 17875000, 17875000
. : milestone, 17875000,
profiling (15.719 s) : 15719000, 15719000
. : milestone, 15719000,
tracing (15.103 s) : 15103000, 15103000
. : milestone, 15103000,
section candidate
no_agent (15.015 s) : 15015000, 15015000
. : milestone, 15015000,
appsec (14.876 s) : 14876000, 14876000
. : milestone, 14876000,
iast (18.406 s) : 18406000, 18406000
. : milestone, 18406000,
iast_GLOBAL (18.382 s) : 18382000, 18382000
. : milestone, 18382000,
profiling (15.247 s) : 15247000, 15247000
. : milestone, 15247000,
tracing (15.301 s) : 15301000, 15301000
. : milestone, 15301000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~24a32547c0, baseline=1.55.0-SNAPSHOT~d86fe5521e
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.726 ms) : 3510, 3942
. : milestone, 3726,
iast (2.217 ms) : 2153, 2281
. : milestone, 2217,
iast_GLOBAL (2.261 ms) : 2196, 2325
. : milestone, 2261,
profiling (2.091 ms) : 2038, 2145
. : milestone, 2091,
tracing (2.042 ms) : 1993, 2091
. : milestone, 2042,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.723 ms) : 3505, 3941
. : milestone, 3723,
iast (2.235 ms) : 2171, 2299
. : milestone, 2235,
iast_GLOBAL (2.271 ms) : 2206, 2335
. : milestone, 2271,
profiling (2.075 ms) : 2024, 2127
. : milestone, 2075,
tracing (2.036 ms) : 1986, 2086
. : milestone, 2036,
|
|
🎯 Code Coverage 🔗 Commit SHA: 24a3254 | Docs | Datadog PR Page | Was this helpful? Give us feedback! |
What Does This Do
Added a null guard in ObjectIntrospection.checkStringLength so Jackson string values that resolve to null no longer trigger a NullPointerException during AppSec object conversion
Motivation
Error Tracking report
Additional Notes
stacktrace
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [APPSEC-59848]