-
Notifications
You must be signed in to change notification settings - Fork 318
Ensure blocking exceptions are propagated for SSRF #9790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure blocking exceptions are propagated for SSRF #9790
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: fbf00b3 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~fbf00b38b5, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019084
Total [baseline] (10.708 s) : 0, 10707560
Agent [candidate] (1.018 s) : 0, 1017859
Total [candidate] (10.795 s) : 0, 10795079
section appsec
Agent [baseline] (1.194 s) : 0, 1194338
Total [baseline] (10.782 s) : 0, 10781650
Agent [candidate] (1.203 s) : 0, 1203003
Total [candidate] (10.874 s) : 0, 10873781
section iast
Agent [baseline] (1.152 s) : 0, 1151701
Total [baseline] (11.109 s) : 0, 11109342
Agent [candidate] (1.148 s) : 0, 1148003
Total [candidate] (11.141 s) : 0, 11140857
section profiling
Agent [baseline] (1.162 s) : 0, 1162359
Total [baseline] (10.925 s) : 0, 10924813
Agent [candidate] (1.163 s) : 0, 1163109
Total [candidate] (10.922 s) : 0, 10922413
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~fbf00b38b5, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.473 ms) : 0, 1473
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (693.278 ms) : 0, 693278
BytebuddyAgent [candidate] (693.085 ms) : 0, 693085
GlobalTracer [baseline] (243.031 ms) : 0, 243031
GlobalTracer [candidate] (242.95 ms) : 0, 242950
AppSec [baseline] (32.641 ms) : 0, 32641
AppSec [candidate] (32.503 ms) : 0, 32503
Debugger [baseline] (6.411 ms) : 0, 6411
Debugger [candidate] (6.394 ms) : 0, 6394
Remote Config [baseline] (686.644 µs) : 0, 687
Remote Config [candidate] (677.353 µs) : 0, 677
Telemetry [baseline] (9.481 ms) : 0, 9481
Telemetry [candidate] (9.511 ms) : 0, 9511
Flare Poller [baseline] (10.798 ms) : 0, 10798
Flare Poller [candidate] (10.12 ms) : 0, 10120
section appsec
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (717.312 ms) : 0, 717312
BytebuddyAgent [candidate] (722.646 ms) : 0, 722646
GlobalTracer [baseline] (235.425 ms) : 0, 235425
GlobalTracer [candidate] (237.151 ms) : 0, 237151
IAST [baseline] (24.85 ms) : 0, 24850
IAST [candidate] (25.046 ms) : 0, 25046
AppSec [baseline] (175.075 ms) : 0, 175075
AppSec [candidate] (175.888 ms) : 0, 175888
Debugger [baseline] (6.001 ms) : 0, 6001
Debugger [candidate] (6.195 ms) : 0, 6195
Remote Config [baseline] (630.984 µs) : 0, 631
Remote Config [candidate] (643.877 µs) : 0, 644
Telemetry [baseline] (8.542 ms) : 0, 8542
Telemetry [candidate] (8.641 ms) : 0, 8641
Flare Poller [baseline] (3.908 ms) : 0, 3908
Flare Poller [candidate] (4.034 ms) : 0, 4034
section iast
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (814.643 ms) : 0, 814643
BytebuddyAgent [candidate] (812.417 ms) : 0, 812417
GlobalTracer [baseline] (232.672 ms) : 0, 232672
GlobalTracer [candidate] (231.559 ms) : 0, 231559
IAST [baseline] (26.455 ms) : 0, 26455
IAST [candidate] (26.4 ms) : 0, 26400
AppSec [baseline] (35.19 ms) : 0, 35190
AppSec [candidate] (35.1 ms) : 0, 35100
Debugger [baseline] (6.169 ms) : 0, 6169
Debugger [candidate] (6.138 ms) : 0, 6138
Remote Config [baseline] (606.666 µs) : 0, 607
Remote Config [candidate] (591.119 µs) : 0, 591
Telemetry [baseline] (8.771 ms) : 0, 8771
Telemetry [candidate] (8.581 ms) : 0, 8581
Flare Poller [baseline] (4.145 ms) : 0, 4145
Flare Poller [candidate] (4.258 ms) : 0, 4258
section profiling
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (720.201 ms) : 0, 720201
BytebuddyAgent [candidate] (720.281 ms) : 0, 720281
GlobalTracer [baseline] (219.234 ms) : 0, 219234
GlobalTracer [candidate] (218.572 ms) : 0, 218572
AppSec [baseline] (32.276 ms) : 0, 32276
AppSec [candidate] (32.341 ms) : 0, 32341
Debugger [baseline] (6.678 ms) : 0, 6678
Debugger [candidate] (7.513 ms) : 0, 7513
Remote Config [baseline] (709.288 µs) : 0, 709
Remote Config [candidate] (705.232 µs) : 0, 705
Telemetry [baseline] (15.87 ms) : 0, 15870
Telemetry [candidate] (15.407 ms) : 0, 15407
Flare Poller [baseline] (4.159 ms) : 0, 4159
Flare Poller [candidate] (4.111 ms) : 0, 4111
ProfilingAgent [baseline] (108.365 ms) : 0, 108365
ProfilingAgent [candidate] (109.43 ms) : 0, 109430
Profiling [baseline] (109.651 ms) : 0, 109651
Profiling [candidate] (110.614 ms) : 0, 110614
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~fbf00b38b5, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025797
Total [baseline] (8.691 s) : 0, 8691268
Agent [candidate] (1.025 s) : 0, 1024652
Total [candidate] (8.699 s) : 0, 8699384
section iast
Agent [baseline] (1.153 s) : 0, 1153192
Total [baseline] (9.318 s) : 0, 9318371
Agent [candidate] (1.154 s) : 0, 1153578
Total [candidate] (9.319 s) : 0, 9319159
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~fbf00b38b5, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (697.945 ms) : 0, 697945
BytebuddyAgent [candidate] (697.431 ms) : 0, 697431
GlobalTracer [baseline] (244.156 ms) : 0, 244156
GlobalTracer [candidate] (244.7 ms) : 0, 244700
AppSec [baseline] (32.375 ms) : 0, 32375
AppSec [candidate] (32.965 ms) : 0, 32965
Debugger [baseline] (6.446 ms) : 0, 6446
Debugger [candidate] (6.518 ms) : 0, 6518
Remote Config [baseline] (688.768 µs) : 0, 689
Remote Config [candidate] (690.506 µs) : 0, 691
Telemetry [baseline] (9.523 ms) : 0, 9523
Telemetry [candidate] (9.531 ms) : 0, 9531
Flare Poller [baseline] (11.872 ms) : 0, 11872
Flare Poller [candidate] (10.154 ms) : 0, 10154
section iast
crashtracking [baseline] (1.502 ms) : 0, 1502
crashtracking [candidate] (1.497 ms) : 0, 1497
BytebuddyAgent [baseline] (816.196 ms) : 0, 816196
BytebuddyAgent [candidate] (816.143 ms) : 0, 816143
GlobalTracer [baseline] (232.555 ms) : 0, 232555
GlobalTracer [candidate] (232.918 ms) : 0, 232918
IAST [baseline] (26.618 ms) : 0, 26618
IAST [candidate] (26.607 ms) : 0, 26607
AppSec [baseline] (35.181 ms) : 0, 35181
AppSec [candidate] (35.063 ms) : 0, 35063
Debugger [baseline] (6.175 ms) : 0, 6175
Debugger [candidate] (6.202 ms) : 0, 6202
Remote Config [baseline] (607.989 µs) : 0, 608
Remote Config [candidate] (615.347 µs) : 0, 615
Telemetry [baseline] (8.669 ms) : 0, 8669
Telemetry [candidate] (8.721 ms) : 0, 8721
Flare Poller [baseline] (4.208 ms) : 0, 4208
Flare Poller [candidate] (4.309 ms) : 0, 4309
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~fbf00b38b5, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section baseline
no_agent (4.158 ms) : 4109, 4208
. : milestone, 4158,
iast (9.877 ms) : 9701, 10054
. : milestone, 9877,
iast_FULL (15.176 ms) : 14877, 15475
. : milestone, 15176,
iast_GLOBAL (10.58 ms) : 10389, 10771
. : milestone, 10580,
profiling (9.094 ms) : 8951, 9236
. : milestone, 9094,
tracing (7.684 ms) : 7574, 7794
. : milestone, 7684,
section candidate
no_agent (4.21 ms) : 4159, 4262
. : milestone, 4210,
iast (10.148 ms) : 9972, 10325
. : milestone, 10148,
iast_FULL (14.488 ms) : 14193, 14784
. : milestone, 14488,
iast_GLOBAL (10.273 ms) : 10090, 10456
. : milestone, 10273,
profiling (8.785 ms) : 8635, 8935
. : milestone, 8785,
tracing (7.968 ms) : 7852, 8083
. : milestone, 7968,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~fbf00b38b5, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section baseline
no_agent (37.256 ms) : 36951, 37561
. : milestone, 37256,
appsec (47.637 ms) : 47219, 48055
. : milestone, 47637,
code_origins (42.944 ms) : 42570, 43317
. : milestone, 42944,
iast (46.155 ms) : 45747, 46564
. : milestone, 46155,
profiling (47.626 ms) : 47179, 48074
. : milestone, 47626,
tracing (43.833 ms) : 43446, 44219
. : milestone, 43833,
section candidate
no_agent (35.491 ms) : 35213, 35770
. : milestone, 35491,
appsec (48.809 ms) : 48384, 49234
. : milestone, 48809,
code_origins (44.235 ms) : 43869, 44601
. : milestone, 44235,
iast (45.126 ms) : 44739, 45512
. : milestone, 45126,
profiling (49.26 ms) : 48760, 49759
. : milestone, 49260,
tracing (44.181 ms) : 43805, 44557
. : milestone, 44181,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~fbf00b38b5, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.642 ms) : 3428, 3857
. : milestone, 3642,
iast (2.212 ms) : 2148, 2275
. : milestone, 2212,
iast_GLOBAL (2.249 ms) : 2185, 2313
. : milestone, 2249,
profiling (2.053 ms) : 2002, 2105
. : milestone, 2053,
tracing (2.024 ms) : 1975, 2073
. : milestone, 2024,
section candidate
no_agent (1.476 ms) : 1464, 1487
. : milestone, 1476,
appsec (3.719 ms) : 3500, 3937
. : milestone, 3719,
iast (2.208 ms) : 2144, 2272
. : milestone, 2208,
iast_GLOBAL (2.254 ms) : 2190, 2318
. : milestone, 2254,
profiling (2.066 ms) : 2013, 2118
. : milestone, 2066,
tracing (2.021 ms) : 1972, 2071
. : milestone, 2021,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~fbf00b38b5, baseline=1.55.0-SNAPSHOT~664b9a412c
dateFormat X
axisFormat %s
section baseline
no_agent (15.588 s) : 15588000, 15588000
. : milestone, 15588000,
appsec (15.026 s) : 15026000, 15026000
. : milestone, 15026000,
iast (18.8 s) : 18800000, 18800000
. : milestone, 18800000,
iast_GLOBAL (18.046 s) : 18046000, 18046000
. : milestone, 18046000,
profiling (15.407 s) : 15407000, 15407000
. : milestone, 15407000,
tracing (15.102 s) : 15102000, 15102000
. : milestone, 15102000,
section candidate
no_agent (15.28 s) : 15280000, 15280000
. : milestone, 15280000,
appsec (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
iast (18.54 s) : 18540000, 18540000
. : milestone, 18540000,
iast_GLOBAL (17.938 s) : 17938000, 17938000
. : milestone, 17938000,
profiling (15.867 s) : 15867000, 15867000
. : milestone, 15867000,
tracing (15.197 s) : 15197000, 15197000
. : milestone, 15197000,
|
jandro996
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
What Does This Do
Ensures that blocking exceptions are properly propagated when testing RASP protections against SSRF attacks.
Motivation
If the exception isn’t propagated, execution continues and the attack may succeed, even if the response is eventually blocked.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]