-
Notifications
You must be signed in to change notification settings - Fork 317
Clean up JMXFetch job on thread interrupt #9788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: e2667ff | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~e2667ffe90, baseline=1.55.0-SNAPSHOT~4ddf06e364
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019535
Total [baseline] (10.689 s) : 0, 10689444
Agent [candidate] (1.019 s) : 0, 1018713
Total [candidate] (10.733 s) : 0, 10733318
section appsec
Agent [baseline] (1.195 s) : 0, 1194750
Total [baseline] (10.832 s) : 0, 10831979
Agent [candidate] (1.197 s) : 0, 1196771
Total [candidate] (10.829 s) : 0, 10828964
section iast
Agent [baseline] (1.164 s) : 0, 1163633
Total [baseline] (11.174 s) : 0, 11173603
Agent [candidate] (1.16 s) : 0, 1160422
Total [candidate] (11.175 s) : 0, 11174535
section profiling
Agent [baseline] (1.17 s) : 0, 1170117
Total [baseline] (10.894 s) : 0, 10894382
Agent [candidate] (1.162 s) : 0, 1162034
Total [candidate] (10.841 s) : 0, 10841115
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~e2667ffe90, baseline=1.55.0-SNAPSHOT~4ddf06e364
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (694.266 ms) : 0, 694266
BytebuddyAgent [candidate] (693.174 ms) : 0, 693174
GlobalTracer [baseline] (242.734 ms) : 0, 242734
GlobalTracer [candidate] (243.263 ms) : 0, 243263
AppSec [baseline] (32.496 ms) : 0, 32496
AppSec [candidate] (32.604 ms) : 0, 32604
Debugger [baseline] (6.41 ms) : 0, 6410
Debugger [candidate] (6.441 ms) : 0, 6441
Remote Config [baseline] (730.287 µs) : 0, 730
Remote Config [candidate] (677.447 µs) : 0, 677
Telemetry [baseline] (9.417 ms) : 0, 9417
Telemetry [candidate] (9.562 ms) : 0, 9562
Flare Poller [baseline] (10.778 ms) : 0, 10778
Flare Poller [candidate] (10.296 ms) : 0, 10296
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (717.135 ms) : 0, 717135
BytebuddyAgent [candidate] (718.969 ms) : 0, 718969
GlobalTracer [baseline] (235.306 ms) : 0, 235306
GlobalTracer [candidate] (235.833 ms) : 0, 235833
IAST [baseline] (24.921 ms) : 0, 24921
IAST [candidate] (24.962 ms) : 0, 24962
AppSec [baseline] (175.569 ms) : 0, 175569
AppSec [candidate] (175.096 ms) : 0, 175096
Debugger [baseline] (6.116 ms) : 0, 6116
Debugger [candidate] (6.079 ms) : 0, 6079
Remote Config [baseline] (635.3 µs) : 0, 635
Remote Config [candidate] (634.872 µs) : 0, 635
Telemetry [baseline] (8.584 ms) : 0, 8584
Telemetry [candidate] (8.574 ms) : 0, 8574
Flare Poller [baseline] (3.917 ms) : 0, 3917
Flare Poller [candidate] (3.948 ms) : 0, 3948
section iast
crashtracking [baseline] (1.492 ms) : 0, 1492
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (823.841 ms) : 0, 823841
BytebuddyAgent [candidate] (821.286 ms) : 0, 821286
GlobalTracer [baseline] (234.393 ms) : 0, 234393
GlobalTracer [candidate] (233.84 ms) : 0, 233840
IAST [baseline] (26.83 ms) : 0, 26830
IAST [candidate] (26.747 ms) : 0, 26747
AppSec [baseline] (35.423 ms) : 0, 35423
AppSec [candidate] (35.424 ms) : 0, 35424
Debugger [baseline] (6.274 ms) : 0, 6274
Debugger [candidate] (6.249 ms) : 0, 6249
Remote Config [baseline] (609.214 µs) : 0, 609
Remote Config [candidate] (605.928 µs) : 0, 606
Telemetry [baseline] (8.832 ms) : 0, 8832
Telemetry [candidate] (8.827 ms) : 0, 8827
Flare Poller [baseline] (4.249 ms) : 0, 4249
Flare Poller [candidate] (4.26 ms) : 0, 4260
section profiling
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (726.004 ms) : 0, 726004
BytebuddyAgent [candidate] (720.455 ms) : 0, 720455
GlobalTracer [baseline] (220.205 ms) : 0, 220205
GlobalTracer [candidate] (218.731 ms) : 0, 218731
AppSec [baseline] (32.81 ms) : 0, 32810
AppSec [candidate] (32.208 ms) : 0, 32208
Debugger [baseline] (8.274 ms) : 0, 8274
Debugger [candidate] (7.465 ms) : 0, 7465
Remote Config [baseline] (723.871 µs) : 0, 724
Remote Config [candidate] (699.574 µs) : 0, 700
Telemetry [baseline] (14.4 ms) : 0, 14400
Telemetry [candidate] (15.054 ms) : 0, 15054
Flare Poller [baseline] (4.18 ms) : 0, 4180
Flare Poller [candidate] (4.064 ms) : 0, 4064
ProfilingAgent [baseline] (107.998 ms) : 0, 107998
ProfilingAgent [candidate] (107.779 ms) : 0, 107779
Profiling [baseline] (109.535 ms) : 0, 109535
Profiling [candidate] (109.762 ms) : 0, 109762
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~e2667ffe90, baseline=1.55.0-SNAPSHOT~4ddf06e364
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.037 s) : 0, 1036797
Total [baseline] (8.744 s) : 0, 8743703
Agent [candidate] (1.024 s) : 0, 1024468
Total [candidate] (8.681 s) : 0, 8681196
section iast
Agent [baseline] (1.153 s) : 0, 1152620
Total [baseline] (9.345 s) : 0, 9344586
Agent [candidate] (1.149 s) : 0, 1148958
Total [candidate] (9.29 s) : 0, 9289743
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~e2667ffe90, baseline=1.55.0-SNAPSHOT~4ddf06e364
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.498 ms) : 0, 1498
crashtracking [candidate] (1.484 ms) : 0, 1484
BytebuddyAgent [baseline] (705.279 ms) : 0, 705279
BytebuddyAgent [candidate] (698.087 ms) : 0, 698087
GlobalTracer [baseline] (247.039 ms) : 0, 247039
GlobalTracer [candidate] (242.963 ms) : 0, 242963
AppSec [baseline] (33.464 ms) : 0, 33464
AppSec [candidate] (32.564 ms) : 0, 32564
Debugger [baseline] (6.645 ms) : 0, 6645
Debugger [candidate] (6.41 ms) : 0, 6410
Remote Config [baseline] (702.453 µs) : 0, 702
Remote Config [candidate] (677.572 µs) : 0, 678
Telemetry [baseline] (9.587 ms) : 0, 9587
Telemetry [candidate] (9.492 ms) : 0, 9492
Flare Poller [baseline] (11.134 ms) : 0, 11134
Flare Poller [candidate] (11.518 ms) : 0, 11518
section iast
crashtracking [baseline] (1.496 ms) : 0, 1496
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (815.356 ms) : 0, 815356
BytebuddyAgent [candidate] (813.316 ms) : 0, 813316
GlobalTracer [baseline] (232.575 ms) : 0, 232575
GlobalTracer [candidate] (231.808 ms) : 0, 231808
IAST [baseline] (26.529 ms) : 0, 26529
IAST [candidate] (26.345 ms) : 0, 26345
AppSec [baseline] (35.23 ms) : 0, 35230
AppSec [candidate] (35.05 ms) : 0, 35050
Debugger [baseline] (6.235 ms) : 0, 6235
Debugger [candidate] (6.167 ms) : 0, 6167
Remote Config [baseline] (617.76 µs) : 0, 618
Remote Config [candidate] (593.147 µs) : 0, 593
Telemetry [baseline] (8.739 ms) : 0, 8739
Telemetry [candidate] (8.581 ms) : 0, 8581
Flare Poller [baseline] (4.283 ms) : 0, 4283
Flare Poller [candidate] (4.184 ms) : 0, 4184
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e2667ffe90, baseline=1.55.0-SNAPSHOT~4ddf06e364
dateFormat X
axisFormat %s
section baseline
no_agent (36.027 ms) : 35738, 36317
. : milestone, 36027,
appsec (51.4 ms) : 50934, 51866
. : milestone, 51400,
code_origins (43.008 ms) : 42649, 43367
. : milestone, 43008,
iast (43.685 ms) : 43300, 44070
. : milestone, 43685,
profiling (51.281 ms) : 50790, 51772
. : milestone, 51281,
tracing (43.969 ms) : 43596, 44342
. : milestone, 43969,
section candidate
no_agent (37.211 ms) : 36908, 37514
. : milestone, 37211,
appsec (48.835 ms) : 48389, 49281
. : milestone, 48835,
code_origins (43.16 ms) : 42790, 43530
. : milestone, 43160,
iast (45.017 ms) : 44634, 45399
. : milestone, 45017,
profiling (49.613 ms) : 49154, 50073
. : milestone, 49613,
tracing (43.728 ms) : 43358, 44098
. : milestone, 43728,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~e2667ffe90, baseline=1.55.0-SNAPSHOT~4ddf06e364
dateFormat X
axisFormat %s
section baseline
no_agent (4.622 ms) : 4568, 4676
. : milestone, 4622,
iast (10.14 ms) : 9971, 10309
. : milestone, 10140,
iast_FULL (14.468 ms) : 14182, 14755
. : milestone, 14468,
iast_GLOBAL (10.544 ms) : 10357, 10732
. : milestone, 10544,
profiling (9.075 ms) : 8934, 9217
. : milestone, 9075,
tracing (7.943 ms) : 7828, 8057
. : milestone, 7943,
section candidate
no_agent (4.363 ms) : 4311, 4415
. : milestone, 4363,
iast (10.15 ms) : 9968, 10333
. : milestone, 10150,
iast_FULL (13.886 ms) : 13612, 14160
. : milestone, 13886,
iast_GLOBAL (10.495 ms) : 10306, 10685
. : milestone, 10495,
profiling (9.319 ms) : 9175, 9464
. : milestone, 9319,
tracing (7.794 ms) : 7685, 7902
. : milestone, 7794,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e2667ffe90, baseline=1.55.0-SNAPSHOT~4ddf06e364
dateFormat X
axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1488
. : milestone, 1476,
appsec (3.752 ms) : 3530, 3973
. : milestone, 3752,
iast (2.203 ms) : 2140, 2267
. : milestone, 2203,
iast_GLOBAL (2.234 ms) : 2170, 2298
. : milestone, 2234,
profiling (2.073 ms) : 2020, 2125
. : milestone, 2073,
tracing (2.023 ms) : 1974, 2072
. : milestone, 2023,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.703 ms) : 3485, 3922
. : milestone, 3703,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.257 ms) : 2193, 2322
. : milestone, 2257,
profiling (2.042 ms) : 1992, 2093
. : milestone, 2042,
tracing (2.027 ms) : 1977, 2076
. : milestone, 2027,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~e2667ffe90, baseline=1.55.0-SNAPSHOT~4ddf06e364
dateFormat X
axisFormat %s
section baseline
no_agent (14.763 s) : 14763000, 14763000
. : milestone, 14763000,
appsec (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
iast (18.601 s) : 18601000, 18601000
. : milestone, 18601000,
iast_GLOBAL (18.121 s) : 18121000, 18121000
. : milestone, 18121000,
profiling (14.933 s) : 14933000, 14933000
. : milestone, 14933000,
tracing (14.922 s) : 14922000, 14922000
. : milestone, 14922000,
section candidate
no_agent (15.342 s) : 15342000, 15342000
. : milestone, 15342000,
appsec (15.069 s) : 15069000, 15069000
. : milestone, 15069000,
iast (18.689 s) : 18689000, 18689000
. : milestone, 18689000,
iast_GLOBAL (18.128 s) : 18128000, 18128000
. : milestone, 18128000,
profiling (15.508 s) : 15508000, 15508000
. : milestone, 15508000,
tracing (14.888 s) : 14888000, 14888000
. : milestone, 14888000,
|
What Does This Do
This PR is a minor cleanup while reviewing code during escalation.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]