-
Notifications
You must be signed in to change notification settings - Fork 317
Drop 'rare sampling' support on CSS #9776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3e23441 to
5ebeb89
Compare
|
🎯 Code Coverage 🔗 Commit SHA: a44e017 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~a44e01716d, baseline=1.55.0-SNAPSHOT~e29d65834c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1019212
Total [baseline] (8.737 s) : 0, 8737095
Agent [candidate] (1.018 s) : 0, 1017813
Total [candidate] (8.693 s) : 0, 8693001
section iast
Agent [baseline] (1.153 s) : 0, 1152746
Total [baseline] (9.308 s) : 0, 9308209
Agent [candidate] (1.154 s) : 0, 1154232
Total [candidate] (9.346 s) : 0, 9346282
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~a44e01716d, baseline=1.55.0-SNAPSHOT~e29d65834c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.47 ms) : 0, 1470
crashtracking [candidate] (1.476 ms) : 0, 1476
BytebuddyAgent [baseline] (694.221 ms) : 0, 694221
BytebuddyAgent [candidate] (693.248 ms) : 0, 693248
GlobalTracer [baseline] (242.221 ms) : 0, 242221
GlobalTracer [candidate] (243.271 ms) : 0, 243271
AppSec [baseline] (32.512 ms) : 0, 32512
AppSec [candidate] (32.623 ms) : 0, 32623
Debugger [baseline] (6.415 ms) : 0, 6415
Debugger [candidate] (6.498 ms) : 0, 6498
Remote Config [baseline] (707.795 µs) : 0, 708
Remote Config [candidate] (708.197 µs) : 0, 708
Telemetry [baseline] (9.377 ms) : 0, 9377
Telemetry [candidate] (9.335 ms) : 0, 9335
Flare Poller [baseline] (11.122 ms) : 0, 11122
Flare Poller [candidate] (9.464 ms) : 0, 9464
section iast
crashtracking [baseline] (1.488 ms) : 0, 1488
crashtracking [candidate] (1.498 ms) : 0, 1498
BytebuddyAgent [baseline] (816.619 ms) : 0, 816619
BytebuddyAgent [candidate] (817.386 ms) : 0, 817386
GlobalTracer [baseline] (231.778 ms) : 0, 231778
GlobalTracer [candidate] (231.908 ms) : 0, 231908
AppSec [baseline] (35.088 ms) : 0, 35088
AppSec [candidate] (35.435 ms) : 0, 35435
Debugger [baseline] (6.141 ms) : 0, 6141
Debugger [candidate] (6.25 ms) : 0, 6250
Remote Config [baseline] (613.704 µs) : 0, 614
Remote Config [candidate] (619.047 µs) : 0, 619
Telemetry [baseline] (8.703 ms) : 0, 8703
Telemetry [candidate] (8.793 ms) : 0, 8793
Flare Poller [baseline] (4.22 ms) : 0, 4220
Flare Poller [candidate] (4.256 ms) : 0, 4256
IAST [baseline] (26.498 ms) : 0, 26498
IAST [candidate] (26.49 ms) : 0, 26490
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~a44e01716d, baseline=1.55.0-SNAPSHOT~e29d65834c
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.018 s) : 0, 1017651
Total [baseline] (10.695 s) : 0, 10694963
Agent [candidate] (1.015 s) : 0, 1015174
Total [candidate] (10.764 s) : 0, 10764382
section appsec
Agent [baseline] (1.204 s) : 0, 1204208
Total [baseline] (11.105 s) : 0, 11104684
Agent [candidate] (1.196 s) : 0, 1196424
Total [candidate] (11.162 s) : 0, 11161741
section iast
Agent [baseline] (1.153 s) : 0, 1153403
Total [baseline] (10.986 s) : 0, 10985674
Agent [candidate] (1.152 s) : 0, 1151826
Total [candidate] (11.028 s) : 0, 11028161
section profiling
Agent [baseline] (1.163 s) : 0, 1162549
Total [baseline] (11.126 s) : 0, 11126004
Agent [candidate] (1.168 s) : 0, 1167866
Total [candidate] (11.211 s) : 0, 11211408
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~a44e01716d, baseline=1.55.0-SNAPSHOT~e29d65834c
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.472 ms) : 0, 1472
BytebuddyAgent [baseline] (693.111 ms) : 0, 693111
BytebuddyAgent [candidate] (691.538 ms) : 0, 691538
GlobalTracer [baseline] (242.008 ms) : 0, 242008
GlobalTracer [candidate] (241.354 ms) : 0, 241354
AppSec [baseline] (32.267 ms) : 0, 32267
AppSec [candidate] (32.286 ms) : 0, 32286
Debugger [baseline] (6.41 ms) : 0, 6410
Debugger [candidate] (6.431 ms) : 0, 6431
Remote Config [baseline] (707.352 µs) : 0, 707
Remote Config [candidate] (721.324 µs) : 0, 721
Telemetry [baseline] (9.414 ms) : 0, 9414
Telemetry [candidate] (9.255 ms) : 0, 9255
Flare Poller [baseline] (11.043 ms) : 0, 11043
Flare Poller [candidate] (10.988 ms) : 0, 10988
section appsec
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (723.548 ms) : 0, 723548
BytebuddyAgent [candidate] (718.407 ms) : 0, 718407
GlobalTracer [baseline] (236.507 ms) : 0, 236507
GlobalTracer [candidate] (235.239 ms) : 0, 235239
AppSec [baseline] (176.24 ms) : 0, 176240
AppSec [candidate] (176.137 ms) : 0, 176137
Debugger [baseline] (6.211 ms) : 0, 6211
Debugger [candidate] (6.202 ms) : 0, 6202
Remote Config [baseline] (642.759 µs) : 0, 643
Remote Config [candidate] (654.765 µs) : 0, 655
Telemetry [baseline] (9.393 ms) : 0, 9393
Telemetry [candidate] (8.454 ms) : 0, 8454
Flare Poller [baseline] (4.007 ms) : 0, 4007
Flare Poller [candidate] (3.932 ms) : 0, 3932
IAST [baseline] (24.939 ms) : 0, 24939
IAST [candidate] (24.799 ms) : 0, 24799
section iast
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (817.162 ms) : 0, 817162
BytebuddyAgent [candidate] (816.017 ms) : 0, 816017
GlobalTracer [baseline] (232.007 ms) : 0, 232007
GlobalTracer [candidate] (231.469 ms) : 0, 231469
AppSec [baseline] (34.844 ms) : 0, 34844
AppSec [candidate] (35.309 ms) : 0, 35309
Debugger [baseline] (6.17 ms) : 0, 6170
Debugger [candidate] (6.118 ms) : 0, 6118
Remote Config [baseline] (621.499 µs) : 0, 621
Remote Config [candidate] (608.655 µs) : 0, 609
Telemetry [baseline] (8.712 ms) : 0, 8712
Telemetry [candidate] (8.535 ms) : 0, 8535
Flare Poller [baseline] (4.239 ms) : 0, 4239
Flare Poller [candidate] (4.236 ms) : 0, 4236
IAST [baseline] (26.57 ms) : 0, 26570
IAST [candidate] (26.469 ms) : 0, 26469
section profiling
ProfilingAgent [baseline] (108.787 ms) : 0, 108787
ProfilingAgent [candidate] (108.366 ms) : 0, 108366
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.446 ms) : 0, 1446
BytebuddyAgent [baseline] (721.199 ms) : 0, 721199
BytebuddyAgent [candidate] (724.646 ms) : 0, 724646
GlobalTracer [baseline] (217.916 ms) : 0, 217916
GlobalTracer [candidate] (218.805 ms) : 0, 218805
AppSec [baseline] (32.376 ms) : 0, 32376
AppSec [candidate] (32.603 ms) : 0, 32603
Debugger [baseline] (6.457 ms) : 0, 6457
Debugger [candidate] (6.615 ms) : 0, 6615
Remote Config [baseline] (795.456 µs) : 0, 795
Remote Config [candidate] (859.007 µs) : 0, 859
Telemetry [baseline] (15.947 ms) : 0, 15947
Telemetry [candidate] (15.486 ms) : 0, 15486
Flare Poller [baseline] (4.143 ms) : 0, 4143
Flare Poller [candidate] (4.222 ms) : 0, 4222
Profiling [baseline] (110.066 ms) : 0, 110066
Profiling [candidate] (110.044 ms) : 0, 110044
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 4 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a44e01716d, baseline=1.55.0-SNAPSHOT~e29d65834c
dateFormat X
axisFormat %s
section baseline
no_agent (4.275 ms) : 4221, 4329
. : milestone, 4275,
iast (9.848 ms) : 9680, 10015
. : milestone, 9848,
iast_FULL (14.921 ms) : 14624, 15219
. : milestone, 14921,
iast_GLOBAL (10.813 ms) : 10620, 11006
. : milestone, 10813,
profiling (8.693 ms) : 8560, 8825
. : milestone, 8693,
tracing (7.791 ms) : 7678, 7903
. : milestone, 7791,
section candidate
no_agent (4.211 ms) : 4158, 4263
. : milestone, 4211,
iast (10.168 ms) : 9997, 10339
. : milestone, 10168,
iast_FULL (14.078 ms) : 13799, 14357
. : milestone, 14078,
iast_GLOBAL (11.571 ms) : 11359, 11782
. : milestone, 11571,
profiling (8.7 ms) : 8556, 8844
. : milestone, 8700,
tracing (8.104 ms) : 7986, 8222
. : milestone, 8104,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~a44e01716d, baseline=1.55.0-SNAPSHOT~e29d65834c
dateFormat X
axisFormat %s
section baseline
no_agent (35.852 ms) : 35566, 36138
. : milestone, 35852,
appsec (49.152 ms) : 48724, 49579
. : milestone, 49152,
code_origins (42.353 ms) : 42001, 42705
. : milestone, 42353,
iast (46.035 ms) : 45642, 46429
. : milestone, 46035,
profiling (49.075 ms) : 48584, 49566
. : milestone, 49075,
tracing (44.308 ms) : 43921, 44695
. : milestone, 44308,
section candidate
no_agent (37.568 ms) : 37268, 37868
. : milestone, 37568,
appsec (47.332 ms) : 46933, 47731
. : milestone, 47332,
code_origins (43.763 ms) : 43379, 44148
. : milestone, 43763,
iast (47.035 ms) : 46631, 47439
. : milestone, 47035,
profiling (48.777 ms) : 48273, 49280
. : milestone, 48777,
tracing (44.776 ms) : 44389, 45163
. : milestone, 44776,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a44e01716d, baseline=1.55.0-SNAPSHOT~e29d65834c
dateFormat X
axisFormat %s
section baseline
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.764 ms) : 3542, 3985
. : milestone, 3764,
iast (2.229 ms) : 2165, 2294
. : milestone, 2229,
iast_GLOBAL (2.271 ms) : 2206, 2335
. : milestone, 2271,
profiling (2.083 ms) : 2030, 2137
. : milestone, 2083,
tracing (2.053 ms) : 2002, 2104
. : milestone, 2053,
section candidate
no_agent (1.487 ms) : 1475, 1498
. : milestone, 1487,
appsec (3.724 ms) : 3504, 3944
. : milestone, 3724,
iast (2.23 ms) : 2166, 2294
. : milestone, 2230,
iast_GLOBAL (2.275 ms) : 2210, 2340
. : milestone, 2275,
profiling (2.074 ms) : 2022, 2127
. : milestone, 2074,
tracing (2.045 ms) : 1995, 2096
. : milestone, 2045,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~a44e01716d, baseline=1.55.0-SNAPSHOT~e29d65834c
dateFormat X
axisFormat %s
section baseline
no_agent (14.904 s) : 14904000, 14904000
. : milestone, 14904000,
appsec (14.83 s) : 14830000, 14830000
. : milestone, 14830000,
iast (18.534 s) : 18534000, 18534000
. : milestone, 18534000,
iast_GLOBAL (17.963 s) : 17963000, 17963000
. : milestone, 17963000,
profiling (15.647 s) : 15647000, 15647000
. : milestone, 15647000,
tracing (14.942 s) : 14942000, 14942000
. : milestone, 14942000,
section candidate
no_agent (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
appsec (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
iast (18.73 s) : 18730000, 18730000
. : milestone, 18730000,
iast_GLOBAL (18.042 s) : 18042000, 18042000
. : milestone, 18042000,
profiling (15.239 s) : 15239000, 15239000
. : milestone, 15239000,
tracing (15.235 s) : 15235000, 15235000
. : milestone, 15235000,
|
5ebeb89 to
a44e017
Compare
What Does This Do
It avoid force keeping the first seen spans even if they are p0. The rationale behind is that rare sampling is going to be discontinued. This feature is also not part of CSS hence we're removing from the old implementation.
The fact that rare sampling is not compatible hence with CSS is a known limitation.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]