-
Notifications
You must be signed in to change notification settings - Fork 317
Crashtracker: use arrays for tags and send data schema version #9763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: d8b2a62 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~d8b2a6246e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.014 s) : 0, 1013915
Total [baseline] (8.655 s) : 0, 8654762
Agent [candidate] (1.019 s) : 0, 1018620
Total [candidate] (8.701 s) : 0, 8700604
section iast
Agent [baseline] (1.156 s) : 0, 1156391
Total [baseline] (9.3 s) : 0, 9300149
Agent [candidate] (1.155 s) : 0, 1155108
Total [candidate] (9.292 s) : 0, 9292453
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~d8b2a6246e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.462 ms) : 0, 1462
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (691.082 ms) : 0, 691082
BytebuddyAgent [candidate] (693.042 ms) : 0, 693042
GlobalTracer [baseline] (240.901 ms) : 0, 240901
GlobalTracer [candidate] (243.231 ms) : 0, 243231
AppSec [baseline] (32.588 ms) : 0, 32588
AppSec [candidate] (33.124 ms) : 0, 33124
Debugger [baseline] (6.411 ms) : 0, 6411
Debugger [candidate] (6.507 ms) : 0, 6507
Remote Config [baseline] (699.745 µs) : 0, 700
Remote Config [candidate] (693.318 µs) : 0, 693
Telemetry [baseline] (9.321 ms) : 0, 9321
Telemetry [candidate] (9.206 ms) : 0, 9206
Flare Poller [baseline] (10.368 ms) : 0, 10368
Flare Poller [candidate] (10.238 ms) : 0, 10238
section iast
crashtracking [baseline] (1.507 ms) : 0, 1507
crashtracking [candidate] (1.498 ms) : 0, 1498
BytebuddyAgent [baseline] (819.601 ms) : 0, 819601
BytebuddyAgent [candidate] (818.34 ms) : 0, 818340
GlobalTracer [baseline] (232.012 ms) : 0, 232012
GlobalTracer [candidate] (232.317 ms) : 0, 232317
IAST [baseline] (26.764 ms) : 0, 26764
IAST [candidate] (26.69 ms) : 0, 26690
AppSec [baseline] (35.04 ms) : 0, 35040
AppSec [candidate] (34.931 ms) : 0, 34931
Debugger [baseline] (6.156 ms) : 0, 6156
Debugger [candidate] (6.151 ms) : 0, 6151
Remote Config [baseline] (625.067 µs) : 0, 625
Remote Config [candidate] (616.203 µs) : 0, 616
Telemetry [baseline] (8.73 ms) : 0, 8730
Telemetry [candidate] (8.666 ms) : 0, 8666
Flare Poller [baseline] (4.32 ms) : 0, 4320
Flare Poller [candidate] (4.257 ms) : 0, 4257
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~d8b2a6246e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1022102
Total [baseline] (10.719 s) : 0, 10719313
Agent [candidate] (1.016 s) : 0, 1016468
Total [candidate] (10.76 s) : 0, 10759993
section appsec
Agent [baseline] (1.192 s) : 0, 1192317
Total [baseline] (11.049 s) : 0, 11048674
Agent [candidate] (1.19 s) : 0, 1189986
Total [candidate] (10.981 s) : 0, 10980721
section iast
Agent [baseline] (1.15 s) : 0, 1150131
Total [baseline] (11.021 s) : 0, 11020869
Agent [candidate] (1.152 s) : 0, 1152431
Total [candidate] (11.002 s) : 0, 11001795
section profiling
Agent [baseline] (1.162 s) : 0, 1161597
Total [baseline] (11.073 s) : 0, 11072522
Agent [candidate] (1.16 s) : 0, 1160261
Total [candidate] (11.012 s) : 0, 11011842
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~d8b2a6246e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (695.812 ms) : 0, 695812
BytebuddyAgent [candidate] (691.925 ms) : 0, 691925
GlobalTracer [baseline] (242.758 ms) : 0, 242758
GlobalTracer [candidate] (241.5 ms) : 0, 241500
AppSec [baseline] (32.742 ms) : 0, 32742
AppSec [candidate] (32.436 ms) : 0, 32436
Debugger [baseline] (6.517 ms) : 0, 6517
Debugger [candidate] (6.392 ms) : 0, 6392
Remote Config [baseline] (699.002 µs) : 0, 699
Remote Config [candidate] (696.758 µs) : 0, 697
Telemetry [baseline] (9.342 ms) : 0, 9342
Telemetry [candidate] (9.188 ms) : 0, 9188
Flare Poller [baseline] (11.658 ms) : 0, 11658
Flare Poller [candidate] (11.745 ms) : 0, 11745
section appsec
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (716.696 ms) : 0, 716696
BytebuddyAgent [candidate] (715.214 ms) : 0, 715214
GlobalTracer [baseline] (234.161 ms) : 0, 234161
GlobalTracer [candidate] (233.887 ms) : 0, 233887
IAST [baseline] (24.735 ms) : 0, 24735
IAST [candidate] (24.542 ms) : 0, 24542
AppSec [baseline] (175.189 ms) : 0, 175189
AppSec [candidate] (174.631 ms) : 0, 174631
Debugger [baseline] (6.108 ms) : 0, 6108
Debugger [candidate] (6.157 ms) : 0, 6157
Remote Config [baseline] (628.59 µs) : 0, 629
Remote Config [candidate] (629.383 µs) : 0, 629
Telemetry [baseline] (8.433 ms) : 0, 8433
Telemetry [candidate] (8.538 ms) : 0, 8538
Flare Poller [baseline] (3.893 ms) : 0, 3893
Flare Poller [candidate] (3.904 ms) : 0, 3904
section iast
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.482 ms) : 0, 1482
BytebuddyAgent [baseline] (815.019 ms) : 0, 815019
BytebuddyAgent [candidate] (816.331 ms) : 0, 816331
GlobalTracer [baseline] (231.345 ms) : 0, 231345
GlobalTracer [candidate] (231.607 ms) : 0, 231607
IAST [baseline] (26.432 ms) : 0, 26432
IAST [candidate] (26.512 ms) : 0, 26512
AppSec [baseline] (34.693 ms) : 0, 34693
AppSec [candidate] (35.191 ms) : 0, 35191
Debugger [baseline] (6.176 ms) : 0, 6176
Debugger [candidate] (6.13 ms) : 0, 6130
Remote Config [baseline] (608.619 µs) : 0, 609
Remote Config [candidate] (607.516 µs) : 0, 608
Telemetry [baseline] (8.664 ms) : 0, 8664
Telemetry [candidate] (8.78 ms) : 0, 8780
Flare Poller [baseline] (4.171 ms) : 0, 4171
Flare Poller [candidate] (4.254 ms) : 0, 4254
section profiling
crashtracking [baseline] (1.424 ms) : 0, 1424
crashtracking [candidate] (1.431 ms) : 0, 1431
BytebuddyAgent [baseline] (720.73 ms) : 0, 720730
BytebuddyAgent [candidate] (720.401 ms) : 0, 720401
GlobalTracer [baseline] (217.662 ms) : 0, 217662
GlobalTracer [candidate] (217.525 ms) : 0, 217525
AppSec [baseline] (32.547 ms) : 0, 32547
AppSec [candidate] (32.485 ms) : 0, 32485
Debugger [baseline] (6.522 ms) : 0, 6522
Debugger [candidate] (6.543 ms) : 0, 6543
Remote Config [baseline] (729.125 µs) : 0, 729
Remote Config [candidate] (816.467 µs) : 0, 816
Telemetry [baseline] (15.319 ms) : 0, 15319
Telemetry [candidate] (15.902 ms) : 0, 15902
Flare Poller [baseline] (4.991 ms) : 0, 4991
Flare Poller [candidate] (4.169 ms) : 0, 4169
ProfilingAgent [baseline] (108.123 ms) : 0, 108123
ProfilingAgent [candidate] (106.8 ms) : 0, 106800
Profiling [baseline] (109.669 ms) : 0, 109669
Profiling [candidate] (109.014 ms) : 0, 109014
LoadParameters
See matching parameters
SummaryFound 2 performance improvements and 3 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d8b2a6246e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (37.436 ms) : 37134, 37739
. : milestone, 37436,
appsec (48.564 ms) : 48143, 48986
. : milestone, 48564,
code_origins (44.332 ms) : 43939, 44725
. : milestone, 44332,
iast (44.573 ms) : 44181, 44966
. : milestone, 44573,
profiling (46.536 ms) : 46123, 46950
. : milestone, 46536,
tracing (46.315 ms) : 45898, 46732
. : milestone, 46315,
section candidate
no_agent (36.507 ms) : 36214, 36800
. : milestone, 36507,
appsec (46.092 ms) : 45687, 46498
. : milestone, 46092,
code_origins (42.679 ms) : 42307, 43051
. : milestone, 42679,
iast (44.439 ms) : 44054, 44823
. : milestone, 44439,
profiling (48.249 ms) : 47790, 48708
. : milestone, 48249,
tracing (45.28 ms) : 44888, 45673
. : milestone, 45280,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~d8b2a6246e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (4.352 ms) : 4303, 4401
. : milestone, 4352,
iast (9.596 ms) : 9436, 9755
. : milestone, 9596,
iast_FULL (14.146 ms) : 13870, 14423
. : milestone, 14146,
iast_GLOBAL (11.038 ms) : 10843, 11234
. : milestone, 11038,
profiling (8.801 ms) : 8667, 8935
. : milestone, 8801,
tracing (7.91 ms) : 7790, 8029
. : milestone, 7910,
section candidate
no_agent (4.491 ms) : 4439, 4543
. : milestone, 4491,
iast (10.042 ms) : 9874, 10211
. : milestone, 10042,
iast_FULL (14.244 ms) : 13956, 14533
. : milestone, 14244,
iast_GLOBAL (10.863 ms) : 10664, 11061
. : milestone, 10863,
profiling (9.538 ms) : 9376, 9700
. : milestone, 9538,
tracing (7.77 ms) : 7653, 7888
. : milestone, 7770,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d8b2a6246e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (15.5 s) : 15500000, 15500000
. : milestone, 15500000,
appsec (15.186 s) : 15186000, 15186000
. : milestone, 15186000,
iast (18.591 s) : 18591000, 18591000
. : milestone, 18591000,
iast_GLOBAL (18.01 s) : 18010000, 18010000
. : milestone, 18010000,
profiling (15.319 s) : 15319000, 15319000
. : milestone, 15319000,
tracing (14.946 s) : 14946000, 14946000
. : milestone, 14946000,
section candidate
no_agent (14.861 s) : 14861000, 14861000
. : milestone, 14861000,
appsec (15.094 s) : 15094000, 15094000
. : milestone, 15094000,
iast (18.45 s) : 18450000, 18450000
. : milestone, 18450000,
iast_GLOBAL (18.008 s) : 18008000, 18008000
. : milestone, 18008000,
profiling (15.066 s) : 15066000, 15066000
. : milestone, 15066000,
tracing (15.158 s) : 15158000, 15158000
. : milestone, 15158000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~d8b2a6246e, baseline=1.55.0-SNAPSHOT~d506c27e84
dateFormat X
axisFormat %s
section baseline
no_agent (1.479 ms) : 1467, 1490
. : milestone, 1479,
appsec (3.685 ms) : 3470, 3899
. : milestone, 3685,
iast (2.216 ms) : 2153, 2280
. : milestone, 2216,
iast_GLOBAL (2.254 ms) : 2190, 2317
. : milestone, 2254,
profiling (2.075 ms) : 2022, 2127
. : milestone, 2075,
tracing (2.027 ms) : 1978, 2076
. : milestone, 2027,
section candidate
no_agent (1.476 ms) : 1465, 1488
. : milestone, 1476,
appsec (3.669 ms) : 3456, 3881
. : milestone, 3669,
iast (2.206 ms) : 2142, 2269
. : milestone, 2206,
iast_GLOBAL (2.259 ms) : 2195, 2323
. : milestone, 2259,
profiling (2.501 ms) : 2331, 2672
. : milestone, 2501,
tracing (2.028 ms) : 1979, 2078
. : milestone, 2028,
|
What Does This Do
The crashtracker symbolication was failed since the metadata.tags are required to be an array and not a map.
I also sent the
data_schema_versionthat is now required.Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]