-
Notifications
You must be signed in to change notification settings - Fork 317
Remove instrumentation afterEvaluate
#9752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
bric3
wants to merge
2
commits into
master
Choose a base branch
from
bdu/avoid-afterEvaluate-in-instrumentation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d930307 to
ff71451
Compare
This comment has been minimized.
This comment has been minimized.
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 7 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.56.0-SNAPSHOT~ff71451f73, baseline=1.56.0-SNAPSHOT~46649f7687
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.105 s) : 0, 1104628
Total [baseline] (10.761 s) : 0, 10760528
Agent [candidate] (1.104 s) : 0, 1103533
Total [candidate] (10.816 s) : 0, 10815957
section appsec
Agent [baseline] (1.281 s) : 0, 1280714
Total [baseline] (11.181 s) : 0, 11180991
Agent [candidate] (1.28 s) : 0, 1280043
Total [candidate] (11.217 s) : 0, 11217084
section iast
Agent [baseline] (1.248 s) : 0, 1247675
Total [baseline] (11.397 s) : 0, 11397230
Agent [candidate] (1.246 s) : 0, 1246120
Total [candidate] (11.328 s) : 0, 11327908
section profiling
Agent [baseline] (1.233 s) : 0, 1233255
Total [baseline] (11.037 s) : 0, 11036910
Agent [candidate] (1.233 s) : 0, 1233040
Total [candidate] (11.047 s) : 0, 11047428
gantt
title petclinic - break down per module: candidate=1.56.0-SNAPSHOT~ff71451f73, baseline=1.56.0-SNAPSHOT~46649f7687
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (705.846 ms) : 0, 705846
BytebuddyAgent [candidate] (704.759 ms) : 0, 704759
GlobalTracer [baseline] (248.757 ms) : 0, 248757
GlobalTracer [candidate] (248.327 ms) : 0, 248327
AppSec [baseline] (32.388 ms) : 0, 32388
AppSec [candidate] (32.399 ms) : 0, 32399
Debugger [baseline] (68.962 ms) : 0, 68962
Debugger [candidate] (69.152 ms) : 0, 69152
Remote Config [baseline] (629.226 µs) : 0, 629
Remote Config [candidate] (655.618 µs) : 0, 656
Telemetry [baseline] (8.137 ms) : 0, 8137
Telemetry [candidate] (8.239 ms) : 0, 8239
Flare Poller [baseline] (3.698 ms) : 0, 3698
Flare Poller [candidate] (3.73 ms) : 0, 3730
section appsec
crashtracking [baseline] (1.477 ms) : 0, 1477
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (730.695 ms) : 0, 730695
BytebuddyAgent [candidate] (729.312 ms) : 0, 729312
GlobalTracer [baseline] (241.112 ms) : 0, 241112
GlobalTracer [candidate] (240.885 ms) : 0, 240885
AppSec [baseline] (173.897 ms) : 0, 173897
AppSec [candidate] (174.645 ms) : 0, 174645
Debugger [baseline] (60.98 ms) : 0, 60980
Debugger [candidate] (61.263 ms) : 0, 61263
Remote Config [baseline] (650.83 µs) : 0, 651
Remote Config [candidate] (672.983 µs) : 0, 673
Telemetry [baseline] (8.322 ms) : 0, 8322
Telemetry [candidate] (8.444 ms) : 0, 8444
Flare Poller [baseline] (3.796 ms) : 0, 3796
Flare Poller [candidate] (3.861 ms) : 0, 3861
IAST [baseline] (24.911 ms) : 0, 24911
IAST [candidate] (24.708 ms) : 0, 24708
section iast
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (832.108 ms) : 0, 832108
BytebuddyAgent [candidate] (831.854 ms) : 0, 831854
GlobalTracer [baseline] (239.125 ms) : 0, 239125
GlobalTracer [candidate] (238.993 ms) : 0, 238993
AppSec [baseline] (33.816 ms) : 0, 33816
AppSec [candidate] (29.697 ms) : 0, 29697
Debugger [baseline] (66.281 ms) : 0, 66281
Debugger [candidate] (65.857 ms) : 0, 65857
Remote Config [baseline] (547.024 µs) : 0, 547
Remote Config [candidate] (544.339 µs) : 0, 544
Telemetry [baseline] (7.664 ms) : 0, 7664
Telemetry [candidate] (7.7 ms) : 0, 7700
Flare Poller [baseline] (3.563 ms) : 0, 3563
Flare Poller [candidate] (3.55 ms) : 0, 3550
IAST [baseline] (28.215 ms) : 0, 28215
IAST [candidate] (31.798 ms) : 0, 31798
section profiling
ProfilingAgent [baseline] (96.907 ms) : 0, 96907
ProfilingAgent [candidate] (97.132 ms) : 0, 97132
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (729.984 ms) : 0, 729984
BytebuddyAgent [candidate] (730.145 ms) : 0, 730145
GlobalTracer [baseline] (222.041 ms) : 0, 222041
GlobalTracer [candidate] (221.993 ms) : 0, 221993
AppSec [baseline] (32.344 ms) : 0, 32344
AppSec [candidate] (32.232 ms) : 0, 32232
Debugger [baseline] (68.218 ms) : 0, 68218
Debugger [candidate] (67.695 ms) : 0, 67695
Remote Config [baseline] (648.204 µs) : 0, 648
Remote Config [candidate] (647.24 µs) : 0, 647
Telemetry [baseline] (8.047 ms) : 0, 8047
Telemetry [candidate] (7.928 ms) : 0, 7928
Flare Poller [baseline] (3.769 ms) : 0, 3769
Flare Poller [candidate] (3.799 ms) : 0, 3799
Profiling [baseline] (97.499 ms) : 0, 97499
Profiling [candidate] (97.695 ms) : 0, 97695
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.56.0-SNAPSHOT~ff71451f73, baseline=1.56.0-SNAPSHOT~46649f7687
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.107 s) : 0, 1107312
Total [baseline] (8.855 s) : 0, 8855006
Agent [candidate] (1.107 s) : 0, 1106574
Total [candidate] (8.866 s) : 0, 8865809
section iast
Agent [baseline] (1.247 s) : 0, 1246794
Total [baseline] (9.621 s) : 0, 9620803
Agent [candidate] (1.244 s) : 0, 1244130
Total [candidate] (9.543 s) : 0, 9543412
gantt
title insecure-bank - break down per module: candidate=1.56.0-SNAPSHOT~ff71451f73, baseline=1.56.0-SNAPSHOT~46649f7687
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.452 ms) : 0, 1452
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (706.063 ms) : 0, 706063
BytebuddyAgent [candidate] (708.105 ms) : 0, 708105
GlobalTracer [baseline] (250.612 ms) : 0, 250612
GlobalTracer [candidate] (248.983 ms) : 0, 248983
AppSec [baseline] (32.804 ms) : 0, 32804
AppSec [candidate] (32.296 ms) : 0, 32296
Debugger [baseline] (69.029 ms) : 0, 69029
Debugger [candidate] (68.441 ms) : 0, 68441
Remote Config [baseline] (635.58 µs) : 0, 636
Remote Config [candidate] (634.095 µs) : 0, 634
Telemetry [baseline] (8.281 ms) : 0, 8281
Telemetry [candidate] (8.21 ms) : 0, 8210
Flare Poller [baseline] (3.697 ms) : 0, 3697
Flare Poller [candidate] (3.717 ms) : 0, 3717
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (833.791 ms) : 0, 833791
BytebuddyAgent [candidate] (831.034 ms) : 0, 831034
GlobalTracer [baseline] (237.871 ms) : 0, 237871
GlobalTracer [candidate] (238.508 ms) : 0, 238508
AppSec [baseline] (31.389 ms) : 0, 31389
AppSec [candidate] (33.159 ms) : 0, 33159
Debugger [baseline] (65.33 ms) : 0, 65330
Debugger [candidate] (65.214 ms) : 0, 65214
Remote Config [baseline] (548.112 µs) : 0, 548
Remote Config [candidate] (546.208 µs) : 0, 546
Telemetry [baseline] (7.717 ms) : 0, 7717
Telemetry [candidate] (7.624 ms) : 0, 7624
Flare Poller [baseline] (3.559 ms) : 0, 3559
Flare Poller [candidate] (3.535 ms) : 0, 3535
IAST [baseline] (30.295 ms) : 0, 30295
IAST [candidate] (28.266 ms) : 0, 28266
LoadParameters
See matching parameters
SummaryFound 4 performance improvements and 0 performance regressions! Performance is the same for 17 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~ff71451f73, baseline=1.56.0-SNAPSHOT~46649f7687
dateFormat X
axisFormat %s
section baseline
no_agent (1.2 ms) : 1188, 1211
. : milestone, 1200,
iast (3.131 ms) : 3094, 3167
. : milestone, 3131,
iast_FULL (5.918 ms) : 5836, 6001
. : milestone, 5918,
iast_GLOBAL (3.62 ms) : 3563, 3677
. : milestone, 3620,
profiling (2.024 ms) : 2005, 2042
. : milestone, 2024,
tracing (1.774 ms) : 1760, 1788
. : milestone, 1774,
section candidate
no_agent (1.19 ms) : 1179, 1202
. : milestone, 1190,
iast (3.073 ms) : 3033, 3113
. : milestone, 3073,
iast_FULL (5.598 ms) : 5543, 5652
. : milestone, 5598,
iast_GLOBAL (3.47 ms) : 3414, 3527
. : milestone, 3470,
profiling (1.93 ms) : 1913, 1946
. : milestone, 1930,
tracing (1.76 ms) : 1746, 1773
. : milestone, 1760,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.56.0-SNAPSHOT~ff71451f73, baseline=1.56.0-SNAPSHOT~46649f7687
dateFormat X
axisFormat %s
section baseline
no_agent (19.197 ms) : 18999, 19396
. : milestone, 19197,
appsec (18.867 ms) : 18672, 19062
. : milestone, 18867,
code_origins (17.5 ms) : 17326, 17673
. : milestone, 17500,
iast (17.742 ms) : 17569, 17916
. : milestone, 17742,
profiling (18.736 ms) : 18546, 18926
. : milestone, 18736,
tracing (17.424 ms) : 17256, 17592
. : milestone, 17424,
section candidate
no_agent (17.851 ms) : 17673, 18029
. : milestone, 17851,
appsec (19.679 ms) : 19474, 19884
. : milestone, 19679,
code_origins (17.564 ms) : 17389, 17738
. : milestone, 17564,
iast (17.899 ms) : 17720, 18078
. : milestone, 17899,
profiling (18.549 ms) : 18367, 18731
. : milestone, 18549,
tracing (17.607 ms) : 17432, 17782
. : milestone, 17607,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~ff71451f73, baseline=1.56.0-SNAPSHOT~46649f7687
dateFormat X
axisFormat %s
section baseline
no_agent (15.124 s) : 15124000, 15124000
. : milestone, 15124000,
appsec (14.992 s) : 14992000, 14992000
. : milestone, 14992000,
iast (18.642 s) : 18642000, 18642000
. : milestone, 18642000,
iast_GLOBAL (18.073 s) : 18073000, 18073000
. : milestone, 18073000,
profiling (15.813 s) : 15813000, 15813000
. : milestone, 15813000,
tracing (14.847 s) : 14847000, 14847000
. : milestone, 14847000,
section candidate
no_agent (15.25 s) : 15250000, 15250000
. : milestone, 15250000,
appsec (15.298 s) : 15298000, 15298000
. : milestone, 15298000,
iast (18.26 s) : 18260000, 18260000
. : milestone, 18260000,
iast_GLOBAL (17.785 s) : 17785000, 17785000
. : milestone, 17785000,
profiling (15.324 s) : 15324000, 15324000
. : milestone, 15324000,
tracing (14.646 s) : 14646000, 14646000
. : milestone, 14646000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.56.0-SNAPSHOT~ff71451f73, baseline=1.56.0-SNAPSHOT~46649f7687
dateFormat X
axisFormat %s
section baseline
no_agent (1.48 ms) : 1469, 1492
. : milestone, 1480,
appsec (3.735 ms) : 3515, 3955
. : milestone, 3735,
iast (2.208 ms) : 2145, 2271
. : milestone, 2208,
iast_GLOBAL (2.263 ms) : 2199, 2327
. : milestone, 2263,
profiling (2.059 ms) : 2007, 2110
. : milestone, 2059,
tracing (2.038 ms) : 1989, 2087
. : milestone, 2038,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (3.729 ms) : 3509, 3949
. : milestone, 3729,
iast (2.217 ms) : 2154, 2281
. : milestone, 2217,
iast_GLOBAL (2.26 ms) : 2196, 2325
. : milestone, 2260,
profiling (2.071 ms) : 2019, 2123
. : milestone, 2071,
tracing (2.038 ms) : 1989, 2087
. : milestone, 2038,
|
ff71451 to
ee918db
Compare
# Conflicts: # dd-java-agent/instrumentation/build.gradle
5388f6d to
4835e7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: tooling
Build & Tooling
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Removes instrumentation module's
afterEvaluate.This looks like it is reducing sync time to ~1min on my M1

Motivation
Using
afterEvaluateis a bad practice and has tighter restriction in Gradle 9+.https://docs.gradle.org/9.1.0/userguide/task_configuration_avoidance.html#8_some_apis_may_be_disallowed_if_you_try_to_access_them_from_the_new_apis_configuration_blocks
It introduces subtle ordering issues which can be very challenging to debug.
From my notes:
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any useful labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]