-
Notifications
You must be signed in to change notification settings - Fork 318
Exclude config-utils from shadowed sub-projects #9595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: c14f4a0 | Docs | Was this helpful? Give us feedback! |
amarziali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks 🙏
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~c14f4a0ab6, baseline=1.54.0-SNAPSHOT~aadd47174a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1001177
Total [baseline] (10.607 s) : 0, 10606859
Agent [candidate] (1.007 s) : 0, 1006988
Total [candidate] (10.726 s) : 0, 10726080
section appsec
Agent [baseline] (1.185 s) : 0, 1185064
Total [baseline] (11.03 s) : 0, 11029633
Agent [candidate] (1.189 s) : 0, 1188842
Total [candidate] (11.037 s) : 0, 11037136
section iast
Agent [baseline] (1.146 s) : 0, 1146475
Total [baseline] (10.965 s) : 0, 10965462
Agent [candidate] (1.145 s) : 0, 1144716
Total [candidate] (10.969 s) : 0, 10968920
section profiling
Agent [baseline] (1.151 s) : 0, 1151016
Total [baseline] (11.045 s) : 0, 11044545
Agent [candidate] (1.149 s) : 0, 1148595
Total [candidate] (11.02 s) : 0, 11020159
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~c14f4a0ab6, baseline=1.54.0-SNAPSHOT~aadd47174a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.457 ms) : 0, 1457
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (684.289 ms) : 0, 684289
BytebuddyAgent [candidate] (688.198 ms) : 0, 688198
GlobalTracer [baseline] (247.254 ms) : 0, 247254
GlobalTracer [candidate] (248.74 ms) : 0, 248740
AppSec [baseline] (31.097 ms) : 0, 31097
AppSec [candidate] (31.257 ms) : 0, 31257
Debugger [baseline] (6.3 ms) : 0, 6300
Debugger [candidate] (6.362 ms) : 0, 6362
Remote Config [baseline] (683.747 µs) : 0, 684
Remote Config [candidate] (682.511 µs) : 0, 683
Telemetry [baseline] (8.98 ms) : 0, 8980
Telemetry [candidate] (9.029 ms) : 0, 9029
section appsec
crashtracking [baseline] (1.463 ms) : 0, 1463
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (710.423 ms) : 0, 710423
BytebuddyAgent [candidate] (711.733 ms) : 0, 711733
GlobalTracer [baseline] (239.496 ms) : 0, 239496
GlobalTracer [candidate] (240.853 ms) : 0, 240853
AppSec [baseline] (170.507 ms) : 0, 170507
AppSec [candidate] (172.909 ms) : 0, 172909
Debugger [baseline] (6.671 ms) : 0, 6671
Debugger [candidate] (6.744 ms) : 0, 6744
Remote Config [baseline] (622.092 µs) : 0, 622
Remote Config [candidate] (627.89 µs) : 0, 628
Telemetry [baseline] (9.973 ms) : 0, 9973
Telemetry [candidate] (8.444 ms) : 0, 8444
IAST [baseline] (24.76 ms) : 0, 24760
IAST [candidate] (24.853 ms) : 0, 24853
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (808.904 ms) : 0, 808904
BytebuddyAgent [candidate] (808.685 ms) : 0, 808685
GlobalTracer [baseline] (239.14 ms) : 0, 239140
GlobalTracer [candidate] (238.308 ms) : 0, 238308
AppSec [baseline] (34.217 ms) : 0, 34217
AppSec [candidate] (33.751 ms) : 0, 33751
Debugger [baseline] (6.152 ms) : 0, 6152
Debugger [candidate] (6.206 ms) : 0, 6206
Remote Config [baseline] (595.807 µs) : 0, 596
Remote Config [candidate] (606.998 µs) : 0, 607
Telemetry [baseline] (8.28 ms) : 0, 8280
Telemetry [candidate] (8.324 ms) : 0, 8324
IAST [baseline] (26.391 ms) : 0, 26391
IAST [candidate] (26.129 ms) : 0, 26129
section profiling
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.425 ms) : 0, 1425
BytebuddyAgent [baseline] (718.436 ms) : 0, 718436
BytebuddyAgent [candidate] (716.61 ms) : 0, 716610
GlobalTracer [baseline] (223.792 ms) : 0, 223792
GlobalTracer [candidate] (224.252 ms) : 0, 224252
AppSec [baseline] (31.371 ms) : 0, 31371
AppSec [candidate] (31.266 ms) : 0, 31266
Debugger [baseline] (6.486 ms) : 0, 6486
Debugger [candidate] (7.254 ms) : 0, 7254
Remote Config [baseline] (698.993 µs) : 0, 699
Remote Config [candidate] (706.557 µs) : 0, 707
Telemetry [baseline] (16.156 ms) : 0, 16156
Telemetry [candidate] (15.565 ms) : 0, 15565
ProfilingAgent [baseline] (101.502 ms) : 0, 101502
ProfilingAgent [candidate] (100.635 ms) : 0, 100635
Profiling [baseline] (102.071 ms) : 0, 102071
Profiling [candidate] (101.209 ms) : 0, 101209
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~c14f4a0ab6, baseline=1.54.0-SNAPSHOT~aadd47174a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1006360
Total [baseline] (8.676 s) : 0, 8675772
Agent [candidate] (1.006 s) : 0, 1005512
Total [candidate] (8.688 s) : 0, 8687568
section iast
Agent [baseline] (1.151 s) : 0, 1150926
Total [baseline] (9.313 s) : 0, 9312944
Agent [candidate] (1.143 s) : 0, 1143088
Total [candidate] (9.317 s) : 0, 9316807
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~c14f4a0ab6, baseline=1.54.0-SNAPSHOT~aadd47174a
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (687.949 ms) : 0, 687949
BytebuddyAgent [candidate] (687.444 ms) : 0, 687444
GlobalTracer [baseline] (248.494 ms) : 0, 248494
GlobalTracer [candidate] (248.23 ms) : 0, 248230
AppSec [baseline] (31.139 ms) : 0, 31139
AppSec [candidate] (31.208 ms) : 0, 31208
Debugger [baseline] (6.319 ms) : 0, 6319
Debugger [candidate] (6.364 ms) : 0, 6364
Remote Config [baseline] (677.807 µs) : 0, 678
Remote Config [candidate] (670.267 µs) : 0, 670
Telemetry [baseline] (9.148 ms) : 0, 9148
Telemetry [candidate] (9.009 ms) : 0, 9009
section iast
crashtracking [baseline] (1.466 ms) : 0, 1466
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (813.256 ms) : 0, 813256
BytebuddyAgent [candidate] (807.862 ms) : 0, 807862
GlobalTracer [baseline] (239.543 ms) : 0, 239543
GlobalTracer [candidate] (238.07 ms) : 0, 238070
AppSec [baseline] (34.29 ms) : 0, 34290
AppSec [candidate] (33.744 ms) : 0, 33744
Debugger [baseline] (6.09 ms) : 0, 6090
Debugger [candidate] (6.021 ms) : 0, 6021
Remote Config [baseline] (601.713 µs) : 0, 602
Remote Config [candidate] (578.017 µs) : 0, 578
Telemetry [baseline] (8.191 ms) : 0, 8191
Telemetry [candidate] (8.24 ms) : 0, 8240
IAST [baseline] (26.243 ms) : 0, 26243
IAST [candidate] (25.866 ms) : 0, 25866
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c14f4a0ab6, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section baseline
no_agent (4.457 ms) : 4399, 4514
. : milestone, 4457,
iast (10.099 ms) : 9928, 10271
. : milestone, 10099,
iast_FULL (14.782 ms) : 14491, 15073
. : milestone, 14782,
iast_GLOBAL (10.976 ms) : 10782, 11171
. : milestone, 10976,
profiling (8.706 ms) : 8563, 8848
. : milestone, 8706,
tracing (7.732 ms) : 7623, 7840
. : milestone, 7732,
section candidate
no_agent (4.458 ms) : 4407, 4509
. : milestone, 4458,
iast (10.155 ms) : 9986, 10324
. : milestone, 10155,
iast_FULL (13.886 ms) : 13615, 14158
. : milestone, 13886,
iast_GLOBAL (11.018 ms) : 10821, 11214
. : milestone, 11018,
profiling (8.966 ms) : 8824, 9108
. : milestone, 8966,
tracing (7.686 ms) : 7575, 7798
. : milestone, 7686,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c14f4a0ab6, baseline=1.54.0-SNAPSHOT~6ee44ddde4
dateFormat X
axisFormat %s
section baseline
no_agent (36.223 ms) : 35927, 36519
. : milestone, 36223,
appsec (49.263 ms) : 48810, 49716
. : milestone, 49263,
code_origins (44.525 ms) : 44158, 44893
. : milestone, 44525,
iast (43.66 ms) : 43278, 44042
. : milestone, 43660,
profiling (48.392 ms) : 47870, 48914
. : milestone, 48392,
tracing (43.421 ms) : 43055, 43786
. : milestone, 43421,
section candidate
no_agent (36.575 ms) : 36285, 36865
. : milestone, 36575,
appsec (48.793 ms) : 48370, 49216
. : milestone, 48793,
code_origins (44.376 ms) : 43990, 44763
. : milestone, 44376,
iast (45.561 ms) : 45166, 45955
. : milestone, 45561,
profiling (49.817 ms) : 49383, 50252
. : milestone, 49817,
tracing (43.593 ms) : 43214, 43972
. : milestone, 43593,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c14f4a0ab6, baseline=1.54.0-SNAPSHOT~aadd47174a
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (3.7 ms) : 3483, 3916
. : milestone, 3700,
iast (2.193 ms) : 2130, 2256
. : milestone, 2193,
iast_GLOBAL (2.233 ms) : 2171, 2296
. : milestone, 2233,
profiling (2.064 ms) : 2012, 2116
. : milestone, 2064,
tracing (2.018 ms) : 1969, 2067
. : milestone, 2018,
section candidate
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (3.646 ms) : 3434, 3859
. : milestone, 3646,
iast (2.184 ms) : 2122, 2247
. : milestone, 2184,
iast_GLOBAL (2.234 ms) : 2171, 2296
. : milestone, 2234,
profiling (2.046 ms) : 1994, 2097
. : milestone, 2046,
tracing (2.008 ms) : 1960, 2057
. : milestone, 2008,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c14f4a0ab6, baseline=1.54.0-SNAPSHOT~aadd47174a
dateFormat X
axisFormat %s
section baseline
no_agent (14.937 s) : 14937000, 14937000
. : milestone, 14937000,
appsec (15.02 s) : 15020000, 15020000
. : milestone, 15020000,
iast (18.456 s) : 18456000, 18456000
. : milestone, 18456000,
iast_GLOBAL (18.258 s) : 18258000, 18258000
. : milestone, 18258000,
profiling (15.567 s) : 15567000, 15567000
. : milestone, 15567000,
tracing (15.292 s) : 15292000, 15292000
. : milestone, 15292000,
section candidate
no_agent (14.815 s) : 14815000, 14815000
. : milestone, 14815000,
appsec (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
iast (18.673 s) : 18673000, 18673000
. : milestone, 18673000,
iast_GLOBAL (17.897 s) : 17897000, 17897000
. : milestone, 17897000,
profiling (15.41 s) : 15410000, 15410000
. : milestone, 15410000,
tracing (15.195 s) : 15195000, 15195000
. : milestone, 15195000,
|
mhlidd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've experienced this issue on my local branches as well 🙇
Motivation
This avoids duplicate jar entries from ending up in the agent jar since the refactoring in #9426
Before:
After:
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]