-
Notifications
You must be signed in to change notification settings - Fork 318
Add GraalVM 25 image to CI #9562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: 933519d | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 3 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~933519d61c, baseline=1.55.0-SNAPSHOT~425276dceb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.022 s) : 0, 1021865
Total [baseline] (8.656 s) : 0, 8656449
Agent [candidate] (1.015 s) : 0, 1014889
Total [candidate] (8.627 s) : 0, 8627481
section iast
Agent [baseline] (1.15 s) : 0, 1150181
Total [baseline] (9.277 s) : 0, 9277433
Agent [candidate] (1.159 s) : 0, 1159488
Total [candidate] (9.285 s) : 0, 9284801
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~933519d61c, baseline=1.55.0-SNAPSHOT~425276dceb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (695.905 ms) : 0, 695905
BytebuddyAgent [candidate] (691.108 ms) : 0, 691108
GlobalTracer [baseline] (243.445 ms) : 0, 243445
GlobalTracer [candidate] (241.521 ms) : 0, 241521
AppSec [baseline] (32.88 ms) : 0, 32880
AppSec [candidate] (32.333 ms) : 0, 32333
Debugger [baseline] (6.53 ms) : 0, 6530
Debugger [candidate] (6.419 ms) : 0, 6419
Remote Config [baseline] (694.609 µs) : 0, 695
Remote Config [candidate] (691.275 µs) : 0, 691
Telemetry [baseline] (9.361 ms) : 0, 9361
Telemetry [candidate] (9.31 ms) : 0, 9310
Flare Poller [baseline] (10.381 ms) : 0, 10381
Flare Poller [candidate] (10.971 ms) : 0, 10971
section iast
crashtracking [baseline] (1.51 ms) : 0, 1510
crashtracking [candidate] (1.481 ms) : 0, 1481
BytebuddyAgent [baseline] (814.868 ms) : 0, 814868
BytebuddyAgent [candidate] (821.518 ms) : 0, 821518
GlobalTracer [baseline] (231.045 ms) : 0, 231045
GlobalTracer [candidate] (232.92 ms) : 0, 232920
IAST [baseline] (26.422 ms) : 0, 26422
IAST [candidate] (26.808 ms) : 0, 26808
AppSec [baseline] (35.186 ms) : 0, 35186
AppSec [candidate] (35.277 ms) : 0, 35277
Debugger [baseline] (6.113 ms) : 0, 6113
Debugger [candidate] (6.264 ms) : 0, 6264
Remote Config [baseline] (601.388 µs) : 0, 601
Remote Config [candidate] (615.63 µs) : 0, 616
Telemetry [baseline] (8.648 ms) : 0, 8648
Telemetry [candidate] (8.825 ms) : 0, 8825
Flare Poller [baseline] (4.284 ms) : 0, 4284
Flare Poller [candidate] (4.182 ms) : 0, 4182
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~933519d61c, baseline=1.55.0-SNAPSHOT~425276dceb
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.032 s) : 0, 1031988
Total [baseline] (10.736 s) : 0, 10735533
Agent [candidate] (1.015 s) : 0, 1014722
Total [candidate] (10.642 s) : 0, 10641622
section appsec
Agent [baseline] (1.195 s) : 0, 1194654
Total [baseline] (11.033 s) : 0, 11033465
Agent [candidate] (1.205 s) : 0, 1205264
Total [candidate] (11.044 s) : 0, 11044323
section iast
Agent [baseline] (1.151 s) : 0, 1151343
Total [baseline] (10.979 s) : 0, 10978829
Agent [candidate] (1.153 s) : 0, 1152584
Total [candidate] (10.945 s) : 0, 10945438
section profiling
Agent [baseline] (1.162 s) : 0, 1162308
Total [baseline] (11.065 s) : 0, 11064578
Agent [candidate] (1.161 s) : 0, 1160989
Total [candidate] (10.963 s) : 0, 10963046
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~933519d61c, baseline=1.55.0-SNAPSHOT~425276dceb
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.472 ms) : 0, 1472
crashtracking [candidate] (1.463 ms) : 0, 1463
BytebuddyAgent [baseline] (703.24 ms) : 0, 703240
BytebuddyAgent [candidate] (692.161 ms) : 0, 692161
GlobalTracer [baseline] (245.091 ms) : 0, 245091
GlobalTracer [candidate] (241.62 ms) : 0, 241620
AppSec [baseline] (33.078 ms) : 0, 33078
AppSec [candidate] (32.447 ms) : 0, 32447
Debugger [baseline] (6.6 ms) : 0, 6600
Debugger [candidate] (6.409 ms) : 0, 6409
Remote Config [baseline] (715.713 µs) : 0, 716
Remote Config [candidate] (706.452 µs) : 0, 706
Telemetry [baseline] (9.503 ms) : 0, 9503
Telemetry [candidate] (9.259 ms) : 0, 9259
Flare Poller [baseline] (11.027 ms) : 0, 11027
Flare Poller [candidate] (9.511 ms) : 0, 9511
section appsec
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.495 ms) : 0, 1495
BytebuddyAgent [baseline] (717.233 ms) : 0, 717233
BytebuddyAgent [candidate] (725.213 ms) : 0, 725213
GlobalTracer [baseline] (234.901 ms) : 0, 234901
GlobalTracer [candidate] (235.82 ms) : 0, 235820
AppSec [baseline] (175.961 ms) : 0, 175961
AppSec [candidate] (176.425 ms) : 0, 176425
Debugger [baseline] (6.125 ms) : 0, 6125
Debugger [candidate] (6.274 ms) : 0, 6274
Remote Config [baseline] (631.57 µs) : 0, 632
Remote Config [candidate] (634.838 µs) : 0, 635
Telemetry [baseline] (8.548 ms) : 0, 8548
Telemetry [candidate] (8.795 ms) : 0, 8795
Flare Poller [baseline] (3.933 ms) : 0, 3933
Flare Poller [candidate] (4.013 ms) : 0, 4013
IAST [baseline] (24.801 ms) : 0, 24801
IAST [candidate] (25.362 ms) : 0, 25362
section iast
crashtracking [baseline] (1.491 ms) : 0, 1491
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (815.134 ms) : 0, 815134
BytebuddyAgent [candidate] (816.524 ms) : 0, 816524
GlobalTracer [baseline] (231.756 ms) : 0, 231756
GlobalTracer [candidate] (231.877 ms) : 0, 231877
AppSec [baseline] (35.172 ms) : 0, 35172
AppSec [candidate] (34.094 ms) : 0, 34094
Debugger [baseline] (6.126 ms) : 0, 6126
Debugger [candidate] (6.172 ms) : 0, 6172
Remote Config [baseline] (606.171 µs) : 0, 606
Remote Config [candidate] (606.943 µs) : 0, 607
Telemetry [baseline] (8.668 ms) : 0, 8668
Telemetry [candidate] (8.733 ms) : 0, 8733
Flare Poller [baseline] (4.246 ms) : 0, 4246
Flare Poller [candidate] (4.257 ms) : 0, 4257
IAST [baseline] (26.599 ms) : 0, 26599
IAST [candidate] (26.562 ms) : 0, 26562
section profiling
ProfilingAgent [baseline] (107.559 ms) : 0, 107559
ProfilingAgent [candidate] (107.579 ms) : 0, 107579
crashtracking [baseline] (1.435 ms) : 0, 1435
crashtracking [candidate] (1.427 ms) : 0, 1427
BytebuddyAgent [baseline] (722.22 ms) : 0, 722220
BytebuddyAgent [candidate] (720.941 ms) : 0, 720941
GlobalTracer [baseline] (217.874 ms) : 0, 217874
GlobalTracer [candidate] (218.185 ms) : 0, 218185
AppSec [baseline] (32.268 ms) : 0, 32268
AppSec [candidate] (32.215 ms) : 0, 32215
Debugger [baseline] (6.497 ms) : 0, 6497
Debugger [candidate] (6.477 ms) : 0, 6477
Remote Config [baseline] (788.883 µs) : 0, 789
Remote Config [candidate] (772.832 µs) : 0, 773
Telemetry [baseline] (16.416 ms) : 0, 16416
Telemetry [candidate] (16.247 ms) : 0, 16247
Flare Poller [baseline] (4.128 ms) : 0, 4128
Flare Poller [candidate] (4.124 ms) : 0, 4124
Profiling [baseline] (108.55 ms) : 0, 108550
Profiling [candidate] (108.578 ms) : 0, 108578
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 2 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~933519d61c, baseline=1.55.0-SNAPSHOT~425276dceb
dateFormat X
axisFormat %s
section baseline
no_agent (37.316 ms) : 37013, 37619
. : milestone, 37316,
appsec (51.62 ms) : 51161, 52080
. : milestone, 51620,
code_origins (44.547 ms) : 44146, 44949
. : milestone, 44547,
iast (45.642 ms) : 45249, 46035
. : milestone, 45642,
profiling (47.587 ms) : 47175, 47998
. : milestone, 47587,
tracing (46.114 ms) : 45712, 46515
. : milestone, 46114,
section candidate
no_agent (37.76 ms) : 37455, 38065
. : milestone, 37760,
appsec (49.595 ms) : 49153, 50036
. : milestone, 49595,
code_origins (44.461 ms) : 44075, 44846
. : milestone, 44461,
iast (46.424 ms) : 46000, 46848
. : milestone, 46424,
profiling (45.46 ms) : 45058, 45863
. : milestone, 45460,
tracing (45.577 ms) : 45185, 45969
. : milestone, 45577,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~933519d61c, baseline=1.55.0-SNAPSHOT~425276dceb
dateFormat X
axisFormat %s
section baseline
no_agent (4.303 ms) : 4254, 4351
. : milestone, 4303,
iast (10.328 ms) : 10152, 10504
. : milestone, 10328,
iast_FULL (14.193 ms) : 13907, 14479
. : milestone, 14193,
iast_GLOBAL (10.436 ms) : 10251, 10621
. : milestone, 10436,
profiling (8.813 ms) : 8675, 8951
. : milestone, 8813,
tracing (7.544 ms) : 7438, 7650
. : milestone, 7544,
section candidate
no_agent (4.442 ms) : 4391, 4492
. : milestone, 4442,
iast (9.898 ms) : 9724, 10072
. : milestone, 9898,
iast_FULL (14.544 ms) : 14260, 14827
. : milestone, 14544,
iast_GLOBAL (10.204 ms) : 10024, 10384
. : milestone, 10204,
profiling (9.45 ms) : 9285, 9614
. : milestone, 9450,
tracing (7.902 ms) : 7787, 8016
. : milestone, 7902,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~933519d61c, baseline=1.55.0-SNAPSHOT~425276dceb
dateFormat X
axisFormat %s
section baseline
no_agent (1.474 ms) : 1462, 1486
. : milestone, 1474,
appsec (2.502 ms) : 2448, 2556
. : milestone, 2502,
iast (2.201 ms) : 2138, 2264
. : milestone, 2201,
iast_GLOBAL (2.24 ms) : 2177, 2304
. : milestone, 2240,
profiling (2.046 ms) : 1996, 2097
. : milestone, 2046,
tracing (2.027 ms) : 1977, 2077
. : milestone, 2027,
section candidate
no_agent (1.467 ms) : 1456, 1478
. : milestone, 1467,
appsec (3.675 ms) : 3461, 3890
. : milestone, 3675,
iast (2.202 ms) : 2138, 2265
. : milestone, 2202,
iast_GLOBAL (2.247 ms) : 2184, 2311
. : milestone, 2247,
profiling (2.031 ms) : 1980, 2082
. : milestone, 2031,
tracing (2.02 ms) : 1970, 2069
. : milestone, 2020,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~933519d61c, baseline=1.55.0-SNAPSHOT~425276dceb
dateFormat X
axisFormat %s
section baseline
no_agent (14.843 s) : 14843000, 14843000
. : milestone, 14843000,
appsec (15.078 s) : 15078000, 15078000
. : milestone, 15078000,
iast (18.51 s) : 18510000, 18510000
. : milestone, 18510000,
iast_GLOBAL (18.005 s) : 18005000, 18005000
. : milestone, 18005000,
profiling (15.317 s) : 15317000, 15317000
. : milestone, 15317000,
tracing (14.938 s) : 14938000, 14938000
. : milestone, 14938000,
section candidate
no_agent (15.025 s) : 15025000, 15025000
. : milestone, 15025000,
appsec (15.215 s) : 15215000, 15215000
. : milestone, 15215000,
iast (18.619 s) : 18619000, 18619000
. : milestone, 18619000,
iast_GLOBAL (18.039 s) : 18039000, 18039000
. : milestone, 18039000,
profiling (15.993 s) : 15993000, 15993000
. : milestone, 15993000,
tracing (15.134 s) : 15134000, 15134000
. : milestone, 15134000,
|
506ec84 to
b191c6f
Compare
| // quick build mode, enough for smoke test | ||
| buildArgs.add("-Ob") | ||
| buildArgs.add("-J-javaagent:$agentPath") | ||
| buildArgs.add("-J-Dnet.bytebuddy.safe=false") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed after #9569
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I believe the net.bytebuddy.nexus.disabled flag from #9569 relates to the Nexus mechanism specifically (that uses Unsafe), while this PR's flag is the one that resolves the Cannot get defined package using reflection: Use of Unsafe was disabled by system property error.
76c6260 to
6f9f05d
Compare
PerfectSlayer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 suggestion: If you have a card for, feel free to add it to the TODO so we won't forget the related context :)
What Does This Do
Add GraalVM 25 image to CI
Motivation
Additional Notes
GraalVM 25 fails with JFR initialization. Adding the
-XX:StartFlightRecording=filename=${testJfrDir}/recording.jfrflag to thecreateProcessBuilder()method in thedd-smoke-tests/spring-boot-3.0-native/src/test/groovy/SpringBootNativeInstrumentationTest.groovyfile resolves the issue, but this flag should not be necessary because we're using the Java API to start the recording. Instead of blocking adding the image to CI on this profiling feature, I added aTODOcomment that includes the related Jira ticket: https://datadoghq.atlassian.net/browse/PROF-12742.Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: https://datadoghq.atlassian.net/browse/LANGPLAT-83