Skip to content

Unified timeout of 15 minutes. Improved logic of taking thread and heap dumps. #9552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2025
Merged

Unified timeout of 15 minutes. Improved logic of taking thread and heap dumps. #9552

merged 2 commits into from
Sep 17, 2025

Conversation

@AlexeyKuznetsov-DD
Copy link
Contributor

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Sep 16, 2025

What Does This Do

Unified timeout of 15 minutes. Improved logic of taking thread and heap dumps.

Motivation

Make build configuration simpler.

Additional Notes

Follow up for #9414.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD marked this pull request as ready for review September 16, 2025 22:16
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD requested review from a team as code owners September 16, 2025 22:16
@github-actions
Copy link
Contributor

github-actions bot commented Sep 16, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD self-assigned this Sep 16, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: enhancement Enhancements and improvements comp: testing Testing tag: no release notes Changes to exclude from release notes labels Sep 16, 2025
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD enabled auto-merge (squash) September 17, 2025 01:03
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD enabled auto-merge (squash) September 17, 2025 01:06
@datadog-official
Copy link

datadog-official bot commented Sep 17, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 100.00%
• Total Coverage: 59.64% (-0.03%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: b0ff556 | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/unified-timeouts-and-dumps
git_commit_date 1758053904 1758071149
git_commit_sha c68b54c b0ff556
release_version 1.54.0-SNAPSHOT~c68b54c4d1 1.54.0-SNAPSHOT~b0ff55623f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758073032 1758073032
ci_job_id 1132911090 1132911090
ci_pipeline_id 76697037 76697037
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-tllewcu8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-tllewcu8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 10 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~b0ff55623f, baseline=1.54.0-SNAPSHOT~c68b54c4d1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.057 s) : 0, 1057464
Total [baseline] (10.666 s) : 0, 10666371
Agent [candidate] (1.06 s) : 0, 1060447
Total [candidate] (10.703 s) : 0, 10702651
section appsec
Agent [baseline] (1.246 s) : 0, 1246038
Total [baseline] (11.015 s) : 0, 11015399
Agent [candidate] (1.229 s) : 0, 1228799
Total [candidate] (10.979 s) : 0, 10979356
section iast
Agent [baseline] (1.186 s) : 0, 1185994
Total [baseline] (11.001 s) : 0, 11001091
Agent [candidate] (1.197 s) : 0, 1196689
Total [candidate] (11.075 s) : 0, 11075244
section profiling
Agent [baseline] (1.207 s) : 0, 1207334
Total [baseline] (10.982 s) : 0, 10981791
Agent [candidate] (1.206 s) : 0, 1205692
Total [candidate] (10.836 s) : 0, 10835632
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.057 s -
Agent appsec 1.246 s 188.574 ms (17.8%)
Agent iast 1.186 s 128.53 ms (12.2%)
Agent profiling 1.207 s 149.87 ms (14.2%)
Total tracing 10.666 s -
Total appsec 11.015 s 349.028 ms (3.3%)
Total iast 11.001 s 334.72 ms (3.1%)
Total profiling 10.982 s 315.42 ms (3.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent appsec 1.229 s 168.352 ms (15.9%)
Agent iast 1.197 s 136.242 ms (12.8%)
Agent profiling 1.206 s 145.245 ms (13.7%)
Total tracing 10.703 s -
Total appsec 10.979 s 276.705 ms (2.6%)
Total iast 11.075 s 372.593 ms (3.5%)
Total profiling 10.836 s 132.981 ms (1.2%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~b0ff55623f, baseline=1.54.0-SNAPSHOT~c68b54c4d1

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (730.706 ms) : 0, 730706
BytebuddyAgent [candidate] (732.502 ms) : 0, 732502
GlobalTracer [baseline] (251.995 ms) : 0, 251995
GlobalTracer [candidate] (252.311 ms) : 0, 252311
AppSec [baseline] (30.536 ms) : 0, 30536
AppSec [candidate] (30.549 ms) : 0, 30549
Debugger [baseline] (6.362 ms) : 0, 6362
Debugger [candidate] (6.398 ms) : 0, 6398
Remote Config [baseline] (688.273 µs) : 0, 688
Remote Config [candidate] (680.008 µs) : 0, 680
Telemetry [baseline] (13.919 ms) : 0, 13919
Telemetry [candidate] (15.496 ms) : 0, 15496
section appsec
crashtracking [baseline] (1.467 ms) : 0, 1467
crashtracking [candidate] (1.437 ms) : 0, 1437
BytebuddyAgent [baseline] (763.681 ms) : 0, 763681
BytebuddyAgent [candidate] (752.402 ms) : 0, 752402
GlobalTracer [baseline] (247.855 ms) : 0, 247855
GlobalTracer [candidate] (244.204 ms) : 0, 244204
IAST [baseline] (24.227 ms) : 0, 24227
IAST [candidate] (23.595 ms) : 0, 23595
AppSec [baseline] (172.191 ms) : 0, 172191
AppSec [candidate] (170.967 ms) : 0, 170967
Debugger [baseline] (6.075 ms) : 0, 6075
Debugger [candidate] (5.961 ms) : 0, 5961
Remote Config [baseline] (630.908 µs) : 0, 631
Remote Config [candidate] (634.794 µs) : 0, 635
Telemetry [baseline] (8.563 ms) : 0, 8563
Telemetry [candidate] (8.44 ms) : 0, 8440
section iast
crashtracking [baseline] (1.443 ms) : 0, 1443
crashtracking [candidate] (1.455 ms) : 0, 1455
BytebuddyAgent [baseline] (849.056 ms) : 0, 849056
BytebuddyAgent [candidate] (857.592 ms) : 0, 857592
GlobalTracer [baseline] (248.435 ms) : 0, 248435
GlobalTracer [candidate] (245.777 ms) : 0, 245777
IAST [baseline] (26.049 ms) : 0, 26049
IAST [candidate] (31.313 ms) : 0, 31313
AppSec [baseline] (25.347 ms) : 0, 25347
AppSec [candidate] (24.652 ms) : 0, 24652
Debugger [baseline] (6.01 ms) : 0, 6010
Debugger [candidate] (6.139 ms) : 0, 6139
Remote Config [baseline] (582.83 µs) : 0, 583
Remote Config [candidate] (615.974 µs) : 0, 616
Telemetry [baseline] (8.115 ms) : 0, 8115
Telemetry [candidate] (8.093 ms) : 0, 8093
section profiling
crashtracking [baseline] (1.438 ms) : 0, 1438
crashtracking [candidate] (1.426 ms) : 0, 1426
BytebuddyAgent [baseline] (761.164 ms) : 0, 761164
BytebuddyAgent [candidate] (759.631 ms) : 0, 759631
GlobalTracer [baseline] (232.114 ms) : 0, 232114
GlobalTracer [candidate] (232.232 ms) : 0, 232232
AppSec [baseline] (30.464 ms) : 0, 30464
AppSec [candidate] (30.427 ms) : 0, 30427
Debugger [baseline] (14.314 ms) : 0, 14314
Debugger [candidate] (13.61 ms) : 0, 13610
Remote Config [baseline] (735.249 µs) : 0, 735
Remote Config [candidate] (735.614 µs) : 0, 736
Telemetry [baseline] (8.539 ms) : 0, 8539
Telemetry [candidate] (9.317 ms) : 0, 9317
ProfilingAgent [baseline] (107.527 ms) : 0, 107527
ProfilingAgent [candidate] (107.245 ms) : 0, 107245
Profiling [baseline] (108.159 ms) : 0, 108159
Profiling [candidate] (107.887 ms) : 0, 107887
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~b0ff55623f, baseline=1.54.0-SNAPSHOT~c68b54c4d1

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1059116
Total [baseline] (8.649 s) : 0, 8648945
Agent [candidate] (1.06 s) : 0, 1060076
Total [candidate] (8.614 s) : 0, 8613744
section iast
Agent [baseline] (1.204 s) : 0, 1203665
Total [baseline] (9.278 s) : 0, 9278271
Agent [candidate] (1.187 s) : 0, 1187398
Total [candidate] (9.29 s) : 0, 9290257
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.059 s -
Agent iast 1.204 s 144.55 ms (13.6%)
Total tracing 8.649 s -
Total iast 9.278 s 629.326 ms (7.3%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.06 s -
Agent iast 1.187 s 127.321 ms (12.0%)
Total tracing 8.614 s -
Total iast 9.29 s 676.513 ms (7.9%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~b0ff55623f, baseline=1.54.0-SNAPSHOT~c68b54c4d1

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.475 ms) : 0, 1475
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (729.623 ms) : 0, 729623
BytebuddyAgent [candidate] (731.786 ms) : 0, 731786
GlobalTracer [baseline] (252.932 ms) : 0, 252932
GlobalTracer [candidate] (252.108 ms) : 0, 252108
AppSec [baseline] (30.605 ms) : 0, 30605
AppSec [candidate] (30.575 ms) : 0, 30575
Debugger [baseline] (6.442 ms) : 0, 6442
Debugger [candidate] (6.362 ms) : 0, 6362
Remote Config [baseline] (703.446 µs) : 0, 703
Remote Config [candidate] (695.001 µs) : 0, 695
Telemetry [baseline] (16.275 ms) : 0, 16275
Telemetry [candidate] (16.096 ms) : 0, 16096
section iast
crashtracking [baseline] (1.476 ms) : 0, 1476
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (864.305 ms) : 0, 864305
BytebuddyAgent [candidate] (849.741 ms) : 0, 849741
GlobalTracer [baseline] (248.68 ms) : 0, 248680
GlobalTracer [candidate] (247.125 ms) : 0, 247125
IAST [baseline] (27.789 ms) : 0, 27789
IAST [candidate] (27.765 ms) : 0, 27765
AppSec [baseline] (25.537 ms) : 0, 25537
AppSec [candidate] (25.529 ms) : 0, 25529
Debugger [baseline] (6.056 ms) : 0, 6056
Debugger [candidate] (6.079 ms) : 0, 6079
Remote Config [baseline] (597.857 µs) : 0, 598
Remote Config [candidate] (601.237 µs) : 0, 601
Telemetry [baseline] (8.123 ms) : 0, 8123
Telemetry [candidate] (8.178 ms) : 0, 8178
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/unified-timeouts-and-dumps
git_commit_date 1758053904 1758071149
git_commit_sha c68b54c b0ff556
release_version 1.54.0-SNAPSHOT~c68b54c4d1 1.54.0-SNAPSHOT~b0ff55623f
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1758072703 1758072703
ci_job_id 1132911091 1132911091
ci_pipeline_id 76697037 76697037
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-j796hcnw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-j796hcnw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 4 performance regressions! Performance is the same for 7 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:petclinic:iast:high_load worse
[+1.676ms; +2.535ms] or [+3.781%; +5.718%]		 unstable
[-12.333op/s; +2.783op/s] or [-11.685%; +2.637%]		 46.435ms 100.775op/s 44.330ms 105.550op/s
scenario:load:petclinic:appsec:high_load worse
[+1.385ms; +2.327ms] or [+2.942%; +4.945%]		 unstable
[-11.274op/s; +3.774op/s] or [-11.338%; +3.795%]		 48.918ms 95.688op/s 47.062ms 99.438op/s
scenario:load:petclinic:tracing:high_load better
[-2.067ms; -1.236ms] or [-4.596%; -2.747%]		 unstable
[-3.776op/s; +11.676op/s] or [-3.629%; +11.224%]		 43.330ms 107.975op/s 44.982ms 104.025op/s
scenario:load:petclinic:profiling:high_load worse
[+1.381ms; +2.410ms] or [+2.902%; +5.064%]		 unstable
[-11.104op/s; +3.404op/s] or [-11.282%; +3.459%]		 49.477ms 94.575op/s 47.582ms 98.425op/s
scenario:load:petclinic:no_agent:high_load worse
[+1.341ms; +2.001ms] or [+3.635%; +5.424%]		 unstable
[-13.932op/s; +2.932op/s] or [-10.994%; +2.313%]		 38.569ms 121.225op/s 36.897ms 126.725op/s
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b0ff55623f, baseline=1.54.0-SNAPSHOT~c68b54c4d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.897 ms) : 36597, 37198
.   : milestone, 36897,
appsec (47.062 ms) : 46635, 47489
.   : milestone, 47062,
code_origins (45.091 ms) : 44703, 45480
.   : milestone, 45091,
iast (44.33 ms) : 43953, 44707
.   : milestone, 44330,
profiling (47.582 ms) : 47120, 48044
.   : milestone, 47582,
tracing (44.982 ms) : 44576, 45388
.   : milestone, 44982,
section candidate
no_agent (38.569 ms) : 38256, 38881
.   : milestone, 38569,
appsec (48.918 ms) : 48469, 49366
.   : milestone, 48918,
code_origins (44.609 ms) : 44212, 45006
.   : milestone, 44609,
iast (46.435 ms) : 46016, 46855
.   : milestone, 46435,
profiling (49.477 ms) : 48983, 49971
.   : milestone, 49477,
tracing (43.33 ms) : 42965, 43696
.   : milestone, 43330,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 36.897 ms [36.597 ms, 37.198 ms] -
appsec 47.062 ms [46.635 ms, 47.489 ms] 10.164 ms (27.5%)
code_origins 45.091 ms [44.703 ms, 45.48 ms] 8.194 ms (22.2%)
iast 44.33 ms [43.953 ms, 44.707 ms] 7.433 ms (20.1%)
profiling 47.582 ms [47.12 ms, 48.044 ms] 10.684 ms (29.0%)
tracing 44.982 ms [44.576 ms, 45.388 ms] 8.084 ms (21.9%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 38.569 ms [38.256 ms, 38.881 ms] -
appsec 48.918 ms [48.469 ms, 49.366 ms] 10.349 ms (26.8%)
code_origins 44.609 ms [44.212 ms, 45.006 ms] 6.041 ms (15.7%)
iast 46.435 ms [46.016 ms, 46.855 ms] 7.867 ms (20.4%)
profiling 49.477 ms [48.983 ms, 49.971 ms] 10.909 ms (28.3%)
tracing 43.33 ms [42.965 ms, 43.696 ms] 4.762 ms (12.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~b0ff55623f, baseline=1.54.0-SNAPSHOT~c68b54c4d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.434 ms) : 4384, 4484
.   : milestone, 4434,
iast (9.557 ms) : 9396, 9717
.   : milestone, 9557,
iast_FULL (14.171 ms) : 13892, 14449
.   : milestone, 14171,
iast_GLOBAL (10.713 ms) : 10525, 10901
.   : milestone, 10713,
profiling (8.804 ms) : 8644, 8965
.   : milestone, 8804,
tracing (7.868 ms) : 7750, 7985
.   : milestone, 7868,
section candidate
no_agent (4.451 ms) : 4394, 4508
.   : milestone, 4451,
iast (9.489 ms) : 9331, 9647
.   : milestone, 9489,
iast_FULL (13.85 ms) : 13575, 14125
.   : milestone, 13850,
iast_GLOBAL (10.595 ms) : 10393, 10798
.   : milestone, 10595,
profiling (9.06 ms) : 8917, 9202
.   : milestone, 9060,
tracing (7.798 ms) : 7689, 7908
.   : milestone, 7798,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.434 ms [4.384 ms, 4.484 ms] -
iast 9.557 ms [9.396 ms, 9.717 ms] 5.123 ms (115.6%)
iast_FULL 14.171 ms [13.892 ms, 14.449 ms] 9.737 ms (219.6%)
iast_GLOBAL 10.713 ms [10.525 ms, 10.901 ms] 6.28 ms (141.6%)
profiling 8.804 ms [8.644 ms, 8.965 ms] 4.371 ms (98.6%)
tracing 7.868 ms [7.75 ms, 7.985 ms] 3.434 ms (77.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.451 ms [4.394 ms, 4.508 ms] -
iast 9.489 ms [9.331 ms, 9.647 ms] 5.038 ms (113.2%)
iast_FULL 13.85 ms [13.575 ms, 14.125 ms] 9.399 ms (211.2%)
iast_GLOBAL 10.595 ms [10.393 ms, 10.798 ms] 6.144 ms (138.0%)
profiling 9.06 ms [8.917 ms, 9.202 ms] 4.609 ms (103.5%)
tracing 7.798 ms [7.689 ms, 7.908 ms] 3.347 ms (75.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/unified-timeouts-and-dumps
git_commit_date 1758053904 1758071149
git_commit_sha c68b54c b0ff556
release_version 1.54.0-SNAPSHOT~c68b54c4d1 1.54.0-SNAPSHOT~b0ff55623f
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1758073195 1758073195
ci_job_id 1132911092 1132911092
ci_pipeline_id 76697037 76697037
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-ieiqwj7b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-ieiqwj7b 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b0ff55623f, baseline=1.54.0-SNAPSHOT~c68b54c4d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.963 s) : 14963000, 14963000
.   : milestone, 14963000,
appsec (14.762 s) : 14762000, 14762000
.   : milestone, 14762000,
iast (18.741 s) : 18741000, 18741000
.   : milestone, 18741000,
iast_GLOBAL (17.936 s) : 17936000, 17936000
.   : milestone, 17936000,
profiling (15.348 s) : 15348000, 15348000
.   : milestone, 15348000,
tracing (14.808 s) : 14808000, 14808000
.   : milestone, 14808000,
section candidate
no_agent (14.953 s) : 14953000, 14953000
.   : milestone, 14953000,
appsec (14.992 s) : 14992000, 14992000
.   : milestone, 14992000,
iast (18.697 s) : 18697000, 18697000
.   : milestone, 18697000,
iast_GLOBAL (18.345 s) : 18345000, 18345000
.   : milestone, 18345000,
profiling (15.314 s) : 15314000, 15314000
.   : milestone, 15314000,
tracing (15.228 s) : 15228000, 15228000
.   : milestone, 15228000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.963 s [14.963 s, 14.963 s] -
appsec 14.762 s [14.762 s, 14.762 s] -201.0 ms (-1.3%)
iast 18.741 s [18.741 s, 18.741 s] 3.778 s (25.2%)
iast_GLOBAL 17.936 s [17.936 s, 17.936 s] 2.973 s (19.9%)
profiling 15.348 s [15.348 s, 15.348 s] 385.0 ms (2.6%)
tracing 14.808 s [14.808 s, 14.808 s] -155.0 ms (-1.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.953 s [14.953 s, 14.953 s] -
appsec 14.992 s [14.992 s, 14.992 s] 39.0 ms (0.3%)
iast 18.697 s [18.697 s, 18.697 s] 3.744 s (25.0%)
iast_GLOBAL 18.345 s [18.345 s, 18.345 s] 3.392 s (22.7%)
profiling 15.314 s [15.314 s, 15.314 s] 361.0 ms (2.4%)
tracing 15.228 s [15.228 s, 15.228 s] 275.0 ms (1.8%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~b0ff55623f, baseline=1.54.0-SNAPSHOT~c68b54c4d1
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
.   : milestone, 1475,
appsec (3.705 ms) : 3488, 3921
.   : milestone, 3705,
iast (2.184 ms) : 2122, 2245
.   : milestone, 2184,
iast_GLOBAL (2.249 ms) : 2185, 2312
.   : milestone, 2249,
profiling (2.05 ms) : 1999, 2101
.   : milestone, 2050,
tracing (2.028 ms) : 1979, 2078
.   : milestone, 2028,
section candidate
no_agent (1.474 ms) : 1463, 1486
.   : milestone, 1474,
appsec (3.702 ms) : 3486, 3918
.   : milestone, 3702,
iast (2.199 ms) : 2137, 2262
.   : milestone, 2199,
iast_GLOBAL (2.245 ms) : 2182, 2308
.   : milestone, 2245,
profiling (2.048 ms) : 1997, 2099
.   : milestone, 2048,
tracing (2.024 ms) : 1975, 2073
.   : milestone, 2024,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.475 ms [1.463 ms, 1.486 ms] -
appsec 3.705 ms [3.488 ms, 3.921 ms] 2.23 ms (151.2%)
iast 2.184 ms [2.122 ms, 2.245 ms] 708.676 µs (48.1%)
iast_GLOBAL 2.249 ms [2.185 ms, 2.312 ms] 773.807 µs (52.5%)
profiling 2.05 ms [1.999 ms, 2.101 ms] 575.041 µs (39.0%)
tracing 2.028 ms [1.979 ms, 2.078 ms] 553.237 µs (37.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.474 ms [1.463 ms, 1.486 ms] -
appsec 3.702 ms [3.486 ms, 3.918 ms] 2.228 ms (151.1%)
iast 2.199 ms [2.137 ms, 2.262 ms] 724.928 µs (49.2%)
iast_GLOBAL 2.245 ms [2.182 ms, 2.308 ms] 771.035 µs (52.3%)
profiling 2.048 ms [1.997 ms, 2.099 ms] 573.807 µs (38.9%)
tracing 2.024 ms [1.975 ms, 2.073 ms] 549.206 µs (37.3%)

@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2025

Kafka / producer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/unified-timeouts-and-dumps
git_commit_date 1758053904 1758071149
git_commit_sha c68b54c b0ff556
See matching parameters
Baseline Candidate
ci_job_date 1758072259 1758072259
ci_job_id 1132911095 1132911095
ci_pipeline_id 76697037 76697037
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/producer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaProduceBenchmark.benchProduce same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaProduceBenchmark.benchProduce same

@pr-commenter
Copy link

pr-commenter bot commented Sep 17, 2025

Kafka / consumer-benchmark

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master alexeyk/unified-timeouts-and-dumps
git_commit_date 1758053904 1758071149
git_commit_sha c68b54c b0ff556
See matching parameters
Baseline Candidate
ci_job_date 1758072298 1758072298
ci_job_id 1132911096 1132911096
ci_pipeline_id 76697037 76697037
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
jdkVersion 11.0.25 11.0.25
jmhVersion 1.36 1.36
jvm /usr/lib/jvm/java-11-openjdk-amd64/bin/java /usr/lib/jvm/java-11-openjdk-amd64/bin/java
jvmArgs -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant -Dfile.encoding=UTF-8 -Djava.io.tmpdir=/go/src/github.com/DataDog/apm-reliability/dd-trace-java/platform/src/consumer-benchmark/build/tmp/jmh -Duser.country=US -Duser.language=en -Duser.variant
vmName OpenJDK 64-Bit Server VM OpenJDK 64-Bit Server VM
vmVersion 11.0.25+9-post-Ubuntu-1ubuntu122.04 11.0.25+9-post-Ubuntu-1ubuntu122.04

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean throughput
scenario:not-instrumented/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-disabled-benchmarks/KafkaConsumerBenchmark.benchConsume same
scenario:only-tracing-dsm-enabled-benchmarks/KafkaConsumerBenchmark.benchConsume same

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD merged commit de79e08 into master Sep 17, 2025
511 checks passed
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD deleted the alexeyk/unified-timeouts-and-dumps branch September 17, 2025 11:59
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 17, 2025
bric3
bric3 reviewed Sep 23, 2025
View reviewed changes
Copy link
Contributor

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification !

gradle/dump_hanging_test.gradle
// For simplicity, use `0` as the PID, which collects all thread dumps across JVMs.
// Single file can be useful for quick search.
def threadDumpsFile = new File(dumpsDir, "all-thread-dumps-${System.currentTimeMillis()}.log")
new ProcessBuilder("jcmd", "0", "Thread.print", "-l")
Copy link
Contributor

@bric3 bric3 Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I learned that using 0 would send the command to all JVM processes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bric3 bric3 bric3 left review comments

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@Mariovido Mariovido Awaiting requested review from Mariovido Mariovido is a code owner automatically assigned from DataDog/ci-app-libraries-java

@sarahchen6 sarahchen6 Awaiting requested review from sarahchen6

Assignees

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexeyKuznetsov-DD @bric3 @PerfectSlayer