Skip to content

Ensure tracer and scheduler are clean after test execution #9512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2025
Merged

Ensure tracer and scheduler are clean after test execution #9512

merged 2 commits into from
Sep 11, 2025

Conversation

@amarziali
Copy link
Contributor

@amarziali amarziali commented Sep 11, 2025 •
edited
Loading

What Does This Do

On DDCoreSpecification we spawn tracers. The first issue is that those tracers are not (always) closed and they might leak scheduled (repeated) tasks (like Health reporting, telemetry, metrics calculation) that accumulates in the AgentThreadScheduler queue.
To mitigate that, this PR decorates the DDCoreTracerBuilder returned on DDCoreSpecification by recording the opened tracers and closing them when the test terminates.

Secondly, we have things that are scheduled with jitter (i.e. metrics calculation) that can be spawn after the test is completed (i.e. the test is quicker than the jitter). Hence they are stale on the scheduler and accumulates. They will hold memory and, in case for instance the agent metrics are enabled, the tests will finish to fail for OOM.

This PR is also removing the final modifier to the AgentTaskScheduler INSTANCE (hence only exposing publicly a getter now) in order to be able to shutdown it after each test class and reset with a new one.

Please note that I tried to find alternate solution to avoid removing final (i.e. play with Unsafe, etc..) but it resulted in having to deal with Unsafe that is not very portable across jdk and also, static final things might be inlined so I preferred that easier solution.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@amarziali amarziali requested a review from a team as a code owner September 11, 2025 08:13
@amarziali amarziali added the comp: testing Testing label Sep 11, 2025
@amarziali amarziali requested review from a team as code owners September 11, 2025 08:13
@amarziali amarziali requested review from a team as code owners September 11, 2025 08:13
@amarziali amarziali requested review from bric3, evanchooly, manuel-alvarez-alvarez, mcculls and smola and removed request for a team September 11, 2025 08:13
@amarziali amarziali force-pushed the andrea.marziali/better-ddcorespec branch from 512699a to 0c57e15 Compare September 11, 2025 08:16
@pr-commenter
Copy link

pr-commenter bot commented Sep 11, 2025 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1757583477 1757583823
end_time 2025-09-11T09:39:18 2025-09-11T09:45:04
git_branch master andrea.marziali/better-ddcorespec
git_commit_sha b84c018 d81fa1b
start_time 2025-09-11T09:37:58 2025-09-11T09:43:44
See matching parameters
Baseline Candidate
ci_job_id 1124109336 1124109336
ci_pipeline_id 76167614 76167614
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1757582902 1757582902

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 9 metrics, 6 unstable metrics.

See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-54.204µs; +22.654µs] or [-18.687%; +7.810%]		 unstable
[-70.033µs; +29.868µs] or [-21.014%; +8.962%]		 unstable
[-80.665µs; +36.436µs] or [-23.145%; +10.454%]		 unstable
[-567.443µs; +211.692µs] or [-48.147%; +17.962%]		 same
scenario:basic same same same unstable
[+32.665µs; +244.139µs] or [+4.457%; +33.315%]		 unstable
[-90.801op/s; +233.049op/s] or [-3.450%; +8.856%]
scenario:loop unsure
[+6.312µs; +14.380µs] or [+0.071%; +0.162%]		 unsure
[+6.579µs; +17.500µs] or [+0.073%; +0.195%]		 unsure
[+1.745µs; +14.718µs] or [+0.019%; +0.163%]		 same same
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (333.27 µs) : 271, 396
.   : milestone, 333,
basic (278.855 µs) : 270, 287
.   : milestone, 279,
loop (8.961 ms) : 8956, 8966
.   : milestone, 8961,
section candidate
noprobe (313.188 µs) : 288, 338
.   : milestone, 313,
basic (276.736 µs) : 270, 284
.   : milestone, 277,
loop (8.973 ms) : 8968, 8978
.   : milestone, 8973,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 333.27 µs [270.769 µs, 395.772 µs]
basic 278.855 µs [270.447 µs, 287.262 µs]
loop 8.961 ms [8.956 ms, 8.966 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 313.188 µs [288.372 µs, 338.004 µs]
basic 276.736 µs [269.897 µs, 283.576 µs]
loop 8.973 ms [8.968 ms, 8.978 ms]

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Sep 11, 2025 •
edited
Loading

🎯 Code Coverage
• Patch Coverage: 47.27%
• Total Coverage: 60.24% (+0.12%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: d81fa1b | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Sep 11, 2025 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/better-ddcorespec
git_commit_date 1757580581 1757582902
git_commit_sha b84c018 d81fa1b
release_version 1.54.0-SNAPSHOT~b84c0183bc 1.54.0-SNAPSHOT~d81fa1b078
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757584756 1757584756
ci_job_id 1124109329 1124109329
ci_pipeline_id 76167614 76167614
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-lkusdrkg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-lkusdrkg 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 13 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~d81fa1b078, baseline=1.54.0-SNAPSHOT~b84c0183bc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.045 s) : 0, 1044865
Total [baseline] (8.644 s) : 0, 8643917
Agent [candidate] (1.047 s) : 0, 1046653
Total [candidate] (8.626 s) : 0, 8625778
section iast
Agent [baseline] (1.187 s) : 0, 1187041
Total [baseline] (9.371 s) : 0, 9371113
Agent [candidate] (1.189 s) : 0, 1188684
Total [candidate] (9.352 s) : 0, 9352326
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.045 s -
Agent iast 1.187 s 142.176 ms (13.6%)
Total tracing 8.644 s -
Total iast 9.371 s 727.196 ms (8.4%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.047 s -
Agent iast 1.189 s 142.031 ms (13.6%)
Total tracing 8.626 s -
Total iast 9.352 s 726.548 ms (8.4%) 
gantt
    title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~d81fa1b078, baseline=1.54.0-SNAPSHOT~b84c0183bc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.479 ms) : 0, 1479
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (730.683 ms) : 0, 730683
BytebuddyAgent [candidate] (731.935 ms) : 0, 731935
GlobalTracer [baseline] (241.872 ms) : 0, 241872
GlobalTracer [candidate] (242.451 ms) : 0, 242451
AppSec [baseline] (30.503 ms) : 0, 30503
AppSec [candidate] (30.314 ms) : 0, 30314
Debugger [baseline] (6.418 ms) : 0, 6418
Debugger [candidate] (6.416 ms) : 0, 6416
Remote Config [baseline] (692.868 µs) : 0, 693
Remote Config [candidate] (672.166 µs) : 0, 672
Telemetry [baseline] (12.199 ms) : 0, 12199
Telemetry [candidate] (12.358 ms) : 0, 12358
section iast
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.467 ms) : 0, 1467
BytebuddyAgent [baseline] (856.762 ms) : 0, 856762
BytebuddyAgent [candidate] (858.368 ms) : 0, 858368
GlobalTracer [baseline] (233.945 ms) : 0, 233945
GlobalTracer [candidate] (233.953 ms) : 0, 233953
IAST [baseline] (31.351 ms) : 0, 31351
IAST [candidate] (30.519 ms) : 0, 30519
AppSec [baseline] (27.292 ms) : 0, 27292
AppSec [candidate] (28.218 ms) : 0, 28218
Debugger [baseline] (6.163 ms) : 0, 6163
Debugger [candidate] (6.136 ms) : 0, 6136
Remote Config [baseline] (614.542 µs) : 0, 615
Remote Config [candidate] (605.872 µs) : 0, 606
Telemetry [baseline] (8.398 ms) : 0, 8398
Telemetry [candidate] (8.291 ms) : 0, 8291
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~d81fa1b078, baseline=1.54.0-SNAPSHOT~b84c0183bc

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050265
Total [baseline] (10.676 s) : 0, 10675571
Agent [candidate] (1.061 s) : 0, 1060503
Total [candidate] (10.826 s) : 0, 10825973
section appsec
Agent [baseline] (1.222 s) : 0, 1222086
Total [baseline] (10.859 s) : 0, 10858981
Agent [candidate] (1.231 s) : 0, 1230808
Total [candidate] (10.919 s) : 0, 10918792
section iast
Agent [baseline] (1.18 s) : 0, 1180493
Total [baseline] (10.969 s) : 0, 10969492
Agent [candidate] (1.182 s) : 0, 1181665
Total [candidate] (10.934 s) : 0, 10933876
section profiling
Agent [baseline] (1.198 s) : 0, 1197941
Total [baseline] (10.891 s) : 0, 10890564
Agent [candidate] (1.208 s) : 0, 1207743
Total [candidate] (11.016 s) : 0, 11016332
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.05 s -
Agent appsec 1.222 s 171.821 ms (16.4%)
Agent iast 1.18 s 130.228 ms (12.4%)
Agent profiling 1.198 s 147.677 ms (14.1%)
Total tracing 10.676 s -
Total appsec 10.859 s 183.41 ms (1.7%)
Total iast 10.969 s 293.921 ms (2.8%)
Total profiling 10.891 s 214.993 ms (2.0%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.061 s -
Agent appsec 1.231 s 170.305 ms (16.1%)
Agent iast 1.182 s 121.162 ms (11.4%)
Agent profiling 1.208 s 147.24 ms (13.9%)
Total tracing 10.826 s -
Total appsec 10.919 s 92.819 ms (0.9%)
Total iast 10.934 s 107.903 ms (1.0%)
Total profiling 11.016 s 190.359 ms (1.8%) 
gantt
    title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~d81fa1b078, baseline=1.54.0-SNAPSHOT~b84c0183bc

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.45 ms) : 0, 1450
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (732.456 ms) : 0, 732456
BytebuddyAgent [candidate] (740.898 ms) : 0, 740898
GlobalTracer [baseline] (242.517 ms) : 0, 242517
GlobalTracer [candidate] (245.407 ms) : 0, 245407
AppSec [baseline] (30.338 ms) : 0, 30338
AppSec [candidate] (30.985 ms) : 0, 30985
Debugger [baseline] (6.452 ms) : 0, 6452
Debugger [candidate] (6.472 ms) : 0, 6472
Remote Config [baseline] (681.088 µs) : 0, 681
Remote Config [candidate] (688.965 µs) : 0, 689
Telemetry [baseline] (15.278 ms) : 0, 15278
Telemetry [candidate] (13.271 ms) : 0, 13271
section appsec
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (754.173 ms) : 0, 754173
BytebuddyAgent [candidate] (758.894 ms) : 0, 758894
GlobalTracer [baseline] (235.157 ms) : 0, 235157
GlobalTracer [candidate] (237.293 ms) : 0, 237293
AppSec [baseline] (169.474 ms) : 0, 169474
AppSec [candidate] (169.875 ms) : 0, 169875
Debugger [baseline] (8.289 ms) : 0, 8289
Debugger [candidate] (8.396 ms) : 0, 8396
Remote Config [baseline] (643.424 µs) : 0, 643
Remote Config [candidate] (628.883 µs) : 0, 629
Telemetry [baseline] (8.423 ms) : 0, 8423
Telemetry [candidate] (9.248 ms) : 0, 9248
IAST [baseline] (23.48 ms) : 0, 23480
IAST [candidate] (23.896 ms) : 0, 23896
section iast
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.444 ms) : 0, 1444
BytebuddyAgent [baseline] (851.204 ms) : 0, 851204
BytebuddyAgent [candidate] (852.63 ms) : 0, 852630
GlobalTracer [baseline] (233.179 ms) : 0, 233179
GlobalTracer [candidate] (234.4 ms) : 0, 234400
AppSec [baseline] (26.421 ms) : 0, 26421
AppSec [candidate] (25.303 ms) : 0, 25303
Debugger [baseline] (8.759 ms) : 0, 8759
Debugger [candidate] (6.109 ms) : 0, 6109
Remote Config [baseline] (607.288 µs) : 0, 607
Remote Config [candidate] (615.699 µs) : 0, 616
Telemetry [baseline] (9.107 ms) : 0, 9107
Telemetry [candidate] (8.21 ms) : 0, 8210
IAST [baseline] (28.587 ms) : 0, 28587
IAST [candidate] (31.87 ms) : 0, 31870
section profiling
ProfilingAgent [baseline] (109.044 ms) : 0, 109044
ProfilingAgent [candidate] (108.755 ms) : 0, 108755
crashtracking [baseline] (1.436 ms) : 0, 1436
crashtracking [candidate] (1.451 ms) : 0, 1451
BytebuddyAgent [baseline] (760.304 ms) : 0, 760304
BytebuddyAgent [candidate] (766.668 ms) : 0, 766668
GlobalTracer [baseline] (222.923 ms) : 0, 222923
GlobalTracer [candidate] (224.655 ms) : 0, 224655
AppSec [baseline] (30.583 ms) : 0, 30583
AppSec [candidate] (31.064 ms) : 0, 31064
Debugger [baseline] (7.378 ms) : 0, 7378
Debugger [candidate] (7.61 ms) : 0, 7610
Remote Config [baseline] (686.956 µs) : 0, 687
Remote Config [candidate] (718.53 µs) : 0, 719
Telemetry [baseline] (15.021 ms) : 0, 15021
Telemetry [candidate] (15.871 ms) : 0, 15871
Profiling [baseline] (109.742 ms) : 0, 109742
Profiling [candidate] (109.474 ms) : 0, 109474
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/better-ddcorespec
git_commit_date 1757580581 1757582902
git_commit_sha b84c018 d81fa1b
release_version 1.54.0-SNAPSHOT~b84c0183bc 1.54.0-SNAPSHOT~d81fa1b078
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1757584406 1757584406
ci_job_id 1124109330 1124109330
ci_pipeline_id 76167614 76167614
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-1-2hrplv2k 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-1-2hrplv2k 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 12 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d81fa1b078, baseline=1.54.0-SNAPSHOT~b84c0183bc
    dateFormat X
    axisFormat %s
section baseline
no_agent (37.891 ms) : 37580, 38202
.   : milestone, 37891,
appsec (48.862 ms) : 48431, 49294
.   : milestone, 48862,
code_origins (46.264 ms) : 45865, 46663
.   : milestone, 46264,
iast (45.543 ms) : 45161, 45926
.   : milestone, 45543,
profiling (49.433 ms) : 48968, 49898
.   : milestone, 49433,
tracing (43.561 ms) : 43197, 43925
.   : milestone, 43561,
section candidate
no_agent (37.589 ms) : 37283, 37895
.   : milestone, 37589,
appsec (49.014 ms) : 48560, 49467
.   : milestone, 49014,
code_origins (46.832 ms) : 46433, 47231
.   : milestone, 46832,
iast (44.594 ms) : 44202, 44987
.   : milestone, 44594,
profiling (49.55 ms) : 49058, 50042
.   : milestone, 49550,
tracing (44.293 ms) : 43930, 44656
.   : milestone, 44293,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.891 ms [37.58 ms, 38.202 ms] -
appsec 48.862 ms [48.431 ms, 49.294 ms] 10.971 ms (29.0%)
code_origins 46.264 ms [45.865 ms, 46.663 ms] 8.373 ms (22.1%)
iast 45.543 ms [45.161 ms, 45.926 ms] 7.652 ms (20.2%)
profiling 49.433 ms [48.968 ms, 49.898 ms] 11.541 ms (30.5%)
tracing 43.561 ms [43.197 ms, 43.925 ms] 5.669 ms (15.0%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 37.589 ms [37.283 ms, 37.895 ms] -
appsec 49.014 ms [48.56 ms, 49.467 ms] 11.425 ms (30.4%)
code_origins 46.832 ms [46.433 ms, 47.231 ms] 9.243 ms (24.6%)
iast 44.594 ms [44.202 ms, 44.987 ms] 7.006 ms (18.6%)
profiling 49.55 ms [49.058 ms, 50.042 ms] 11.961 ms (31.8%)
tracing 44.293 ms [43.93 ms, 44.656 ms] 6.704 ms (17.8%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~d81fa1b078, baseline=1.54.0-SNAPSHOT~b84c0183bc
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.365 ms) : 4309, 4420
.   : milestone, 4365,
iast (9.553 ms) : 9397, 9708
.   : milestone, 9553,
iast_FULL (14.099 ms) : 13817, 14381
.   : milestone, 14099,
iast_GLOBAL (10.399 ms) : 10219, 10580
.   : milestone, 10399,
profiling (8.904 ms) : 8758, 9049
.   : milestone, 8904,
tracing (7.844 ms) : 7730, 7958
.   : milestone, 7844,
section candidate
no_agent (4.466 ms) : 4414, 4519
.   : milestone, 4466,
iast (9.531 ms) : 9372, 9690
.   : milestone, 9531,
iast_FULL (14.089 ms) : 13811, 14367
.   : milestone, 14089,
iast_GLOBAL (10.47 ms) : 10272, 10669
.   : milestone, 10470,
profiling (8.858 ms) : 8703, 9014
.   : milestone, 8858,
tracing (7.759 ms) : 7647, 7870
.   : milestone, 7759,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.365 ms [4.309 ms, 4.42 ms] -
iast 9.553 ms [9.397 ms, 9.708 ms] 5.188 ms (118.9%)
iast_FULL 14.099 ms [13.817 ms, 14.381 ms] 9.734 ms (223.0%)
iast_GLOBAL 10.399 ms [10.219 ms, 10.58 ms] 6.035 ms (138.3%)
profiling 8.904 ms [8.758 ms, 9.049 ms] 4.539 ms (104.0%)
tracing 7.844 ms [7.73 ms, 7.958 ms] 3.479 ms (79.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.466 ms [4.414 ms, 4.519 ms] -
iast 9.531 ms [9.372 ms, 9.69 ms] 5.064 ms (113.4%)
iast_FULL 14.089 ms [13.811 ms, 14.367 ms] 9.623 ms (215.5%)
iast_GLOBAL 10.47 ms [10.272 ms, 10.669 ms] 6.004 ms (134.4%)
profiling 8.858 ms [8.703 ms, 9.014 ms] 4.392 ms (98.3%)
tracing 7.759 ms [7.647 ms, 7.87 ms] 3.292 ms (73.7%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master andrea.marziali/better-ddcorespec
git_commit_date 1757580581 1757582902
git_commit_sha b84c018 d81fa1b
release_version 1.54.0-SNAPSHOT~b84c0183bc 1.54.0-SNAPSHOT~d81fa1b078
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1757584929 1757584929
ci_job_id 1124109331 1124109331
ci_pipeline_id 76167614 76167614
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-0-1tb93w9z 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-0-1tb93w9z 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d81fa1b078, baseline=1.54.0-SNAPSHOT~b84c0183bc
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.487 ms) : 1475, 1498
.   : milestone, 1487,
appsec (3.693 ms) : 3476, 3910
.   : milestone, 3693,
iast (2.225 ms) : 2163, 2288
.   : milestone, 2225,
iast_GLOBAL (2.266 ms) : 2202, 2329
.   : milestone, 2266,
profiling (2.066 ms) : 2015, 2118
.   : milestone, 2066,
tracing (2.027 ms) : 1979, 2076
.   : milestone, 2027,
section candidate
no_agent (1.491 ms) : 1479, 1503
.   : milestone, 1491,
appsec (3.73 ms) : 3511, 3948
.   : milestone, 3730,
iast (2.216 ms) : 2153, 2278
.   : milestone, 2216,
iast_GLOBAL (2.263 ms) : 2200, 2327
.   : milestone, 2263,
profiling (2.057 ms) : 2006, 2107
.   : milestone, 2057,
tracing (2.037 ms) : 1988, 2086
.   : milestone, 2037,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.487 ms [1.475 ms, 1.498 ms] -
appsec 3.693 ms [3.476 ms, 3.91 ms] 2.206 ms (148.4%)
iast 2.225 ms [2.163 ms, 2.288 ms] 738.929 µs (49.7%)
iast_GLOBAL 2.266 ms [2.202 ms, 2.329 ms] 779.063 µs (52.4%)
profiling 2.066 ms [2.015 ms, 2.118 ms] 579.917 µs (39.0%)
tracing 2.027 ms [1.979 ms, 2.076 ms] 540.749 µs (36.4%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.491 ms [1.479 ms, 1.503 ms] -
appsec 3.73 ms [3.511 ms, 3.948 ms] 2.239 ms (150.2%)
iast 2.216 ms [2.153 ms, 2.278 ms] 724.681 µs (48.6%)
iast_GLOBAL 2.263 ms [2.2 ms, 2.327 ms] 772.538 µs (51.8%)
profiling 2.057 ms [2.006 ms, 2.107 ms] 566.018 µs (38.0%)
tracing 2.037 ms [1.988 ms, 2.086 ms] 546.346 µs (36.6%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~d81fa1b078, baseline=1.54.0-SNAPSHOT~b84c0183bc
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.646 s) : 15646000, 15646000
.   : milestone, 15646000,
appsec (14.913 s) : 14913000, 14913000
.   : milestone, 14913000,
iast (18.39 s) : 18390000, 18390000
.   : milestone, 18390000,
iast_GLOBAL (17.939 s) : 17939000, 17939000
.   : milestone, 17939000,
profiling (15.295 s) : 15295000, 15295000
.   : milestone, 15295000,
tracing (15.166 s) : 15166000, 15166000
.   : milestone, 15166000,
section candidate
no_agent (14.917 s) : 14917000, 14917000
.   : milestone, 14917000,
appsec (14.736 s) : 14736000, 14736000
.   : milestone, 14736000,
iast (18.388 s) : 18388000, 18388000
.   : milestone, 18388000,
iast_GLOBAL (17.882 s) : 17882000, 17882000
.   : milestone, 17882000,
profiling (16.081 s) : 16081000, 16081000
.   : milestone, 16081000,
tracing (15.155 s) : 15155000, 15155000
.   : milestone, 15155000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.646 s [15.646 s, 15.646 s] -
appsec 14.913 s [14.913 s, 14.913 s] -733.0 ms (-4.7%)
iast 18.39 s [18.39 s, 18.39 s] 2.744 s (17.5%)
iast_GLOBAL 17.939 s [17.939 s, 17.939 s] 2.293 s (14.7%)
profiling 15.295 s [15.295 s, 15.295 s] -351.0 ms (-2.2%)
tracing 15.166 s [15.166 s, 15.166 s] -480.0 ms (-3.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.917 s [14.917 s, 14.917 s] -
appsec 14.736 s [14.736 s, 14.736 s] -181.0 ms (-1.2%)
iast 18.388 s [18.388 s, 18.388 s] 3.471 s (23.3%)
iast_GLOBAL 17.882 s [17.882 s, 17.882 s] 2.965 s (19.9%)
profiling 16.081 s [16.081 s, 16.081 s] 1.164 s (7.8%)
tracing 15.155 s [15.155 s, 15.155 s] 238.0 ms (1.6%)

smola
smola approved these changes Sep 11, 2025
View reviewed changes
Copy link
Member

@smola smola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes relevant to security products look fine.

PerfectSlayer
PerfectSlayer approved these changes Sep 11, 2025
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 praise: ‏Thanks for the fix! And the follow up changes regarding to my comments 🤝

@amarziali amarziali merged commit 4135f1d into master Sep 11, 2025
510 checks passed
@amarziali amarziali deleted the andrea.marziali/better-ddcorespec branch September 11, 2025 12:42
@github-actions github-actions bot added this to the 1.54.0 milestone Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smola smola smola approved these changes

@mcculls mcculls mcculls approved these changes

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@jpbempel jpbempel jpbempel approved these changes

@evanchooly evanchooly Awaiting requested review from evanchooly evanchooly is a code owner automatically assigned from DataDog/debugger-java

@manuel-alvarez-alvarez manuel-alvarez-alvarez Awaiting requested review from manuel-alvarez-alvarez manuel-alvarez-alvarez is a code owner automatically assigned from DataDog/asm-java

@bric3 bric3 Awaiting requested review from bric3 bric3 is a code owner automatically assigned from DataDog/apm-lang-platform-java

Assignees

No one assigned

Labels

comp: testing Testing type: refactoring

Projects

None yet

Milestone

1.54.0

Development

Successfully merging this pull request may close these issues.

6 participants

@amarziali @smola @mcculls @PerfectSlayer @jpbempel