-
Notifications
You must be signed in to change notification settings - Fork 318
Properly handle user provided crash/oome script paths #9496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🎯 Code Coverage 🔗 Commit SHA: c1deff6 | Docs | Was this helpful? Give us feedback! |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 15 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.54.0-SNAPSHOT~c1deff6c8b, baseline=1.54.0-SNAPSHOT~c5b6e464e4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.047 s) : 0, 1046958
Total [baseline] (10.731 s) : 0, 10731291
Agent [candidate] (1.053 s) : 0, 1052576
Total [candidate] (10.583 s) : 0, 10583257
section appsec
Agent [baseline] (1.225 s) : 0, 1224716
Total [baseline] (10.795 s) : 0, 10794806
Agent [candidate] (1.222 s) : 0, 1222386
Total [candidate] (10.749 s) : 0, 10748971
section iast
Agent [baseline] (1.186 s) : 0, 1186480
Total [baseline] (10.907 s) : 0, 10907050
Agent [candidate] (1.186 s) : 0, 1186341
Total [candidate] (10.893 s) : 0, 10893410
section profiling
Agent [baseline] (1.198 s) : 0, 1197536
Total [baseline] (10.859 s) : 0, 10859156
Agent [candidate] (1.211 s) : 0, 1211047
Total [candidate] (10.925 s) : 0, 10924745
gantt
title petclinic - break down per module: candidate=1.54.0-SNAPSHOT~c1deff6c8b, baseline=1.54.0-SNAPSHOT~c5b6e464e4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.447 ms) : 0, 1447
crashtracking [candidate] (1.461 ms) : 0, 1461
BytebuddyAgent [baseline] (731.59 ms) : 0, 731590
BytebuddyAgent [candidate] (737.901 ms) : 0, 737901
GlobalTracer [baseline] (242.32 ms) : 0, 242320
GlobalTracer [candidate] (242.485 ms) : 0, 242485
AppSec [baseline] (30.262 ms) : 0, 30262
AppSec [candidate] (30.064 ms) : 0, 30064
Debugger [baseline] (6.414 ms) : 0, 6414
Debugger [candidate] (6.451 ms) : 0, 6451
Remote Config [baseline] (678.821 µs) : 0, 679
Remote Config [candidate] (677.385 µs) : 0, 677
Telemetry [baseline] (13.172 ms) : 0, 13172
Telemetry [candidate] (12.392 ms) : 0, 12392
section appsec
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (755.813 ms) : 0, 755813
BytebuddyAgent [candidate] (754.992 ms) : 0, 754992
GlobalTracer [baseline] (235.839 ms) : 0, 235839
GlobalTracer [candidate] (235.152 ms) : 0, 235152
AppSec [baseline] (166.385 ms) : 0, 166385
AppSec [candidate] (168.883 ms) : 0, 168883
Debugger [baseline] (10.142 ms) : 0, 10142
Debugger [candidate] (7.542 ms) : 0, 7542
Remote Config [baseline] (634.795 µs) : 0, 635
Remote Config [candidate] (644.826 µs) : 0, 645
Telemetry [baseline] (9.989 ms) : 0, 9989
Telemetry [candidate] (9.262 ms) : 0, 9262
IAST [baseline] (23.412 ms) : 0, 23412
IAST [candidate] (23.464 ms) : 0, 23464
section iast
crashtracking [baseline] (1.465 ms) : 0, 1465
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (857.152 ms) : 0, 857152
BytebuddyAgent [candidate] (857.815 ms) : 0, 857815
GlobalTracer [baseline] (233.18 ms) : 0, 233180
GlobalTracer [candidate] (233.405 ms) : 0, 233405
AppSec [baseline] (27.923 ms) : 0, 27923
AppSec [candidate] (28.226 ms) : 0, 28226
Debugger [baseline] (7.098 ms) : 0, 7098
Debugger [candidate] (6.128 ms) : 0, 6128
Remote Config [baseline] (619.645 µs) : 0, 620
Remote Config [candidate] (614.444 µs) : 0, 614
Telemetry [baseline] (8.353 ms) : 0, 8353
Telemetry [candidate] (8.302 ms) : 0, 8302
IAST [baseline] (29.45 ms) : 0, 29450
IAST [candidate] (29.236 ms) : 0, 29236
section profiling
crashtracking [baseline] (1.425 ms) : 0, 1425
crashtracking [candidate] (1.445 ms) : 0, 1445
BytebuddyAgent [baseline] (759.76 ms) : 0, 759760
BytebuddyAgent [candidate] (771.402 ms) : 0, 771402
GlobalTracer [baseline] (223.948 ms) : 0, 223948
GlobalTracer [candidate] (224.015 ms) : 0, 224015
AppSec [baseline] (30.423 ms) : 0, 30423
AppSec [candidate] (30.833 ms) : 0, 30833
Debugger [baseline] (7.449 ms) : 0, 7449
Debugger [candidate] (6.766 ms) : 0, 6766
Remote Config [baseline] (689.8 µs) : 0, 690
Remote Config [candidate] (711.243 µs) : 0, 711
Telemetry [baseline] (15.747 ms) : 0, 15747
Telemetry [candidate] (16.466 ms) : 0, 16466
ProfilingAgent [baseline] (107.785 ms) : 0, 107785
ProfilingAgent [candidate] (108.428 ms) : 0, 108428
Profiling [baseline] (108.49 ms) : 0, 108490
Profiling [candidate] (109.141 ms) : 0, 109141
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.54.0-SNAPSHOT~c1deff6c8b, baseline=1.54.0-SNAPSHOT~c5b6e464e4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.053 s) : 0, 1052663
Total [baseline] (8.613 s) : 0, 8613028
Agent [candidate] (1.046 s) : 0, 1045821
Total [candidate] (8.603 s) : 0, 8602895
section iast
Agent [baseline] (1.18 s) : 0, 1179544
Total [baseline] (9.294 s) : 0, 9293778
Agent [candidate] (1.181 s) : 0, 1181036
Total [candidate] (9.372 s) : 0, 9372000
gantt
title insecure-bank - break down per module: candidate=1.54.0-SNAPSHOT~c1deff6c8b, baseline=1.54.0-SNAPSHOT~c5b6e464e4
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.448 ms) : 0, 1448
BytebuddyAgent [baseline] (735.303 ms) : 0, 735303
BytebuddyAgent [candidate] (731.202 ms) : 0, 731202
GlobalTracer [baseline] (243.495 ms) : 0, 243495
GlobalTracer [candidate] (241.78 ms) : 0, 241780
AppSec [baseline] (30.262 ms) : 0, 30262
AppSec [candidate] (30.193 ms) : 0, 30193
Debugger [baseline] (6.47 ms) : 0, 6470
Debugger [candidate] (6.411 ms) : 0, 6411
Remote Config [baseline] (678.639 µs) : 0, 679
Remote Config [candidate] (669.299 µs) : 0, 669
Telemetry [baseline] (13.935 ms) : 0, 13935
Telemetry [candidate] (13.113 ms) : 0, 13113
section iast
crashtracking [baseline] (1.449 ms) : 0, 1449
crashtracking [candidate] (1.46 ms) : 0, 1460
BytebuddyAgent [baseline] (851.282 ms) : 0, 851282
BytebuddyAgent [candidate] (852.048 ms) : 0, 852048
GlobalTracer [baseline] (232.74 ms) : 0, 232740
GlobalTracer [candidate] (233.256 ms) : 0, 233256
AppSec [baseline] (26.854 ms) : 0, 26854
AppSec [candidate] (27.751 ms) : 0, 27751
Debugger [baseline] (6.991 ms) : 0, 6991
Debugger [candidate] (6.997 ms) : 0, 6997
Remote Config [baseline] (616.302 µs) : 0, 616
Remote Config [candidate] (632.562 µs) : 0, 633
Telemetry [baseline] (8.277 ms) : 0, 8277
Telemetry [candidate] (8.271 ms) : 0, 8271
IAST [baseline] (30.355 ms) : 0, 30355
IAST [candidate] (29.593 ms) : 0, 29593
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c1deff6c8b, baseline=1.54.0-SNAPSHOT~c5b6e464e4
dateFormat X
axisFormat %s
section baseline
no_agent (4.251 ms) : 4201, 4301
. : milestone, 4251,
iast (9.859 ms) : 9691, 10026
. : milestone, 9859,
iast_FULL (13.862 ms) : 13583, 14141
. : milestone, 13862,
iast_GLOBAL (10.5 ms) : 10300, 10700
. : milestone, 10500,
profiling (9.475 ms) : 9310, 9641
. : milestone, 9475,
tracing (7.753 ms) : 7633, 7873
. : milestone, 7753,
section candidate
no_agent (4.41 ms) : 4360, 4460
. : milestone, 4410,
iast (9.556 ms) : 9389, 9724
. : milestone, 9556,
iast_FULL (13.607 ms) : 13335, 13880
. : milestone, 13607,
iast_GLOBAL (10.354 ms) : 10174, 10534
. : milestone, 10354,
profiling (9.097 ms) : 8952, 9242
. : milestone, 9097,
tracing (7.73 ms) : 7618, 7842
. : milestone, 7730,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.54.0-SNAPSHOT~c1deff6c8b, baseline=1.54.0-SNAPSHOT~c5b6e464e4
dateFormat X
axisFormat %s
section baseline
no_agent (37.41 ms) : 37112, 37709
. : milestone, 37410,
appsec (48.482 ms) : 48058, 48907
. : milestone, 48482,
code_origins (45.941 ms) : 45542, 46340
. : milestone, 45941,
iast (45.117 ms) : 44728, 45506
. : milestone, 45117,
profiling (49.142 ms) : 48665, 49618
. : milestone, 49142,
tracing (44.36 ms) : 43998, 44723
. : milestone, 44360,
section candidate
no_agent (37.199 ms) : 36895, 37503
. : milestone, 37199,
appsec (51.377 ms) : 50919, 51836
. : milestone, 51377,
code_origins (46.121 ms) : 45721, 46521
. : milestone, 46121,
iast (45.341 ms) : 44955, 45727
. : milestone, 45341,
profiling (48.235 ms) : 47784, 48685
. : milestone, 48235,
tracing (45.618 ms) : 45229, 46007
. : milestone, 45618,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c1deff6c8b, baseline=1.54.0-SNAPSHOT~c5b6e464e4
dateFormat X
axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
. : milestone, 1478,
appsec (3.652 ms) : 3435, 3868
. : milestone, 3652,
iast (2.211 ms) : 2148, 2274
. : milestone, 2211,
iast_GLOBAL (2.264 ms) : 2200, 2328
. : milestone, 2264,
profiling (2.063 ms) : 2011, 2115
. : milestone, 2063,
tracing (2.028 ms) : 1979, 2078
. : milestone, 2028,
section candidate
no_agent (1.481 ms) : 1469, 1492
. : milestone, 1481,
appsec (3.68 ms) : 3461, 3898
. : milestone, 3680,
iast (2.21 ms) : 2147, 2273
. : milestone, 2210,
iast_GLOBAL (2.245 ms) : 2182, 2309
. : milestone, 2245,
profiling (2.076 ms) : 2023, 2128
. : milestone, 2076,
tracing (2.025 ms) : 1976, 2075
. : milestone, 2025,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.54.0-SNAPSHOT~c1deff6c8b, baseline=1.54.0-SNAPSHOT~c5b6e464e4
dateFormat X
axisFormat %s
section baseline
no_agent (14.898 s) : 14898000, 14898000
. : milestone, 14898000,
appsec (15.053 s) : 15053000, 15053000
. : milestone, 15053000,
iast (18.426 s) : 18426000, 18426000
. : milestone, 18426000,
iast_GLOBAL (18.272 s) : 18272000, 18272000
. : milestone, 18272000,
profiling (15.287 s) : 15287000, 15287000
. : milestone, 15287000,
tracing (14.911 s) : 14911000, 14911000
. : milestone, 14911000,
section candidate
no_agent (14.919 s) : 14919000, 14919000
. : milestone, 14919000,
appsec (14.909 s) : 14909000, 14909000
. : milestone, 14909000,
iast (18.811 s) : 18811000, 18811000
. : milestone, 18811000,
iast_GLOBAL (17.562 s) : 17562000, 17562000
. : milestone, 17562000,
profiling (16.063 s) : 16063000, 16063000
. : milestone, 16063000,
tracing (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
|
What Does This Do
A trivial fix to make sure we are not changing the case of a user provided script path
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issue